[next] arm: PM: domains: Delete usage of driver_deferred_probe_check_state()

[next] arm: PM: domains: Delete usage of driver_deferred_probe_check_state()

[Naresh Kamboju]

Linux next arm BeagleBoard x15 device boot failed due to the
following commit. The x15 did not event showed any crash log
on the serial console.
whereas, Linux mainline kernel boot pass.

Anders bisect this and found the first bad commit is

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

commit 5a46079a96451cfb15e4f5f01f73f7ba24ef851a
Author: Saravana Kannan <saravanak@google.com>
Date:   Wed Jun 1 00:06:57 2022 -0700

    PM: domains: Delete usage of driver_deferred_probe_check_state()

    Now that fw_devlink=on by default and fw_devlink supports
    "power-domains" property, the execution will never get to the point
    where driver_deferred_probe_check_state() is called before the supplier
    has probed successfully or before deferred probe timeout has expired.

    So, delete the call and replace it with -ENODEV.

    Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Saravana Kannan <saravanak@google.com>
    Link: https://lore.kernel.org/r/20220601070707.3946847-2-saravanak@google.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 739e52cd4aba..3e86772d5fac 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -2730,7 +2730,7 @@ static int __genpd_dev_pm_attach(struct device
*dev, struct device *base_dev,
                mutex_unlock(&gpd_list_lock);
                dev_dbg(dev, "%s() failed to find PM domain: %ld\n",
                        __func__, PTR_ERR(pd));
-               return driver_deferred_probe_check_state(base_dev);
+               return -ENODEV;
        }

        dev_dbg(dev, "adding to PM domain %s\n", pd->name);



--
Linaro LKFT
https://lkft.linaro.org

Re: [next] arm: PM: domains: Delete usage of driver_deferred_probe_check_state()

[Saravana Kannan]

On Tue, Jul 26, 2022 at 11:44 PM Naresh Kamboju
<naresh.kamboju@linaro.org> wrote:
>
> Linux next arm BeagleBoard x15 device boot failed due to the

Can you point me to the dts file that corresponds to this board
please? And if you know which devices are power domains, that'd be
handy too. For now, I'm reverting this patch.

-Saravana

> following commit. The x15 did not event showed any crash log
> on the serial console.
> whereas, Linux mainline kernel boot pass.
>
> Anders bisect this and found the first bad commit is
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> commit 5a46079a96451cfb15e4f5f01f73f7ba24ef851a
> Author: Saravana Kannan <saravanak@google.com>
> Date:   Wed Jun 1 00:06:57 2022 -0700
>
>     PM: domains: Delete usage of driver_deferred_probe_check_state()
>
>     Now that fw_devlink=on by default and fw_devlink supports
>     "power-domains" property, the execution will never get to the point
>     where driver_deferred_probe_check_state() is called before the supplier
>     has probed successfully or before deferred probe timeout has expired.
>
>     So, delete the call and replace it with -ENODEV.
>
>     Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
>     Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
>     Signed-off-by: Saravana Kannan <saravanak@google.com>
>     Link: https://lore.kernel.org/r/20220601070707.3946847-2-saravanak@google.com
>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index 739e52cd4aba..3e86772d5fac 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -2730,7 +2730,7 @@ static int __genpd_dev_pm_attach(struct device
> *dev, struct device *base_dev,
>                 mutex_unlock(&gpd_list_lock);
>                 dev_dbg(dev, "%s() failed to find PM domain: %ld\n",
>                         __func__, PTR_ERR(pd));
> -               return driver_deferred_probe_check_state(base_dev);
> +               return -ENODEV;
>         }
>
>         dev_dbg(dev, "adding to PM domain %s\n", pd->name);
>
>
>
> --
> Linaro LKFT
> https://lkft.linaro.org

Re: [next] arm: PM: domains: Delete usage of driver_deferred_probe_check_state()

[Naresh Kamboju]

Hi Saravana,

On Thu, 28 Jul 2022 at 00:19, Saravana Kannan <saravanak@google.com> wrote:
>
> On Tue, Jul 26, 2022 at 11:44 PM Naresh Kamboju
> <naresh.kamboju@linaro.org> wrote:
> >
> > Linux next arm BeagleBoard x15 device boot failed due to the
>
> Can you point me to the dts file that corresponds to this board
> please? And if you know which devices are power domains, that'd be
> handy too. For now, I'm reverting this patch.
metadata:
  git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
  git_sha: 9250d2f72dc46a808b6aa23bf50dd670f1f52ddc
  git_describe: v5.19-rc7-13490-g9250d2f72dc4
  git_ref: master
  kernel_version: 5.19.0-rc8
  kernel-config: https://builds.tuxbuild.com/2CWh3jswUGEkjvfXQPGXdOceMFH/config
  artifact-location: https://builds.tuxbuild.com/2CWh3jswUGEkjvfXQPGXdOceMFH
  toolchain: gcc-10

I am sharing a few urls, metadata, test job link and device details link.

      kernel:
        url: https://builds.tuxbuild.com/2CWh3jswUGEkjvfXQPGXdOceMFH/zImage
      dtb:
        url: https://builds.tuxbuild.com/2CWh3jswUGEkjvfXQPGXdOceMFH/dtbs/am57xx-beagle-x15.dtb
      modules:
        url: https://builds.tuxbuild.com/2CWh3jswUGEkjvfXQPGXdOceMFH/modules.tar.xz

Test jobs url:
       - https://lkft.validation.linaro.org/scheduler/job/5326314#L1982

Device details link,
      - https://www.ti.com/tool/BEAGLEBOARD-X15

metadata:
  git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
  git_sha: 9250d2f72dc46a808b6aa23bf50dd670f1f52ddc
  git_describe: v5.19-rc7-13490-g9250d2f72dc4
  git_ref: master
  kernel_version: 5.19.0-rc8
  kernel-config: https://builds.tuxbuild.com/2CWh3jswUGEkjvfXQPGXdOceMFH/config
  artifact-location: https://builds.tuxbuild.com/2CWh3jswUGEkjvfXQPGXdOceMFH
  toolchain: gcc-10

- Naresh

Re: [next] arm: PM: domains: Delete usage of driver_deferred_probe_check_state()

[Saravana Kannan]

On Wed, Jul 27, 2022 at 10:35 PM Naresh Kamboju
<naresh.kamboju@linaro.org> wrote:
>
> Hi Saravana,
>
> On Thu, 28 Jul 2022 at 00:19, Saravana Kannan <saravanak@google.com> wrote:
> >
> > On Tue, Jul 26, 2022 at 11:44 PM Naresh Kamboju
> > <naresh.kamboju@linaro.org> wrote:
> > >
> > > Linux next arm BeagleBoard x15 device boot failed due to the
> >
> > Can you point me to the dts file that corresponds to this board
> > please? And if you know which devices are power domains, that'd be
> > handy too. For now, I'm reverting this patch.
> metadata:
>   git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
>   git_sha: 9250d2f72dc46a808b6aa23bf50dd670f1f52ddc
>   git_describe: v5.19-rc7-13490-g9250d2f72dc4
>   git_ref: master
>   kernel_version: 5.19.0-rc8
>   kernel-config: https://builds.tuxbuild.com/2CWh3jswUGEkjvfXQPGXdOceMFH/config
>   artifact-location: https://builds.tuxbuild.com/2CWh3jswUGEkjvfXQPGXdOceMFH
>   toolchain: gcc-10
>
> I am sharing a few urls, metadata, test job link and device details link.
>
>       kernel:
>         url: https://builds.tuxbuild.com/2CWh3jswUGEkjvfXQPGXdOceMFH/zImage
>       dtb:
>         url: https://builds.tuxbuild.com/2CWh3jswUGEkjvfXQPGXdOceMFH/dtbs/am57xx-beagle-x15.dtb
>       modules:
>         url: https://builds.tuxbuild.com/2CWh3jswUGEkjvfXQPGXdOceMFH/modules.tar.xz
>
> Test jobs url:
>        - https://lkft.validation.linaro.org/scheduler/job/5326314#L1982
>
> Device details link,
>       - https://www.ti.com/tool/BEAGLEBOARD-X15
>
> metadata:
>   git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
>   git_sha: 9250d2f72dc46a808b6aa23bf50dd670f1f52ddc
>   git_describe: v5.19-rc7-13490-g9250d2f72dc4
>   git_ref: master
>   kernel_version: 5.19.0-rc8
>   kernel-config: https://builds.tuxbuild.com/2CWh3jswUGEkjvfXQPGXdOceMFH/config
>   artifact-location: https://builds.tuxbuild.com/2CWh3jswUGEkjvfXQPGXdOceMFH
>   toolchain: gcc-10
>

Ah, I forgot to CC you on a series that might fix this. Can you give
this a shot please?

https://lore.kernel.org/lkml/20220810060040.321697-1-saravanak@google.com/

Thanks,
Saravana

Re: [next] arm: PM: domains: Delete usage of driver_deferred_probe_check_state()

[Naresh Kamboju]

Hi Saravana,

On Sat, 13 Aug 2022 at 06:23, Saravana Kannan <saravanak@google.com> wrote:
>
> On Wed, Jul 27, 2022 at 10:35 PM Naresh Kamboju
> <naresh.kamboju@linaro.org> wrote:
>
> Ah, I forgot to CC you on a series that might fix this. Can you give
> this a shot please?

I have tested your patch and boot is successful on x15 device.

>
> https://lore.kernel.org/lkml/20220810060040.321697-1-saravanak@google.com/

Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
Tested-by: Naresh Kamboju <naresh.kamboju@linaro.org>

- Naresh
PS: Add these tested by tags in the main thread.

- Naresh