* [PATCH 1/1] mtd: rawnand: Add deassert_wp comment
@ 2023-12-01 18:15 dregan
2023-12-01 18:38 ` Boris Brezillon
0 siblings, 1 reply; 3+ messages in thread
From: dregan @ 2023-12-01 18:15 UTC (permalink / raw)
To: dregan, Miquel Raynal, Stephen Rothwell, Boris Brezillon,
Boris Brezillon, Richard Weinberger, Vignesh Raghavendra,
linux-mtd, linux-kernel, Linux Next Mailing List
From: Boris Brezillon <bbrezillon@kernel.org>
Add deassert_wp description comment
Signed-off-by: Boris Brezillon <bbrezillon@kernel.org>
Signed-off-by: David Regan <dregan@broadcom.com>
---
include/linux/mtd/rawnand.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
index fcad94aa0515..3049b05d8a20 100644
--- a/include/linux/mtd/rawnand.h
+++ b/include/linux/mtd/rawnand.h
@@ -1001,6 +1001,8 @@ struct nand_op_parser {
/**
* struct nand_operation - NAND operation descriptor
* @cs: the CS line to select for this NAND operation
+ * @deassert_wp: set to true when the operation requires the WP pin to be
+ * de-asserted (ERASE, PROG, ...)
* @instrs: array of instructions to execute
* @ninstrs: length of the @instrs array
*
--
2.37.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] mtd: rawnand: Add deassert_wp comment
2023-12-01 18:15 [PATCH 1/1] mtd: rawnand: Add deassert_wp comment dregan
@ 2023-12-01 18:38 ` Boris Brezillon
2023-12-01 18:45 ` David Regan
0 siblings, 1 reply; 3+ messages in thread
From: Boris Brezillon @ 2023-12-01 18:38 UTC (permalink / raw)
To: dregan
Cc: Miquel Raynal, Stephen Rothwell, Boris Brezillon,
Richard Weinberger, Vignesh Raghavendra, linux-mtd, linux-kernel,
Linux Next Mailing List
On Fri, 1 Dec 2023 10:15:42 -0800
dregan <dregan@broadcom.com> wrote:
> From: Boris Brezillon <bbrezillon@kernel.org>
I'm pretty sure I shouldn't be the author. The original patch might
have been partly written by me, but this is a fixup on top of it.
>
> Add deassert_wp description comment
>
> Signed-off-by: Boris Brezillon <bbrezillon@kernel.org>
and you should drop my SoB too.
> Signed-off-by: David Regan <dregan@broadcom.com>
> ---
> include/linux/mtd/rawnand.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
> index fcad94aa0515..3049b05d8a20 100644
> --- a/include/linux/mtd/rawnand.h
> +++ b/include/linux/mtd/rawnand.h
> @@ -1001,6 +1001,8 @@ struct nand_op_parser {
> /**
> * struct nand_operation - NAND operation descriptor
> * @cs: the CS line to select for this NAND operation
> + * @deassert_wp: set to true when the operation requires the WP pin to be
> + * de-asserted (ERASE, PROG, ...)
> * @instrs: array of instructions to execute
> * @ninstrs: length of the @instrs array
> *
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] mtd: rawnand: Add deassert_wp comment
2023-12-01 18:38 ` Boris Brezillon
@ 2023-12-01 18:45 ` David Regan
0 siblings, 0 replies; 3+ messages in thread
From: David Regan @ 2023-12-01 18:45 UTC (permalink / raw)
To: Boris Brezillon
Cc: dregan, Miquel Raynal, Stephen Rothwell, Boris Brezillon,
Richard Weinberger, Vignesh Raghavendra, linux-mtd, linux-kernel,
Linux Next Mailing List
I'm sorry my mistake, I had originally missed this comment which came from here:
https://github.com/bbrezillon/linux/commit/e612e1f2c69a33ac5f2c91d13669f0f172d58717
On Fri, Dec 1, 2023 at 10:38 AM Boris Brezillon
<boris.brezillon@collabora.com> wrote:
>
> On Fri, 1 Dec 2023 10:15:42 -0800
> dregan <dregan@broadcom.com> wrote:
>
> > From: Boris Brezillon <bbrezillon@kernel.org>
>
> I'm pretty sure I shouldn't be the author. The original patch might
> have been partly written by me, but this is a fixup on top of it.
>
> >
> > Add deassert_wp description comment
> >
> > Signed-off-by: Boris Brezillon <bbrezillon@kernel.org>
>
> and you should drop my SoB too.
>
> > Signed-off-by: David Regan <dregan@broadcom.com>
> > ---
> > include/linux/mtd/rawnand.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
> > index fcad94aa0515..3049b05d8a20 100644
> > --- a/include/linux/mtd/rawnand.h
> > +++ b/include/linux/mtd/rawnand.h
> > @@ -1001,6 +1001,8 @@ struct nand_op_parser {
> > /**
> > * struct nand_operation - NAND operation descriptor
> > * @cs: the CS line to select for this NAND operation
> > + * @deassert_wp: set to true when the operation requires the WP pin to be
> > + * de-asserted (ERASE, PROG, ...)
> > * @instrs: array of instructions to execute
> > * @ninstrs: length of the @instrs array
> > *
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-01 18:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-01 18:15 [PATCH 1/1] mtd: rawnand: Add deassert_wp comment dregan
2023-12-01 18:38 ` Boris Brezillon
2023-12-01 18:45 ` David Regan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).