linux-next: build failure after merge of the pinctrl tree

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

Hi all,

After merging the pinctrl tree, today's linux-next build (x86_64
allmodconfig ) failed like this:


Presumably caused by commit

  c9e84d46cc03 ("pinctrl: rockchip: make driver be tristate module")

I have used the pinctrl tree from next-20210303 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Thu, Mar 4, 2021 at 2:12 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig ) failed like this:
>
>
> Presumably caused by commit
>
>   c9e84d46cc03 ("pinctrl: rockchip: make driver be tristate module")
>
> I have used the pinctrl tree from next-20210303 for today.

Thanks Stephen, I'm taking the patch out again.

Yours,
Linus Walleij

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

Hi Linus,

On Thu, 4 Mar 2021 09:16:17 +0100 Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Thu, Mar 4, 2021 at 2:12 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > After merging the pinctrl tree, today's linux-next build (x86_64
> > allmodconfig ) failed like this:
> >
> >
> > Presumably caused by commit
> >
> >   c9e84d46cc03 ("pinctrl: rockchip: make driver be tristate module")
> >
> > I have used the pinctrl tree from next-20210303 for today.  
> 
> Thanks Stephen, I'm taking the patch out again.

Sorry I managed to not put the error message in the mail :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

Re: Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Fri, Mar 5, 2021 at 1:13 AM jay.xu@rock-chips.com
<jay.xu@rock-chips.com> wrote:

> Could you show me the issue log ?

It's attached to Stephen's original mail in this thread.

Yours,
Linus Walleij

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1885 bytes --]

Hi,

On Fri, 5 Mar 2021 08:46:46 +0800 "jay.xu@rock-chips.com" <jay.xu@rock-chips.com> wrote:
>
> Thanks，and I think i have miss to upstream the changes,
> I have resend them in a new thread.
> 
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -155,9 +155,7 @@ config ARCH_REALTEK
>  config ARCH_ROCKCHIP
>         bool "Rockchip Platforms"
>         select ARCH_HAS_RESET_CONTROLLER
> -       select GPIOLIB
>         select PINCTRL
> -       select PINCTRL_ROCKCHIP
>         select PM
>         select ROCKCHIP_TIMER
>         help
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index b197d23324fb..970c18191f6f 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -179,10 +179,14 @@ config PINCTRL_OXNAS
>  
>  config PINCTRL_ROCKCHIP
>         tristate "Rockchip gpio and pinctrl driver"
> +       select GPIOLIB
>         select PINMUX
>         select GENERIC_PINCONF
>         select GENERIC_IRQ_CHIP
>         select MFD_SYSCON
> +       default ARCH_ROCKCHIP
> +       help
> +         This support pinctrl and gpio driver for Rockchip SoCs.
>  
>  config PINCTRL_RZA1
>         bool "Renesas RZ/A1 gpio and pinctrl driver"
> 
> 
>  
> From: Linus Walleij
> Date: 2021-03-05 08:43
> To: jay.xu@rock-chips.com
> CC: Stephen Rothwell; Linux Kernel Mailing List; Linux Next Mailing List
> Subject: Re: Re: linux-next: build failure after merge of the pinctrl tree
> On Fri, Mar 5, 2021 at 1:13 AM jay.xu@rock-chips.com
> <jay.xu@rock-chips.com> wrote:
>  
> > Could you show me the issue log ?  
>  
> It's attached to Stephen's original mail in this thread.

Sorry I lost the error message, but it was a reference to a symbol that
has no EXPORT_SYMBOL.  So building the driver as a module should show
the error.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]