* Re: [RE-RESEND][PATCH] audit: replace defines with C stubs
[not found] <20120807004041.GA27896@www.outflux.net>
@ 2012-09-13 19:43 ` Geert Uytterhoeven
2012-09-20 22:40 ` Kees Cook
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2012-09-13 19:43 UTC (permalink / raw)
To: Kees Cook, Jonas Bonn
Cc: linux-kernel, Al Viro, Eric Paris, linux, Linux-Next
On Tue, Aug 7, 2012 at 2:40 AM, Kees Cook <keescook@chromium.org> wrote:
> This replaces the #defines used when CONFIG_AUDIT or CONFIG_AUDIT_SYSCALLS
> are disabled so we get type checking during those builds.
>
> Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Kees Cook <keescook@chromium.org>
JFYI, the change
-#define audit_syscall_entry(ta,a,b,c,d,e) do { ; } while (0)
+static inline void audit_syscall_entry(int arch, int major, unsigned long a0,
+ unsigned long a1, unsigned long a2,
+ unsigned long a3)
+{ }
uncovers a bug on OpenRISC.
Before,
audit_syscall_entry(audit_arch(), regs->gpr[11],
regs->gpr[3], regs->gpr[4],
regs->gpr[5], regs->gpr[6]);
just expanded to nothing if CONFIG_AUDITSYSCALL was not set.
Now, it fails to compile with:
arch/openrisc/kernel/ptrace.c:190:2: error: implicit declaration of
function 'audit_arch'
http://kisskb.ellerman.id.au/kisskb/buildresult/7191698/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RE-RESEND][PATCH] audit: replace defines with C stubs
2012-09-13 19:43 ` [RE-RESEND][PATCH] audit: replace defines with C stubs Geert Uytterhoeven
@ 2012-09-20 22:40 ` Kees Cook
0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2012-09-20 22:40 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Jonas Bonn, linux-kernel, Al Viro, Eric Paris, linux, Linux-Next
On Thu, Sep 13, 2012 at 12:43 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Tue, Aug 7, 2012 at 2:40 AM, Kees Cook <keescook@chromium.org> wrote:
>> This replaces the #defines used when CONFIG_AUDIT or CONFIG_AUDIT_SYSCALLS
>> are disabled so we get type checking during those builds.
>>
>> Suggested-by: Andrew Morton <akpm@linux-foundation.org>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>
> JFYI, the change
>
> -#define audit_syscall_entry(ta,a,b,c,d,e) do { ; } while (0)
> +static inline void audit_syscall_entry(int arch, int major, unsigned long a0,
> + unsigned long a1, unsigned long a2,
> + unsigned long a3)
> +{ }
>
> uncovers a bug on OpenRISC.
>
> Before,
>
> audit_syscall_entry(audit_arch(), regs->gpr[11],
> regs->gpr[3], regs->gpr[4],
> regs->gpr[5], regs->gpr[6]);
>
> just expanded to nothing if CONFIG_AUDITSYSCALL was not set.
> Now, it fails to compile with:
>
> arch/openrisc/kernel/ptrace.c:190:2: error: implicit declaration of
> function 'audit_arch'
> http://kisskb.ellerman.id.au/kisskb/buildresult/7191698/
Thanks for catching this! It looks like audit.h is missing
AUDIT_ARCH_OPENRISC entirely, and that openrisc doesn't need an
audit_arch() function at all. It could use AUDIT_ARCH_OPENRISC once
that existed, which would just be EM_OPENRISC. (It looks like little
endian mode isn't used.)
I'll send a patch...
-Kees
--
Kees Cook
Chrome OS Security
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-20 22:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20120807004041.GA27896@www.outflux.net>
2012-09-13 19:43 ` [RE-RESEND][PATCH] audit: replace defines with C stubs Geert Uytterhoeven
2012-09-20 22:40 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).