linux-next: Fixes tag needs some work in the imx-mxs tree

linux-next: Fixes tag needs some work in the imx-mxs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

Hi all,

In commit

  c1f84a75babe ("arm64: dts: imx8mp-venice-gw74xx: fix port/phy validation")

Fixes tag

  Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the imx-mxs tree

[Tim Harvey]

On Tue, Sep 13, 2022 at 3:16 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   c1f84a75babe ("arm64: dts: imx8mp-venice-gw74xx: fix port/phy validation")
>
> Fixes tag
>
>   Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400
>
> has these problem(s):
>
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than one line.
>

Stephen,

Sorry, that was my fault with my editor's word-wrap getting in the
way. I will be more careful in the future.

Is there anything that I can and should do at this point to result this one?

Best Regards,

Tim

Re: linux-next: Fixes tag needs some work in the imx-mxs tree

[Shawn Guo]

On Tue, Sep 13, 2022 at 10:08:16AM -0700, Tim Harvey wrote:
> On Tue, Sep 13, 2022 at 3:16 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > In commit
> >
> >   c1f84a75babe ("arm64: dts: imx8mp-venice-gw74xx: fix port/phy validation")
> >
> > Fixes tag
> >
> >   Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400
> >
> > has these problem(s):
> >
> >   - Subject has leading but no trailing parentheses
> >   - Subject has leading but no trailing quotes
> >
> > Please do not split Fixes tags over more than one line.
> >
> 
> Stephen,
> 
> Sorry, that was my fault with my editor's word-wrap getting in the
> way. I will be more careful in the future.
> 
> Is there anything that I can and should do at this point to result this one?

I fixed it up.

Shawn

Re: linux-next: Fixes tag needs some work in the imx-mxs tree

[Tim Harvey]

On Tue, Sep 13, 2022 at 8:48 PM Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Tue, Sep 13, 2022 at 10:08:16AM -0700, Tim Harvey wrote:
> > On Tue, Sep 13, 2022 at 3:16 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > Hi all,
> > >
> > > In commit
> > >
> > >   c1f84a75babe ("arm64: dts: imx8mp-venice-gw74xx: fix port/phy validation")
> > >
> > > Fixes tag
> > >
> > >   Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400
> > >
> > > has these problem(s):
> > >
> > >   - Subject has leading but no trailing parentheses
> > >   - Subject has leading but no trailing quotes
> > >
> > > Please do not split Fixes tags over more than one line.
> > >
> >
> > Stephen,
> >
> > Sorry, that was my fault with my editor's word-wrap getting in the
> > way. I will be more careful in the future.
> >
> > Is there anything that I can and should do at this point to result this one?
>
> I fixed it up.
>
> Shawn

Thanks Shawn!

I guess this would be a nice thing for checkpatch to catch.

Tim

linux-next: Fixes tag needs some work in the imx-mxs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

Hi all,

In commit

  50f8906b310e ("arm64: dts: freescale: imx8-ss-lsio: Fix #pwm-cells")

Fixes tag

  Fixes: a05c329644d81 ("arm64: dts: freescale: imx8-ss-lsio: add support for lsio_pwm0-3")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 23fa99b205ea ("arm64: dts: freescale: imx8-ss-lsio: add support for lsio_pwm0-3")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the imx-mxs tree

[Shawn Guo]

On Wed, Dec 6, 2023 at 12:47 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   50f8906b310e ("arm64: dts: freescale: imx8-ss-lsio: Fix #pwm-cells")
>
> Fixes tag
>
>   Fixes: a05c329644d81 ("arm64: dts: freescale: imx8-ss-lsio: add support for lsio_pwm0-3")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 23fa99b205ea ("arm64: dts: freescale: imx8-ss-lsio: add support for lsio_pwm0-3")

Fixed.  Thanks for reporting!

Shawn

linux-next: Fixes tag needs some work in the imx-mxs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

Hi all,

In commit

  cb3c29e7d263 ("arm64: dts: imx8mp-venice-gw74xx: remove unecessary propreties in tpm node")

Fixes tag

  Fixes: commit 531936b218d8 ("arm64: dts: imx8mp-venice-gw74xx: update to revB PCB")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the imx-mxs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

Hi all,

In commit

  c9545754e9a7 ("arm64: dts: verdin-imx8mp: fix ctrl_sleep_moci")

Fixes tag

  Fixes: 1d8df9c74bff ("arm64: dts: freescale: add initial support for verdin imx8m plus")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: a39ed23bdf6e ("arm64: dts: freescale: add initial support for verdin imx8m plus")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the imx-mxs tree

[Francesco Dolcini]

On Mon, Oct 24, 2022 at 03:37:20PM +1100, Stephen Rothwell wrote:
> In commit
> 
>   c9545754e9a7 ("arm64: dts: verdin-imx8mp: fix ctrl_sleep_moci")
> 
> Fixes tag
> 
>   Fixes: 1d8df9c74bff ("arm64: dts: freescale: add initial support for verdin imx8m plus")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: a39ed23bdf6e ("arm64: dts: freescale: add initial support for verdin imx8m plus")
correct, sorry for the mistake :/

Shawn: I assume you can fix it, let me know otherwise.

Hopefully since commit  bd17e036b495 ("checkpatch: warn for non-standard fixes tag style")
was merged these kind of mistakes should be less and less frequent.

Francesco

Re: linux-next: Fixes tag needs some work in the imx-mxs tree

[Marcel Ziswiler]

Hi Stephen

On Mon, 2022-10-24 at 15:37 +1100, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   c9545754e9a7 ("arm64: dts: verdin-imx8mp: fix ctrl_sleep_moci")
> 
> Fixes tag
> 
>   Fixes: 1d8df9c74bff ("arm64: dts: freescale: add initial support for verdin imx8m plus")

Oh shoot, I guess Max referenced the commit from our downstream branch and while I checked the commit to exist
on my end I missed it being a downstream one:

⬢[zim@toolbox linux-toradex-imx.git]$ git branch --contains 1d8df9c74bff5d36d755324be1e695abf9cdeca8
  toradex_5.15-2.0.x-imx

> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: a39ed23bdf6e ("arm64: dts: freescale: add initial support for verdin imx8m plus")

Yes, Indeed, that must be the correct one:

⬢[zim@toolbox linux-next.git]$ git branch --contains a39ed23bdf6ec7eb0f093b6ef0391e1f3d152f71
  v5.19
  v6.0

Sorry about that!

@Shawn: Can you fix this up or do I need to re-send anything?

Thanks!

Cheers

Marcel

Re: linux-next: Fixes tag needs some work in the imx-mxs tree

[Shawn Guo]

On Mon, Oct 24, 2022 at 07:07:26AM +0000, Marcel Ziswiler wrote:
> Hi Stephen
> 
> On Mon, 2022-10-24 at 15:37 +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > In commit
> > 
> >   c9545754e9a7 ("arm64: dts: verdin-imx8mp: fix ctrl_sleep_moci")
> > 
> > Fixes tag
> > 
> >   Fixes: 1d8df9c74bff ("arm64: dts: freescale: add initial support for verdin imx8m plus")
> 
> Oh shoot, I guess Max referenced the commit from our downstream branch and while I checked the commit to exist
> on my end I missed it being a downstream one:
> 
> ⬢[zim@toolbox linux-toradex-imx.git]$ git branch --contains 1d8df9c74bff5d36d755324be1e695abf9cdeca8
>   toradex_5.15-2.0.x-imx
> 
> > has these problem(s):
> > 
> >   - Target SHA1 does not exist
> > 
> > Maybe you meant
> > 
> > Fixes: a39ed23bdf6e ("arm64: dts: freescale: add initial support for verdin imx8m plus")
> 
> Yes, Indeed, that must be the correct one:
> 
> ⬢[zim@toolbox linux-next.git]$ git branch --contains a39ed23bdf6ec7eb0f093b6ef0391e1f3d152f71
>   v5.19
>   v6.0
> 
> Sorry about that!
> 
> @Shawn: Can you fix this up or do I need to re-send anything?

Fixed.

Shawn

linux-next: Fixes tag needs some work in the imx-mxs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

Hi all,

In commit

  47170487f674 ("arm64: dts: imx8mm-verdin: extend pmic voltages")

Fixes tag

  Fixes: commit 6a57f224f734 ("arm64: dts: freescale: add initial support for verdin imx8m mini")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the imx-mxs tree

[Marcel Ziswiler]

Hi Stephen and Shawn

On Tue, 2022-09-06 at 07:37 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   47170487f674 ("arm64: dts: imx8mm-verdin: extend pmic voltages")
> 
> Fixes tag
> 
>   Fixes: commit 6a57f224f734 ("arm64: dts: freescale: add initial support for verdin imx8m mini")
> 
> has these problem(s):
> 
>   - leading word 'commit' unexpected

Sorry, I missed this and checkpatch did not warn about that one.

@Shawn: Can you fix this or do I or Philippe need to do anything like sending you another version with this
fixed?

Cheers

Marcel

Re: linux-next: Fixes tag needs some work in the imx-mxs tree

[Shawn Guo]

On Tue, Sep 6, 2022 at 3:23 PM Marcel Ziswiler
<marcel.ziswiler@toradex.com> wrote:
>
> Hi Stephen and Shawn
>
> On Tue, 2022-09-06 at 07:37 +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> >   47170487f674 ("arm64: dts: imx8mm-verdin: extend pmic voltages")
> >
> > Fixes tag
> >
> >   Fixes: commit 6a57f224f734 ("arm64: dts: freescale: add initial support for verdin imx8m mini")
> >
> > has these problem(s):
> >
> >   - leading word 'commit' unexpected
>
> Sorry, I missed this and checkpatch did not warn about that one.
>
> @Shawn: Can you fix this or do I or Philippe need to do anything like sending you another version with this
> fixed?

I have fixed it up.

Shawn

linux-next: Fixes tag needs some work in the imx-mxs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

Hi all,

n commit

  4e69ed8427ef ("ARM: dts: imx6qdl: correct PU regulator ramp delay")

Fixes tag

  Fixes: 40130d327f72 ("ARM: dts: imx6qdl: Allow disabling the PU regulator,

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the imx-mxs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

Hi all,

In commit

  a5b99c8fcd1b ("ARM: dts: imx6dl-colibri: Fix I2C pinmuxing")

Fixes tag

  Fixes: 56f0df6b6b58 ("ARM: dts: imx*(colibri|apalis): add missing

has these problem(s):

  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.  Also, keep all
the commit message tags together at the end of the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the imx-mxs tree

[Max Krummenacher]

Am Dienstag, dem 19.04.2022 um 06:50 +1000 schrieb Stephen Rothwell:
> Hi all,
> 
> In commit
> 
>   a5b99c8fcd1b ("ARM: dts: imx6dl-colibri: Fix I2C pinmuxing")
> 
> Fixes tag
> 
>   Fixes: 56f0df6b6b58 ("ARM: dts: imx*(colibri|apalis): add missing
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.  Also, keep all
> the commit message tags together at the end of the commit message.
> 

Sorry about that. I've seen you already fixed it. Thanks a lot, appreciated.
Regards
Max

linux-next: Fixes tag needs some work in the imx-mxs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

Hi all,

In commit

  91f6d5f181f6 ("arm64: dts: imx8mq: fix lcdif port node")

Fixes tag

  Fixes: commit d0081bd02a03 ("arm64: dts: imx8mq: Add NWL MIPI DSI controller")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the imx-mxs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

Hi all,

In commit

  f5adb50e9aa3 ("Revert "soc: imx8m: change to use platform driver"")

Fixes tag

  Fixes: 7d981405d0fd ("soc: imx8m: change to use platform driver"")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Probably not worth rebasing for.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the imx-mxs tree

[Shawn Guo]

On Thu, Jul 15, 2021 at 08:04:03AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   f5adb50e9aa3 ("Revert "soc: imx8m: change to use platform driver"")
> 
> Fixes tag
> 
>   Fixes: 7d981405d0fd ("soc: imx8m: change to use platform driver"")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'

Fixed, thanks!

Shawn

linux-next: Fixes tag needs some work in the imx-mxs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

Hi all,

In commit

  d969e9c05f83 ("ARM: dts: imx6q-prti6q: fix PHY address")

Fixes tag

  Fixes: 0d446a50559 ("ARM: dts: add Protonic PRTI6Q board")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the imx-mxs tree

[Shawn Guo]

On Mon, Nov 02, 2020 at 08:24:13AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   d969e9c05f83 ("ARM: dts: imx6q-prti6q: fix PHY address")
> 
> Fixes tag
> 
>   Fixes: 0d446a50559 ("ARM: dts: add Protonic PRTI6Q board")
> 
> has these problem(s):

Thanks, Stephen.  Fixed.

> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

Oleksij,

Please check your git setup as suggested.

Shawn

Re: linux-next: Fixes tag needs some work in the imx-mxs tree

[Oleksij Rempel]

On Mon, Nov 02, 2020 at 08:02:22AM +0800, Shawn Guo wrote:
> On Mon, Nov 02, 2020 at 08:24:13AM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > In commit
> > 
> >   d969e9c05f83 ("ARM: dts: imx6q-prti6q: fix PHY address")
> > 
> > Fixes tag
> > 
> >   Fixes: 0d446a50559 ("ARM: dts: add Protonic PRTI6Q board")
> > 
> > has these problem(s):
> 
> Thanks, Stephen.  Fixed.
> 
> > 
> >   - SHA1 should be at least 12 digits long
> >     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> >     or later) just making sure it is not set (or set to "auto").
> 
> Oleksij,
> 
> Please check your git setup as suggested.

OK, done. Thank you!

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

linux-next: Fixes tag needs some work in the imx-mxs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

Hi all,

In commit

  f6a8ff82ce68 ("clk: imx: imx8mm: correct audio_pll2_clk to audio_pll2_out")

Fixes tag

  Fixes: ba5625c3e27 ("clk: imx: Add clock driver support for imx8mm")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the imx-mxs tree

[Shawn Guo]

On Fri, Jun 07, 2019 at 07:46:52AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   f6a8ff82ce68 ("clk: imx: imx8mm: correct audio_pll2_clk to audio_pll2_out")
> 
> Fixes tag
> 
>   Fixes: ba5625c3e27 ("clk: imx: Add clock driver support for imx8mm")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

Hi Stephen,

Thanks for reporting.  I just got it fixed, will be more careful about
that in the future.

@Peng, please check your git configuration as suggested above, thanks.

Shawn

RE: linux-next: Fixes tag needs some work in the imx-mxs tree

[Peng Fan]

Hi Shawn, Stephen
> Subject: Re: linux-next: Fixes tag needs some work in the imx-mxs tree
> 
> On Fri, Jun 07, 2019 at 07:46:52AM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> >   f6a8ff82ce68 ("clk: imx: imx8mm: correct audio_pll2_clk to
> > audio_pll2_out")
> >
> > Fixes tag
> >
> >   Fixes: ba5625c3e27 ("clk: imx: Add clock driver support for imx8mm")
> >
> > has these problem(s):
> >
> >   - SHA1 should be at least 12 digits long
> >     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> >     or later) just making sure it is not set (or set to "auto").
> 
> Hi Stephen,
> 
> Thanks for reporting.  I just got it fixed, will be more careful about that in the
> future.
> 
> @Peng, please check your git configuration as suggested above, thanks.

Sorry for this. Do I need to resend the patch?

Thanks,
Peng.

> 
> Shawn

Re: linux-next: Fixes tag needs some work in the imx-mxs tree

[Shawn Guo]

On Tue, Jun 11, 2019 at 08:36:52AM +0000, Peng Fan wrote:
> Hi Shawn, Stephen
> > Subject: Re: linux-next: Fixes tag needs some work in the imx-mxs tree
> > 
> > On Fri, Jun 07, 2019 at 07:46:52AM +1000, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > In commit
> > >
> > >   f6a8ff82ce68 ("clk: imx: imx8mm: correct audio_pll2_clk to
> > > audio_pll2_out")
> > >
> > > Fixes tag
> > >
> > >   Fixes: ba5625c3e27 ("clk: imx: Add clock driver support for imx8mm")
> > >
> > > has these problem(s):
> > >
> > >   - SHA1 should be at least 12 digits long
> > >     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> > >     or later) just making sure it is not set (or set to "auto").
> > 
> > Hi Stephen,
> > 
> > Thanks for reporting.  I just got it fixed, will be more careful about that in the
> > future.
> > 
> > @Peng, please check your git configuration as suggested above, thanks.
> 
> Sorry for this. Do I need to resend the patch?

No.  I have fixed it on my branch.

Shawn

RE: linux-next: Fixes tag needs some work in the imx-mxs tree

[Peng Fan]

> Subject: Re: linux-next: Fixes tag needs some work in the imx-mxs tree
> 
> On Tue, Jun 11, 2019 at 08:36:52AM +0000, Peng Fan wrote:
> > Hi Shawn, Stephen
> > > Subject: Re: linux-next: Fixes tag needs some work in the imx-mxs
> > > tree
> > >
> > > On Fri, Jun 07, 2019 at 07:46:52AM +1000, Stephen Rothwell wrote:
> > > > Hi all,
> > > >
> > > > In commit
> > > >
> > > >   f6a8ff82ce68 ("clk: imx: imx8mm: correct audio_pll2_clk to
> > > > audio_pll2_out")
> > > >
> > > > Fixes tag
> > > >
> > > >   Fixes: ba5625c3e27 ("clk: imx: Add clock driver support for
> > > > imx8mm")
> > > >
> > > > has these problem(s):
> > > >
> > > >   - SHA1 should be at least 12 digits long
> > > >     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> > > >     or later) just making sure it is not set (or set to "auto").
> > >
> > > Hi Stephen,
> > >
> > > Thanks for reporting.  I just got it fixed, will be more careful
> > > about that in the future.
> > >
> > > @Peng, please check your git configuration as suggested above, thanks.
> >
> > Sorry for this. Do I need to resend the patch?
> 
> No.  I have fixed it on my branch.

Thanks. I'll take care in future.

Thanks,
Peng.

> 
> Shawn

linux-next: Fixes tag needs some work in the imx-mxs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

Hi Shawn,

Commit

  fde7ed930ca2 ("arm64: dts: imx8qxp: Fix MU4_INT number")

has a malformed Fixes tag.

The SHA1 should be at least 12 digits long.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the imx-mxs tree

[Shawn Guo]

On Thu, Jan 17, 2019 at 07:54:59AM +1100, Stephen Rothwell wrote:
> Hi Shawn,
> 
> Commit
> 
>   fde7ed930ca2 ("arm64: dts: imx8qxp: Fix MU4_INT number")
> 
> has a malformed Fixes tag.
> 
> The SHA1 should be at least 12 digits long.

Fixed.  Thanks for spotting it, Stephen.

Shawn