* [PATCH 1/1] ACPI: scan: Fix an error print in DisCo for Imaging support
@ 2023-11-21 7:08 Sakari Ailus
2023-11-21 14:13 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Sakari Ailus @ 2023-11-21 7:08 UTC (permalink / raw)
To: linux-acpi
Cc: Stephen Rothwell, Rafael J. Wysocki, Linux Kernel Mailing List,
Linux Next Mailing List
The recently merged DisCo for Imaging support used a wrong printk
specifier in printing a message. Fix it by using %zu instead of %lu.
Also use "bits" instead of "bytes" as these are indeed bytes.
Fixes: a6cb0a611273 ("ACPI: scan: Extract MIPI DisCo for Imaging data into swnodes")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/acpi/mipi-disco-img.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/mipi-disco-img.c b/drivers/acpi/mipi-disco-img.c
index cad72d1fc127..7286cf4579bc 100644
--- a/drivers/acpi/mipi-disco-img.c
+++ b/drivers/acpi/mipi-disco-img.c
@@ -533,7 +533,7 @@ static void init_csi2_port(struct acpi_device *adev,
if (ret < 0) {
acpi_handle_debug(handle, "Lane polarity bytes missing\n");
} else if (ret * BITS_PER_TYPE(u8) < num_lanes + 1) {
- acpi_handle_info(handle, "Too few lane polarity bytes (%lu vs. %d)\n",
+ acpi_handle_info(handle, "Too few lane polarity bits (%zu vs. %d)\n",
ret * BITS_PER_TYPE(u8), num_lanes + 1);
} else {
unsigned long mask = 0;
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] ACPI: scan: Fix an error print in DisCo for Imaging support
2023-11-21 7:08 [PATCH 1/1] ACPI: scan: Fix an error print in DisCo for Imaging support Sakari Ailus
@ 2023-11-21 14:13 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2023-11-21 14:13 UTC (permalink / raw)
To: Sakari Ailus
Cc: linux-acpi, Stephen Rothwell, Rafael J. Wysocki,
Linux Kernel Mailing List, Linux Next Mailing List
On Tue, Nov 21, 2023 at 9:33 AM Sakari Ailus
<sakari.ailus@linux.intel.com> wrote:
>
> The recently merged DisCo for Imaging support used a wrong printk
> specifier in printing a message. Fix it by using %zu instead of %lu.
> Also use "bits" instead of "bytes" as these are indeed bytes.
>
> Fixes: a6cb0a611273 ("ACPI: scan: Extract MIPI DisCo for Imaging data into swnodes")
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> drivers/acpi/mipi-disco-img.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/mipi-disco-img.c b/drivers/acpi/mipi-disco-img.c
> index cad72d1fc127..7286cf4579bc 100644
> --- a/drivers/acpi/mipi-disco-img.c
> +++ b/drivers/acpi/mipi-disco-img.c
> @@ -533,7 +533,7 @@ static void init_csi2_port(struct acpi_device *adev,
> if (ret < 0) {
> acpi_handle_debug(handle, "Lane polarity bytes missing\n");
> } else if (ret * BITS_PER_TYPE(u8) < num_lanes + 1) {
> - acpi_handle_info(handle, "Too few lane polarity bytes (%lu vs. %d)\n",
> + acpi_handle_info(handle, "Too few lane polarity bits (%zu vs. %d)\n",
> ret * BITS_PER_TYPE(u8), num_lanes + 1);
> } else {
> unsigned long mask = 0;
> --
Applied (with a slightly adjusted subject), thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-21 14:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-21 7:08 [PATCH 1/1] ACPI: scan: Fix an error print in DisCo for Imaging support Sakari Ailus
2023-11-21 14:13 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).