* [PATCH] virtiofs: drop __exit from virtio_fs_sysfs_exit()
@ 2024-02-27 15:57 Stefan Hajnoczi
2024-02-27 22:31 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Hajnoczi @ 2024-02-27 15:57 UTC (permalink / raw)
To: Miklos Szeredi
Cc: Randy Dunlap, Linux FS-devel Mailing List,
Linux Kernel Mailing List, Stephen Rothwell,
Linux Next Mailing List, Stefan Hajnoczi, kernel test robot
virtio_fs_sysfs_exit() is called by:
- static int __init virtio_fs_init(void)
- static void __exit virtio_fs_exit(void)
Remove __exit from virtio_fs_sysfs_exit() since virtio_fs_init() is not
an __exit function.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202402270649.GYjNX0yw-lkp@intel.com/
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
fs/fuse/virtio_fs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
index 62a44603740c..948b49c2460d 100644
--- a/fs/fuse/virtio_fs.c
+++ b/fs/fuse/virtio_fs.c
@@ -1588,7 +1588,7 @@ static int __init virtio_fs_sysfs_init(void)
return 0;
}
-static void __exit virtio_fs_sysfs_exit(void)
+static void virtio_fs_sysfs_exit(void)
{
kset_unregister(virtio_fs_kset);
virtio_fs_kset = NULL;
--
2.43.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] virtiofs: drop __exit from virtio_fs_sysfs_exit()
2024-02-27 15:57 [PATCH] virtiofs: drop __exit from virtio_fs_sysfs_exit() Stefan Hajnoczi
@ 2024-02-27 22:31 ` Randy Dunlap
2024-02-28 7:37 ` Miklos Szeredi
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2024-02-27 22:31 UTC (permalink / raw)
To: Stefan Hajnoczi, Miklos Szeredi
Cc: Linux FS-devel Mailing List, Linux Kernel Mailing List,
Stephen Rothwell, Linux Next Mailing List, kernel test robot
On 2/27/24 07:57, Stefan Hajnoczi wrote:
> virtio_fs_sysfs_exit() is called by:
> - static int __init virtio_fs_init(void)
> - static void __exit virtio_fs_exit(void)
>
> Remove __exit from virtio_fs_sysfs_exit() since virtio_fs_init() is not
> an __exit function.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202402270649.GYjNX0yw-lkp@intel.com/
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> fs/fuse/virtio_fs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
> index 62a44603740c..948b49c2460d 100644
> --- a/fs/fuse/virtio_fs.c
> +++ b/fs/fuse/virtio_fs.c
> @@ -1588,7 +1588,7 @@ static int __init virtio_fs_sysfs_init(void)
> return 0;
> }
>
> -static void __exit virtio_fs_sysfs_exit(void)
> +static void virtio_fs_sysfs_exit(void)
> {
> kset_unregister(virtio_fs_kset);
> virtio_fs_kset = NULL;
--
#Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] virtiofs: drop __exit from virtio_fs_sysfs_exit()
2024-02-27 22:31 ` Randy Dunlap
@ 2024-02-28 7:37 ` Miklos Szeredi
0 siblings, 0 replies; 3+ messages in thread
From: Miklos Szeredi @ 2024-02-28 7:37 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stefan Hajnoczi, Linux FS-devel Mailing List,
Linux Kernel Mailing List, Stephen Rothwell,
Linux Next Mailing List, kernel test robot
On Tue, 27 Feb 2024 at 23:31, Randy Dunlap <rdunlap@infradead.org> wrote:
>
>
>
> On 2/27/24 07:57, Stefan Hajnoczi wrote:
> > virtio_fs_sysfs_exit() is called by:
> > - static int __init virtio_fs_init(void)
> > - static void __exit virtio_fs_exit(void)
> >
> > Remove __exit from virtio_fs_sysfs_exit() since virtio_fs_init() is not
> > an __exit function.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202402270649.GYjNX0yw-lkp@intel.com/
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>
>
> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
> Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Applied, thanks.
Miklos
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-28 7:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-27 15:57 [PATCH] virtiofs: drop __exit from virtio_fs_sysfs_exit() Stefan Hajnoczi
2024-02-27 22:31 ` Randy Dunlap
2024-02-28 7:37 ` Miklos Szeredi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).