Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	David Miller <davem@davemloft.net>,
	Networking <netdev@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrii Nakryiko <andriin@fb.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Alexei Starovoitov <ast@fb.com>
Subject: Re: linux-next: build failure after merge of the net-next tree
Date: Fri, 6 Sep 2019 11:52:47 +0900
Message-ID: <CAK7LNATkk3VfzgynBEyOinKo3yBEDgNHLgO3bftLAPbDVVWx=A@mail.gmail.com> (raw)
In-Reply-To: <CAEf4BzZLBV3o=t9+a4o4T7KZ_M04vddD0RMVs3s4JvDsvQ8onA@mail.gmail.com>

On Fri, Sep 6, 2019 at 4:26 AM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> On Tue, Sep 3, 2019 at 11:20 PM Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
> >
> > On Wed, Sep 4, 2019 at 3:00 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > Hi all,
> > >
> > > After merging the net-next tree, today's linux-next build (arm
> > > multi_v7_defconfig) failed like this:
> > >
> > > scripts/link-vmlinux.sh: 74: Bad substitution
> > >
> > > Caused by commit
> > >
> > >   341dfcf8d78e ("btf: expose BTF info through sysfs")
> > >
> > > interacting with commit
> > >
> > >   1267f9d3047d ("kbuild: add $(BASH) to run scripts with bash-extension")
> > >
> > > from the kbuild tree.
> >
> >
> > I knew that they were using bash-extension
> > in the #!/bin/sh script.  :-D
> >
> > In fact, I wrote my patch in order to break their code
> > and  make btf people realize that they were doing wrong.
>
> Was there a specific reason to wait until this would break during
> Stephen's merge, instead of giving me a heads up (or just replying on
> original patch) and letting me fix it and save everyone's time and
> efforts?
>
> Either way, I've fixed the issue in
> https://patchwork.ozlabs.org/patch/1158620/ and will pay way more
> attention to BASH-specific features going forward (I found it pretty
> hard to verify stuff like this, unfortunately). But again, code review
> process is the best place to catch this and I really hope in the
> future we can keep this process productive. Thanks!

I could have pointed it out if I had noticed
it in the review process.

I actually noticed your patch by Stephen's
former email.  (i.e. when it appeared in linux-next)

(I try my best to check kbuild ML, and also search for
my name in LKML in case I am explicitly addressed,
but a large number of emails fall off my filter)

It was somewhat too late when I noticed it.
Of course, I still could email you afterward, or even send a patch to btf ML,
but I did not fix a particular instance of breakage
because there are already the same type of breakages in code base.

Then, I applied the all-or-nothing checker because I thought it was
the only way to address the root cause of the problems.

I admit I could have done the process better.
Sorry if I made people uncomfortable and waste time.

Thanks.




> >
> >
> >
> > > The change in the net-next tree turned link-vmlinux.sh into a bash script
> > > (I think).
> > >
> > > I have applied the following patch for today:
> >
> >
> > But, this is a temporary fix only for linux-next.
> >
> > scripts/link-vmlinux.sh does not need to use the
> > bash-extension ${@:2} in the first place.
> >
> > I hope btf people will write the correct code.
>
> I replaced ${@:2} with shift and ${@}, I hope that's a correct fix,
> but if you think it's not, please reply on the patch and let me know.
>
>
> >
> > Thanks.
> >
> >
> >
> >
> > > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > > Date: Wed, 4 Sep 2019 15:43:41 +1000
> > > Subject: [PATCH] link-vmlinux.sh is now a bash script
> > >
> > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > ---
> > >  Makefile                | 4 ++--
> > >  scripts/link-vmlinux.sh | 2 +-
> > >  2 files changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/Makefile b/Makefile
> > > index ac97fb282d99..523d12c5cebe 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -1087,7 +1087,7 @@ ARCH_POSTLINK := $(wildcard $(srctree)/arch/$(SRCARCH)/Makefile.postlink)
> > >
> > >  # Final link of vmlinux with optional arch pass after final link
> > >  cmd_link-vmlinux =                                                 \
> > > -       $(CONFIG_SHELL) $< $(LD) $(KBUILD_LDFLAGS) $(LDFLAGS_vmlinux) ;    \
> > > +       $(BASH) $< $(LD) $(KBUILD_LDFLAGS) $(LDFLAGS_vmlinux) ;    \
> > >         $(if $(ARCH_POSTLINK), $(MAKE) -f $(ARCH_POSTLINK) $@, true)
> > >
> > >  vmlinux: scripts/link-vmlinux.sh autoksyms_recursive $(vmlinux-deps) FORCE
> > > @@ -1403,7 +1403,7 @@ clean: rm-files := $(CLEAN_FILES)
> > >  PHONY += archclean vmlinuxclean
> > >
> > >  vmlinuxclean:
> > > -       $(Q)$(CONFIG_SHELL) $(srctree)/scripts/link-vmlinux.sh clean
> > > +       $(Q)$(BASH) $(srctree)/scripts/link-vmlinux.sh clean
> > >         $(Q)$(if $(ARCH_POSTLINK), $(MAKE) -f $(ARCH_POSTLINK) clean)
> > >
> > >  clean: archclean vmlinuxclean
> > > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
> > > index f7edb75f9806..ea1f8673869d 100755
> > > --- a/scripts/link-vmlinux.sh
> > > +++ b/scripts/link-vmlinux.sh
> > > @@ -1,4 +1,4 @@
> > > -#!/bin/sh
> > > +#!/bin/bash
> > >  # SPDX-License-Identifier: GPL-2.0
> > >  #
> > >  # link vmlinux
> > > --
> > > 2.23.0.rc1
> > >
> > > --
> > > Cheers,
> > > Stephen Rothwell
> >
> >
> >
> > --
> > Best Regards
> > Masahiro Yamada



--
Best Regards
Masahiro Yamada

  reply index

Thread overview: 244+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-04  6:00 Stephen Rothwell
2019-09-04  6:18 ` Masahiro Yamada
2019-09-05 19:26   ` Andrii Nakryiko
2019-09-06  2:52     ` Masahiro Yamada [this message]
2019-09-06  9:02       ` Andrii Nakryiko
2019-09-04  8:18 ` Andrii Nakryiko
  -- strict thread matches above, loose matches on Subject: below --
2019-11-05  8:53 Stephen Rothwell
2019-11-05 13:50 ` Andrew Lunn
2019-11-05 14:22   ` Stephen Rothwell
2019-08-29 10:05 Stephen Rothwell
2019-08-30 21:35 ` David Miller
2019-07-25  9:37 Stephen Rothwell
2019-07-11 11:52 Jason Gunthorpe
2019-07-09  3:56 Stephen Rothwell
2019-07-09  6:43 ` Leon Romanovsky
2019-07-10  4:31   ` Stephen Rothwell
2019-07-10  5:20     ` Leon Romanovsky
2019-07-10 17:52   ` Jason Gunthorpe
2019-07-11  1:50     ` Stephen Rothwell
2019-07-11  2:26       ` Jason Gunthorpe
2019-07-11  3:13         ` Stephen Rothwell
2019-07-11  3:16           ` Stephen Rothwell
2019-07-11  3:27             ` Stephen Rothwell
2019-07-11  5:40             ` Leon Romanovsky
2019-07-11  8:00   ` Bernard Metzler
2019-07-11 12:29     ` Bernard Metzler
2019-07-11 14:33       ` Jason Gunthorpe
2019-07-12  1:45         ` Stephen Rothwell
2019-07-12 15:21           ` Jason Gunthorpe
2019-06-20  9:13 Stephen Rothwell
2019-06-24  3:12 ` Stephen Rothwell
2019-06-24  3:59   ` Palmer Dabbelt
2019-06-19  3:23 Stephen Rothwell
2019-06-19  4:02 ` Masahiro Yamada
2019-06-19  4:14   ` Masahiro Yamada
2019-06-19  8:50     ` Kevin 'ldir' Darbyshire-Bryant
2019-06-19 13:46     ` David Miller
2019-06-19 14:13 ` David Miller
2019-06-19 15:09   ` Kevin 'ldir' Darbyshire-Bryant
2019-06-19 16:11     ` Kevin 'ldir' Darbyshire-Bryant
2019-06-11  8:26 Stephen Rothwell
2019-05-31  0:35 Stephen Rothwell
2019-04-23  7:25 Stephen Rothwell
2019-04-24  1:36 ` David Miller
2019-02-04  4:34 Stephen Rothwell
2019-02-04  4:36 ` David Miller
2019-01-29  5:17 Stephen Rothwell
2019-01-29  6:43 ` David Miller
2018-12-20  2:28 Stephen Rothwell
2018-12-20 10:43 ` Petr Machata
2018-12-17  1:36 Stephen Rothwell
2018-12-17 15:54 ` Paolo Abeni
2018-10-19  0:18 Stephen Rothwell
2018-10-19  5:48 ` Or Gerlitz
2018-09-02 23:47 Stephen Rothwell
2018-09-07  0:20 ` Stephen Rothwell
2018-09-07 15:30   ` Keller, Jacob E
2018-09-07 17:31     ` David Miller
2018-09-07 22:03       ` Keller, Jacob E
2018-08-06  2:10 Stephen Rothwell
2018-08-06  4:43 ` Y.b. Lu
2018-08-03  2:14 Stephen Rothwell
2018-08-03  2:34 ` Jakub Kicinski
2018-08-03  2:44 ` David Miller
2018-07-27 10:32 Stephen Rothwell
2018-07-27 12:18 ` YueHaibing
2018-07-03  0:47 Stephen Rothwell
2018-07-03  7:34 ` Sabrina Dubroca
2018-05-29  3:42 Stephen Rothwell
2018-05-29  5:41 ` Christoph Hellwig
2018-05-29  3:25 Stephen Rothwell
2018-05-30 21:38 ` Stephen Rothwell
2018-06-01  3:59   ` Stephen Rothwell
2018-06-01  8:52     ` Alexei Starovoitov
2018-06-06  4:49       ` Stephen Rothwell
2018-02-28 23:30 Stephen Rothwell
2018-01-29  1:50 Stephen Rothwell
2018-01-29  2:09 ` David Miller
2018-01-11  0:53 Stephen Rothwell
2018-01-11  1:58 ` Alexei Starovoitov
2018-01-12  3:11   ` David Miller
2018-01-12  4:21     ` Alexei Starovoitov
2018-01-12 10:45       ` Daniel Borkmann
2018-01-12 15:56         ` Alexei Starovoitov
2018-01-12 16:21           ` Daniel Borkmann
2018-01-12 16:43             ` Alexei Starovoitov
2018-01-10  4:06 Stephen Rothwell
2018-01-10  5:53 ` Jason Wang
2018-01-10 20:53 ` David Miller
2017-12-22  0:45 Stephen Rothwell
2017-12-22  7:51 ` Ido Schimmel
2017-12-20 23:43 Stephen Rothwell
2017-12-20 23:59 ` Jakub Kicinski
2017-09-29  1:36 Stephen Rothwell
2017-09-29  2:07 ` Florian Fainelli
2017-09-22  1:03 Stephen Rothwell
2017-09-22  1:37 ` David Miller
2017-09-22  7:10   ` Paolo Abeni
2017-08-15  2:28 Stephen Rothwell
2017-07-18  1:09 Stephen Rothwell
2017-07-18  4:59 ` John Fastabend
2017-05-22  1:16 Stephen Rothwell
2017-05-22  3:14 ` David Miller
2017-05-22  3:43   ` Stephen Rothwell
2017-05-22 14:17     ` David Miller
2017-05-22  3:42 ` Willem de Bruijn
2017-01-09 23:59 Stephen Rothwell
2017-01-10 15:14 ` Ursula Braun
2017-02-22 23:34 ` Stephen Rothwell
2016-05-10  1:29 Stephen Rothwell
2016-05-10  1:32 ` David Miller
2016-05-10  1:29 Stephen Rothwell
2016-05-10  1:52 ` Andy Gross
2016-05-10 18:39 ` Bjorn Andersson
2016-05-13 21:01   ` Arnd Bergmann
2016-04-13  7:50 Stephen Rothwell
2016-04-13 15:15 ` David Miller
2016-04-17  9:47   ` Arnd Bergmann
2016-04-22  9:20   ` Mark Brown
2016-04-22 23:20     ` Jeff Kirsher
2016-04-24 22:59       ` Mark Brown
2016-02-18  1:28 Stephen Rothwell
2016-02-18 20:28 ` David Miller
2016-02-18 22:14   ` Yuval Mintz
2016-01-11  2:46 Stephen Rothwell
2016-01-11  3:02 ` David Miller
2015-10-06  5:34 Stephen Rothwell
2015-08-24  3:21 Stephen Rothwell
2015-08-24  3:33 ` David Miller
2015-08-24  4:20   ` Stephen Rothwell
2015-08-20  2:57 Stephen Rothwell
2015-08-20  5:16 ` David Miller
2015-08-18  8:39 Stephen Rothwell
2015-08-18 21:25 ` David Miller
2015-07-23  1:58 Stephen Rothwell
2015-06-24  7:37 Stephen Rothwell
2015-06-24  8:01 ` David Miller
2015-06-01  3:44 Stephen Rothwell
2015-06-01  4:35 ` David Miller
2015-03-30  4:05 Stephen Rothwell
2015-03-31 18:13 ` David Miller
2015-03-24  2:45 Stephen Rothwell
2015-03-24  3:00 ` David Miller
2015-03-24 10:43   ` Christoph Hellwig
2015-03-24 15:59     ` David Miller
2015-03-05  2:42 Stephen Rothwell
2015-03-05  5:01 ` David Miller
2015-03-05 23:26   ` Stephen Rothwell
2015-03-06  2:01     ` David Miller
2015-03-06  2:42       ` Stephen Rothwell
2015-02-10 11:02 Stephen Rothwell
2015-02-11  4:51 ` Jeff Kirsher
2015-02-09  3:07 Stephen Rothwell
2015-02-09  5:52 ` David Miller
2015-01-19  3:06 Stephen Rothwell
2015-01-19  3:13 ` Marcel Holtmann
2015-01-19  3:30   ` Stephen Rothwell
2015-01-12  3:05 Stephen Rothwell
2015-01-12  3:08 ` David Miller
2015-01-12  3:12   ` Stephen Rothwell
2015-01-02 22:11 Stephen Rothwell
2015-01-02 22:21 ` Sedat Dilek
2015-01-02 23:32   ` Stephen Rothwell
2015-01-03  3:01 ` Stephen Rothwell
2015-01-03 19:45 ` David Miller
2015-01-05  3:36   ` Stephen Rothwell
2014-12-10  8:54 Stephen Rothwell
2014-12-10 10:14 ` Hariprasad S
2014-12-10 20:52 ` David Miller
2014-11-17  2:34 Stephen Rothwell
2014-11-22  3:30 ` David Miller
2014-10-01  7:04 Stephen Rothwell
2014-10-01  7:29 ` Jeff Kirsher
2014-10-01 17:42 ` David Miller
2014-09-30  3:13 Stephen Rothwell
2014-09-30  3:22 ` Stephen Rothwell
2014-07-18  4:35 Anish Bhatt
2014-07-18  3:21 Stephen Rothwell
2014-07-09  3:26 Stephen Rothwell
2014-07-09  3:47 ` David Miller
2014-07-09  3:53   ` Stephen Rothwell
2014-06-30  2:47 Stephen Rothwell
2014-06-30  6:47 ` David Miller
2014-06-12  2:14 Stephen Rothwell
2014-06-06  6:45 Stephen Rothwell
2014-06-06 13:21 ` Tom Lendacky
2014-06-06  4:06 Stephen Rothwell
2014-06-06  4:12 ` Alexei Starovoitov
2014-06-02  8:36 Stephen Rothwell
2014-05-19  3:38 Stephen Rothwell
2014-01-06  4:54 Stephen Rothwell
2014-01-06  5:10 ` Hannes Frederic Sowa
2013-12-19  0:57 Stephen Rothwell
2013-12-19 19:09 ` David Miller
2013-12-18  1:56 Stephen Rothwell
2013-12-18  2:21 ` David Miller
2013-12-18  2:30   ` David Miller
2013-12-18  8:33     ` Geert Uytterhoeven
2013-12-18 10:15       ` Peter Zijlstra
2013-12-18 10:32         ` Geert Uytterhoeven
2013-12-18 11:07           ` David Laight
2013-12-18 11:33             ` Peter Zijlstra
2013-12-18 11:36               ` Peter Zijlstra
2013-12-18 17:06         ` David Miller
2013-12-18 15:10     ` Francesco Fusco
2013-07-30  2:16 Stephen Rothwell
     [not found] ` <CAFkjPTny4TUFu9xrF-90DrJwXsfzBOpb_yYOwe_0r9ohsc2vcQ@mail.gmail.com>
2013-07-30 22:54   ` David Miller
2013-04-26  3:48 Stephen Rothwell
2013-04-30  8:03 ` David Miller
2013-04-22  3:27 Stephen Rothwell
2013-04-19  3:21 Stephen Rothwell
     [not found] ` <20130419132127.05ea53adec329ca794d62be7-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2013-04-19  7:34   ` Antonio Quartulli
2013-04-19  8:13     ` Stephen Rothwell
2013-04-23  0:39 ` David Miller
2013-02-19  1:17 Stephen Rothwell
2013-02-19  1:30 ` David Miller
2013-01-11  2:18 Stephen Rothwell
2012-09-28  1:43 Stephen Rothwell
2012-09-28  2:19 ` David Miller
2012-10-01 11:53   ` Ivan Vecera
2012-07-20  2:01 Stephen Rothwell
2012-07-20  2:48 ` Stephen Rothwell
2012-07-20  3:21 ` Christian Riesch
2012-07-10  3:08 Stephen Rothwell
2012-07-10  7:25 ` Bjørn Mork
2012-07-11  6:36 ` David Miller
2012-06-20  3:33 Stephen Rothwell
2012-06-20  4:24 ` David Miller
2012-06-20  4:27 ` Bhupesh SHARMA
2012-06-20  4:37   ` David Miller
2012-06-20  4:45     ` Bhupesh SHARMA
2012-06-20  4:47       ` David Miller
2012-06-20 11:35         ` Mark Brown
2012-06-20  8:31       ` Marc Kleine-Budde
2012-06-20  8:41         ` David Miller
2012-06-20  9:03         ` Federico Vaga
2012-06-20  9:06           ` David Miller
2012-06-20  9:59             ` Federico Vaga
2012-06-20  9:58               ` David Miller
2012-06-20 10:17                 ` Federico Vaga
2012-06-20  8:08   ` viresh kumar
2012-06-20  8:20     ` David Miller
2012-06-20  8:45       ` viresh kumar
2012-06-20 10:26       ` Stephen Rothwell
2012-06-20 10:33         ` Marc Kleine-Budde
     [not found] <20120423121451.c88c9bfaaf4d79313f7219f3@canb.auug.org.au>
2012-04-23  4:25 ` David Miller
2011-10-25 13:55 Stephen Rothwell
2011-10-25 14:16 ` Eric Dumazet

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK7LNATkk3VfzgynBEyOinKo3yBEDgNHLgO3bftLAPbDVVWx=A@mail.gmail.com' \
    --to=yamada.masahiro@socionext.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@fb.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git