* linux-next: build warning after merge of the arm64 tree
@ 2018-07-23 23:05 Stephen Rothwell
2018-07-24 0:26 ` AKASHI Takahiro
0 siblings, 1 reply; 14+ messages in thread
From: Stephen Rothwell @ 2018-07-23 23:05 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon
Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
AKASHI Takahiro, Ard Biesheuvel
[-- Attachment #1: Type: text/plain, Size: 531 bytes --]
Hi all,
After merging the arm64 tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/acpi/Kconfig:6:error: recursive dependency detected!
drivers/acpi/Kconfig:6: symbol ACPI depends on EFI
arch/x86/Kconfig:1920: symbol EFI depends on ACPI
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
Introduced by commit
5bcd44083a08 ("drivers: acpi: add dependency of EFI for arm64")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: linux-next: build warning after merge of the arm64 tree
2018-07-23 23:05 linux-next: build warning after merge of the arm64 tree Stephen Rothwell
@ 2018-07-24 0:26 ` AKASHI Takahiro
2018-07-24 8:12 ` Arnd Bergmann
0 siblings, 1 reply; 14+ messages in thread
From: AKASHI Takahiro @ 2018-07-24 0:26 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Catalin Marinas, Will Deacon, Linux-Next Mailing List,
Linux Kernel Mailing List, Ard Biesheuvel
On Tue, Jul 24, 2018 at 09:05:45AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the arm64 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
Where can I find this specific branch?
> drivers/acpi/Kconfig:6:error: recursive dependency detected!
> drivers/acpi/Kconfig:6: symbol ACPI depends on EFI
My patch created an additional dependency like:
menu ACPI
...
depends on IA64 || X86 || (ARM64 && EFI)
> arch/x86/Kconfig:1920: symbol EFI depends on ACPI
So I don't understand why this change makes a warning on x86_64 build.
Is this a real recursive dependency?
Thanks,
-Takahiro AKASHI
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
> subsection "Kconfig recursive dependency limitations"
>
> Introduced by commit
>
> 5bcd44083a08 ("drivers: acpi: add dependency of EFI for arm64")
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: linux-next: build warning after merge of the arm64 tree
2018-07-24 0:26 ` AKASHI Takahiro
@ 2018-07-24 8:12 ` Arnd Bergmann
2018-07-24 9:30 ` Ard Biesheuvel
0 siblings, 1 reply; 14+ messages in thread
From: Arnd Bergmann @ 2018-07-24 8:12 UTC (permalink / raw)
To: AKASHI Takahiro, Stephen Rothwell, Catalin Marinas, Will Deacon,
Linux-Next Mailing List, Linux Kernel Mailing List,
Ard Biesheuvel
On Tue, Jul 24, 2018 at 2:26 AM, AKASHI Takahiro
<takahiro.akashi@linaro.org> wrote:
> On Tue, Jul 24, 2018 at 09:05:45AM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the arm64 tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>
> Where can I find this specific branch?
>
>> drivers/acpi/Kconfig:6:error: recursive dependency detected!
>> drivers/acpi/Kconfig:6: symbol ACPI depends on EFI
>
> My patch created an additional dependency like:
> menu ACPI
> ...
> depends on IA64 || X86 || (ARM64 && EFI)
>
>> arch/x86/Kconfig:1920: symbol EFI depends on ACPI
>
> So I don't understand why this change makes a warning on x86_64 build.
> Is this a real recursive dependency?
On x86, we have
config EFI
bool "EFI runtime service support"
depends on ACPI
Kconfig cannot know that CONFIG_ARM64 is never set on x86, while
X86 is always set. So to Kconfig it it appears like a recursive
dependency.
The best workaround I can see is to have an intermediate symbol
on ARM64 that is invisible to Kconfig on x86, like
config ARCH_SUPPORTS_ACPI
def_bool EFI
and then have ACPI depend on that.
Arnd
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: linux-next: build warning after merge of the arm64 tree
2018-07-24 8:12 ` Arnd Bergmann
@ 2018-07-24 9:30 ` Ard Biesheuvel
0 siblings, 0 replies; 14+ messages in thread
From: Ard Biesheuvel @ 2018-07-24 9:30 UTC (permalink / raw)
To: Arnd Bergmann
Cc: AKASHI Takahiro, Stephen Rothwell, Catalin Marinas, Will Deacon,
Linux-Next Mailing List, Linux Kernel Mailing List
On 24 July 2018 at 10:12, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tue, Jul 24, 2018 at 2:26 AM, AKASHI Takahiro
> <takahiro.akashi@linaro.org> wrote:
>> On Tue, Jul 24, 2018 at 09:05:45AM +1000, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> After merging the arm64 tree, today's linux-next build (x86_64
>>> allmodconfig) produced this warning:
>>
>> Where can I find this specific branch?
>>
>>> drivers/acpi/Kconfig:6:error: recursive dependency detected!
>>> drivers/acpi/Kconfig:6: symbol ACPI depends on EFI
>>
>> My patch created an additional dependency like:
>> menu ACPI
>> ...
>> depends on IA64 || X86 || (ARM64 && EFI)
>>
>>> arch/x86/Kconfig:1920: symbol EFI depends on ACPI
>>
>> So I don't understand why this change makes a warning on x86_64 build.
>> Is this a real recursive dependency?
>
> On x86, we have
>
> config EFI
> bool "EFI runtime service support"
> depends on ACPI
>
> Kconfig cannot know that CONFIG_ARM64 is never set on x86, while
> X86 is always set. So to Kconfig it it appears like a recursive
> dependency.
>
> The best workaround I can see is to have an intermediate symbol
> on ARM64 that is invisible to Kconfig on x86, like
>
> config ARCH_SUPPORTS_ACPI
> def_bool EFI
>
> and then have ACPI depend on that.
>
I suppose you mean
depends on IA64 || X86 || ARCH_SUPPORTS_ACPI
right?
Instead, perhaps we could have
config ARCH_SUPPORTS_ACPI
def_bool IA64 || X86
and make CONFIG_ACPI depend on that. Then, we can set it conditionally
in arch/arm64/Kconfig if CONFIG_EFI is enabled.
^ permalink raw reply [flat|nested] 14+ messages in thread
* linux-next: build warning after merge of the arm64 tree
@ 2022-03-09 11:34 Stephen Rothwell
2022-03-09 12:18 ` Will Deacon
0 siblings, 1 reply; 14+ messages in thread
From: Stephen Rothwell @ 2022-03-09 11:34 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon
Cc: Huang Shijie, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 432 bytes --]
Hi all,
After merging the arm64 tree, today's linux-next build (htmldocs)
produced this warning:
Documentation/admin-guide/kdump/vmcoreinfo.rst:498: WARNING: Title underline too short.
MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END
-------------
Introduced by commit
2369f171d5c5 ("arm64: crash_core: Export MODULES, VMALLOC, and VMEMMAP ranges")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: linux-next: build warning after merge of the arm64 tree
2022-03-09 11:34 Stephen Rothwell
@ 2022-03-09 12:18 ` Will Deacon
0 siblings, 0 replies; 14+ messages in thread
From: Will Deacon @ 2022-03-09 12:18 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Catalin Marinas, Huang Shijie, Linux Kernel Mailing List,
Linux Next Mailing List
On Wed, Mar 09, 2022 at 10:34:11PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the arm64 tree, today's linux-next build (htmldocs)
> produced this warning:
>
> Documentation/admin-guide/kdump/vmcoreinfo.rst:498: WARNING: Title underline too short.
>
> MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END
> -------------
>
> Introduced by commit
>
> 2369f171d5c5 ("arm64: crash_core: Export MODULES, VMALLOC, and VMEMMAP ranges")
Cheers, I'll fix this.
Will
^ permalink raw reply [flat|nested] 14+ messages in thread
* linux-next: build warning after merge of the arm64 tree
@ 2022-07-07 9:57 Stephen Rothwell
2022-07-07 10:28 ` Will Deacon
0 siblings, 1 reply; 14+ messages in thread
From: Stephen Rothwell @ 2022-07-07 9:57 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon
Cc: Guangbin Huang, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 334 bytes --]
Hi all,
After merging the arm64 tree, today's linux-next build (htmldocs)
produced this warning:
Documentation/admin-guide/perf/hns3-pmu.rst: WARNING: document isn't included in any toctree
Introduced by commit
39915b6b5fc2 ("drivers/perf: hisi: Add description for HNS3 PMU driver")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: linux-next: build warning after merge of the arm64 tree
2022-07-07 9:57 Stephen Rothwell
@ 2022-07-07 10:28 ` Will Deacon
0 siblings, 0 replies; 14+ messages in thread
From: Will Deacon @ 2022-07-07 10:28 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Catalin Marinas, Guangbin Huang, Linux Kernel Mailing List,
Linux Next Mailing List
On Thu, Jul 07, 2022 at 07:57:07PM +1000, Stephen Rothwell wrote:
> After merging the arm64 tree, today's linux-next build (htmldocs)
> produced this warning:
>
> Documentation/admin-guide/perf/hns3-pmu.rst: WARNING: document isn't included in any toctree
>
> Introduced by commit
>
> 39915b6b5fc2 ("drivers/perf: hisi: Add description for HNS3 PMU driver")
Thanks, I've fixed this locally and will update the branch later today.
Will
^ permalink raw reply [flat|nested] 14+ messages in thread
* linux-next: build warning after merge of the arm64 tree
@ 2023-06-13 6:23 Stephen Rothwell
2023-06-13 15:59 ` Catalin Marinas
0 siblings, 1 reply; 14+ messages in thread
From: Stephen Rothwell @ 2023-06-13 6:23 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon
Cc: Baoquan He, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 337 bytes --]
Hi all,
After merging the arm64 tree, today's linux-next build (htmldocs)
produced this warning:
Documentation/arm64/kdump.rst: WARNING: document isn't included in any toctree
Introduced by commit
03dc0e05407f ("Documentation: add kdump.rst to present crashkernel reservation on arm64")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: linux-next: build warning after merge of the arm64 tree
2023-06-13 6:23 Stephen Rothwell
@ 2023-06-13 15:59 ` Catalin Marinas
0 siblings, 0 replies; 14+ messages in thread
From: Catalin Marinas @ 2023-06-13 15:59 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Will Deacon, Baoquan He, Linux Kernel Mailing List,
Linux Next Mailing List
On Tue, Jun 13, 2023 at 04:23:44PM +1000, Stephen Rothwell wrote:
> After merging the arm64 tree, today's linux-next build (htmldocs)
> produced this warning:
>
> Documentation/arm64/kdump.rst: WARNING: document isn't included in any toctree
>
> Introduced by commit
>
> 03dc0e05407f ("Documentation: add kdump.rst to present crashkernel reservation on arm64")
Thanks. I have a patch already from Baoquan, I'll push it later today.
--
Catalin
^ permalink raw reply [flat|nested] 14+ messages in thread
* linux-next: build warning after merge of the arm64 tree
@ 2023-10-24 6:24 Stephen Rothwell
2023-10-24 9:55 ` Catalin Marinas
0 siblings, 1 reply; 14+ messages in thread
From: Stephen Rothwell @ 2023-10-24 6:24 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon
Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 308 bytes --]
Hi all,
After merging the arm64 tree, today's linux-next build (arm64 defconfig)
produced this warning:
WARNING: modpost: vmlinux: section mismatch in reference: __pi_$x+0x38 (section: .text) -> __pi_map_range (section: .init.text)
I don't know what caused this.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: linux-next: build warning after merge of the arm64 tree
2023-10-24 6:24 Stephen Rothwell
@ 2023-10-24 9:55 ` Catalin Marinas
2023-10-24 13:42 ` Ard Biesheuvel
0 siblings, 1 reply; 14+ messages in thread
From: Catalin Marinas @ 2023-10-24 9:55 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Will Deacon, Linux Kernel Mailing List, Linux Next Mailing List,
Ard Biesheuvel
+ Ard
On Tue, Oct 24, 2023 at 05:24:09PM +1100, Stephen Rothwell wrote:
> After merging the arm64 tree, today's linux-next build (arm64 defconfig)
> produced this warning:
>
> WARNING: modpost: vmlinux: section mismatch in reference: __pi_$x+0x38 (section: .text) -> __pi_map_range (section: .init.text)
>
> I don't know what caused this.
For some reason, building linux-next doesn't inline all the functions in
the map_range.c file and we end up with some of them in different
sections. I didn't get this when building the arm64 for-next/core
separately.
My fix (I'll push it to the arm64 branch):
diff --git a/arch/arm64/kernel/pi/map_kernel.c b/arch/arm64/kernel/pi/map_kernel.c
index be7caf07bfa7..e07f3ece5430 100644
--- a/arch/arm64/kernel/pi/map_kernel.c
+++ b/arch/arm64/kernel/pi/map_kernel.c
@@ -20,17 +20,17 @@ extern const u8 __eh_frame_start[], __eh_frame_end[];
extern void idmap_cpu_replace_ttbr1(void *pgdir);
-static void map_segment(pgd_t *pg_dir, u64 *pgd, u64 va_offset,
- void *start, void *end, pgprot_t prot,
- bool may_use_cont, int root_level)
+static void __init map_segment(pgd_t *pg_dir, u64 *pgd, u64 va_offset,
+ void *start, void *end, pgprot_t prot,
+ bool may_use_cont, int root_level)
{
map_range(pgd, ((u64)start + va_offset) & ~PAGE_OFFSET,
((u64)end + va_offset) & ~PAGE_OFFSET, (u64)start,
prot, root_level, (pte_t *)pg_dir, may_use_cont, 0);
}
-static void unmap_segment(pgd_t *pg_dir, u64 va_offset, void *start,
- void *end, int root_level)
+static void __init unmap_segment(pgd_t *pg_dir, u64 va_offset, void *start,
+ void *end, int root_level)
{
map_segment(pg_dir, NULL, va_offset, start, end, __pgprot(0),
false, root_level);
@@ -205,7 +205,7 @@ static void __init remap_idmap_for_lpa2(void)
memset(init_pg_dir, 0, (u64)init_pg_end - (u64)init_pg_dir);
}
-static void map_fdt(u64 fdt)
+static void __init map_fdt(u64 fdt)
{
static u8 ptes[INIT_IDMAP_FDT_SIZE] __initdata __aligned(PAGE_SIZE);
u64 efdt = fdt + MAX_FDT_SIZE;
--
Catalin
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: linux-next: build warning after merge of the arm64 tree
2023-10-24 9:55 ` Catalin Marinas
@ 2023-10-24 13:42 ` Ard Biesheuvel
2023-10-24 16:14 ` Catalin Marinas
0 siblings, 1 reply; 14+ messages in thread
From: Ard Biesheuvel @ 2023-10-24 13:42 UTC (permalink / raw)
To: Catalin Marinas
Cc: Stephen Rothwell, Will Deacon, Linux Kernel Mailing List,
Linux Next Mailing List
On Tue, 24 Oct 2023 at 11:55, Catalin Marinas <catalin.marinas@arm.com> wrote:
>
> + Ard
>
> On Tue, Oct 24, 2023 at 05:24:09PM +1100, Stephen Rothwell wrote:
> > After merging the arm64 tree, today's linux-next build (arm64 defconfig)
> > produced this warning:
> >
> > WARNING: modpost: vmlinux: section mismatch in reference: __pi_$x+0x38 (section: .text) -> __pi_map_range (section: .init.text)
> >
> > I don't know what caused this.
>
> For some reason, building linux-next doesn't inline all the functions in
> the map_range.c file and we end up with some of them in different
> sections. I didn't get this when building the arm64 for-next/core
> separately.
>
Strange, I never ran into this before.
I guess commit 24cc769d70d8bda055a028aa6a is implicated in this, if we
run into more trouble like this i'll look whether we can bring that
logic back in some way.
The fix looks fine to me.
> My fix (I'll push it to the arm64 branch):
>
> diff --git a/arch/arm64/kernel/pi/map_kernel.c b/arch/arm64/kernel/pi/map_kernel.c
> index be7caf07bfa7..e07f3ece5430 100644
> --- a/arch/arm64/kernel/pi/map_kernel.c
> +++ b/arch/arm64/kernel/pi/map_kernel.c
> @@ -20,17 +20,17 @@ extern const u8 __eh_frame_start[], __eh_frame_end[];
>
> extern void idmap_cpu_replace_ttbr1(void *pgdir);
>
> -static void map_segment(pgd_t *pg_dir, u64 *pgd, u64 va_offset,
> - void *start, void *end, pgprot_t prot,
> - bool may_use_cont, int root_level)
> +static void __init map_segment(pgd_t *pg_dir, u64 *pgd, u64 va_offset,
> + void *start, void *end, pgprot_t prot,
> + bool may_use_cont, int root_level)
> {
> map_range(pgd, ((u64)start + va_offset) & ~PAGE_OFFSET,
> ((u64)end + va_offset) & ~PAGE_OFFSET, (u64)start,
> prot, root_level, (pte_t *)pg_dir, may_use_cont, 0);
> }
>
> -static void unmap_segment(pgd_t *pg_dir, u64 va_offset, void *start,
> - void *end, int root_level)
> +static void __init unmap_segment(pgd_t *pg_dir, u64 va_offset, void *start,
> + void *end, int root_level)
> {
> map_segment(pg_dir, NULL, va_offset, start, end, __pgprot(0),
> false, root_level);
> @@ -205,7 +205,7 @@ static void __init remap_idmap_for_lpa2(void)
> memset(init_pg_dir, 0, (u64)init_pg_end - (u64)init_pg_dir);
> }
>
> -static void map_fdt(u64 fdt)
> +static void __init map_fdt(u64 fdt)
> {
> static u8 ptes[INIT_IDMAP_FDT_SIZE] __initdata __aligned(PAGE_SIZE);
> u64 efdt = fdt + MAX_FDT_SIZE;
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: linux-next: build warning after merge of the arm64 tree
2023-10-24 13:42 ` Ard Biesheuvel
@ 2023-10-24 16:14 ` Catalin Marinas
0 siblings, 0 replies; 14+ messages in thread
From: Catalin Marinas @ 2023-10-24 16:14 UTC (permalink / raw)
To: Ard Biesheuvel
Cc: Stephen Rothwell, Will Deacon, Linux Kernel Mailing List,
Linux Next Mailing List
On Tue, Oct 24, 2023 at 03:42:20PM +0200, Ard Biesheuvel wrote:
> On Tue, 24 Oct 2023 at 11:55, Catalin Marinas <catalin.marinas@arm.com> wrote:
> >
> > + Ard
> >
> > On Tue, Oct 24, 2023 at 05:24:09PM +1100, Stephen Rothwell wrote:
> > > After merging the arm64 tree, today's linux-next build (arm64 defconfig)
> > > produced this warning:
> > >
> > > WARNING: modpost: vmlinux: section mismatch in reference: __pi_$x+0x38 (section: .text) -> __pi_map_range (section: .init.text)
> > >
> > > I don't know what caused this.
> >
> > For some reason, building linux-next doesn't inline all the functions in
> > the map_range.c file and we end up with some of them in different
> > sections. I didn't get this when building the arm64 for-next/core
> > separately.
> >
>
> Strange, I never ran into this before.
>
> I guess commit 24cc769d70d8bda055a028aa6a is implicated in this, if we
> run into more trouble like this i'll look whether we can bring that
> logic back in some way.
>
> The fix looks fine to me.
Thanks. I applied this fix locally (will push it out in a bit). I added
a fixes tag for a latter commit introducing map_segment() etc.
--
Catalin
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2023-10-24 16:14 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-23 23:05 linux-next: build warning after merge of the arm64 tree Stephen Rothwell
2018-07-24 0:26 ` AKASHI Takahiro
2018-07-24 8:12 ` Arnd Bergmann
2018-07-24 9:30 ` Ard Biesheuvel
2022-03-09 11:34 Stephen Rothwell
2022-03-09 12:18 ` Will Deacon
2022-07-07 9:57 Stephen Rothwell
2022-07-07 10:28 ` Will Deacon
2023-06-13 6:23 Stephen Rothwell
2023-06-13 15:59 ` Catalin Marinas
2023-10-24 6:24 Stephen Rothwell
2023-10-24 9:55 ` Catalin Marinas
2023-10-24 13:42 ` Ard Biesheuvel
2023-10-24 16:14 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).