linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: David Miller <davem@davemloft.net>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>,
	Linux-Next Mailing List <linux-next@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the net tree
Date: Wed, 22 Aug 2018 12:26:24 -0700	[thread overview]
Message-ID: <CAM_iQpUDjemL5OQt=D3hr6dCfqcKoi1w-CM9SHyTRcZ=aPeWsQ@mail.gmail.com> (raw)
In-Reply-To: <20180822080449.5887e244@canb.auug.org.au>

On Tue, Aug 21, 2018 at 3:04 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the net tree, today's linux-next build (KCONFIG_NAME)
> produced this warning:
>
> drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c: In function 'tc_fill_actions':
> drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c:64:6: warning: unused variable 'i' [-Wunused-variable]
>   int i;
>       ^
>
> Introduced by commit
>
>   244cd96adb5f ("net_sched: remove list_head from tc_action")

I bet you have CONFIG_NET_CLS_ACT=n?

Here is a quick fix:

diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h
index c17d51865469..9ec471ffaa5d 100644
--- a/include/net/pkt_cls.h
+++ b/include/net/pkt_cls.h
@@ -303,7 +303,7 @@ static inline void tcf_exts_put_net(struct tcf_exts *exts)
        for (i = 0; i < TCA_ACT_MAX_PRIO && ((a) = (exts)->actions[i]); i++)
 #else
 #define tcf_exts_for_each_action(i, a, exts) \
-       for (; 0; )
+       for ((void)i, (void)a; 0; )
 #endif

 static inline void

Interestingly, neither my compiler nor kbuild-bot's compiler doesn't
catch this.

Thanks.

  reply	other threads:[~2018-08-22 19:26 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-21 22:04 linux-next: build warning after merge of the net tree Stephen Rothwell
2018-08-22 19:26 ` Cong Wang [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-12-04 21:44 Stephen Rothwell
2019-12-05 22:57 ` David Miller
2019-12-05 23:48   ` Stephen Rothwell
2019-01-14  4:15 Stephen Rothwell
2017-08-22 23:34 Stephen Rothwell
2017-06-13 11:08 Stephen Rothwell
2017-06-13 11:31 ` Ashwanth Goli
2017-01-18 22:56 Stephen Rothwell
2017-01-19  8:26 ` Tariq Toukan
2014-09-18  0:32 Stephen Rothwell
2014-09-18  0:35 ` Randy Dunlap
2014-09-23 14:59   ` Michal Marek
2014-09-23 21:23     ` Stephen Rothwell
2014-09-24  0:36       ` Stephen Rothwell
2014-09-24  1:58       ` David Miller
2011-05-13  1:41 Stephen Rothwell
2011-05-13  3:04 ` David Miller
2011-05-09  3:46 Stephen Rothwell
2011-05-09  4:13 ` David Miller
2010-07-22  2:11 Stephen Rothwell
2010-07-22  4:09 ` David Miller
2010-07-07  4:30 Stephen Rothwell
2010-07-08  1:23 ` David Miller
2010-07-06  4:25 Stephen Rothwell
2010-07-08  0:45 ` David Miller
2010-07-08  1:18   ` David Miller
2010-07-08  4:13     ` Joe Perches
2010-07-11  2:52       ` David Miller
2010-08-31  2:57 ` Stephen Rothwell
2010-08-31  3:14   ` Joe Perches
2010-08-31  3:58     ` Stephen Rothwell
2010-08-31  4:03       ` Joe Perches
2010-08-31  4:46         ` David Miller
2010-08-31  4:45       ` David Miller
2010-08-31  4:42   ` David Miller
2010-03-01  5:47 Stephen Rothwell
2010-03-01  7:02 ` David Miller
2010-02-15  3:32 Stephen Rothwell
2010-02-15  6:21 ` David Miller
2010-02-15  6:51 ` David Miller
2010-02-15  9:36   ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM_iQpUDjemL5OQt=D3hr6dCfqcKoi1w-CM9SHyTRcZ=aPeWsQ@mail.gmail.com' \
    --to=xiyou.wangcong@gmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).