linux-next: build failure after merge of the efi tree

linux-next: build failure after merge of the efi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

Hi all,

After merging the efi tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

In file included from drivers/platform/x86/uv_sysfs.c:14:
arch/x86/include/asm/uv/bios.h:118:22: error: expected ')' before '*' token
  118 |         u64 (__efiapi *function)(enum uv_bios_cmd, ...);
      |                      ^~
      |                      )

Caused by commit

  73632c8c865f ("efi/runtime-wrappers: Remove duplicated macro for service returning void")

I havwe used the efi tree from next-20230821 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the efi tree

[Ard Biesheuvel]

Hello Stephen,

On Tue, 22 Aug 2023 at 08:49, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the efi tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> In file included from drivers/platform/x86/uv_sysfs.c:14:
> arch/x86/include/asm/uv/bios.h:118:22: error: expected ')' before '*' token
>   118 |         u64 (__efiapi *function)(enum uv_bios_cmd, ...);
>       |                      ^~
>       |                      )
>
> Caused by commit
>
>   73632c8c865f ("efi/runtime-wrappers: Remove duplicated macro for service returning void")
>

Thanks for the report.

I cannot reproduce this with Debian's GCC 12.2.0 when building the
efi/next tree either in isolation, or merged into yesterday's next.

Could you please share the compiler version and the .config you used? Thanks.

-- 
Ard.

Re: linux-next: build failure after merge of the efi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]

Hi Ard,

On Tue, 22 Aug 2023 09:32:31 +0200 Ard Biesheuvel <ardb@kernel.org> wrote:
>
> Hello Stephen,
> 
> On Tue, 22 Aug 2023 at 08:49, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > After merging the efi tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> >
> > In file included from drivers/platform/x86/uv_sysfs.c:14:
> > arch/x86/include/asm/uv/bios.h:118:22: error: expected ')' before '*' token
> >   118 |         u64 (__efiapi *function)(enum uv_bios_cmd, ...);
> >       |                      ^~
> >       |                      )
> >
> > Caused by commit
> >
> >   73632c8c865f ("efi/runtime-wrappers: Remove duplicated macro for service returning void")
> >  
> 
> Thanks for the report.
> 
> I cannot reproduce this with Debian's GCC 12.2.0 when building the
> efi/next tree either in isolation, or merged into yesterday's next.
> 
> Could you please share the compiler version and the .config you used? Thanks.

$ x86_64-linux-gnu-gcc --version
x86_64-linux-gnu-gcc (Debian 12.3.0-4) 12.3.0
(this is Debian's cross compiler that is ppcle64 hosted)

and (see above) it is a x86_64 allmodconfig build.

Maybe there is some interaction with something else in today's
linux-next (just released).
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the efi tree

[Ard Biesheuvel]

On Tue, 22 Aug 2023 at 10:08, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Ard,
>
> On Tue, 22 Aug 2023 09:32:31 +0200 Ard Biesheuvel <ardb@kernel.org> wrote:
> >
> > Hello Stephen,
> >
> > On Tue, 22 Aug 2023 at 08:49, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > Hi all,
> > >
> > > After merging the efi tree, today's linux-next build (x86_64 allmodconfig)
> > > failed like this:
> > >
> > > In file included from drivers/platform/x86/uv_sysfs.c:14:
> > > arch/x86/include/asm/uv/bios.h:118:22: error: expected ')' before '*' token
> > >   118 |         u64 (__efiapi *function)(enum uv_bios_cmd, ...);
> > >       |                      ^~
> > >       |                      )
> > >
> > > Caused by commit
> > >
> > >   73632c8c865f ("efi/runtime-wrappers: Remove duplicated macro for service returning void")
> > >
> >
> > Thanks for the report.
> >
> > I cannot reproduce this with Debian's GCC 12.2.0 when building the
> > efi/next tree either in isolation, or merged into yesterday's next.
> >
> > Could you please share the compiler version and the .config you used? Thanks.
>
> $ x86_64-linux-gnu-gcc --version
> x86_64-linux-gnu-gcc (Debian 12.3.0-4) 12.3.0
> (this is Debian's cross compiler that is ppcle64 hosted)
>
> and (see above) it is a x86_64 allmodconfig build.
>
> Maybe there is some interaction with something else in today's
> linux-next (just released).

Thanks. I fixed it in the efi/next tree so things should build as
expected the next time around.

Re: linux-next: build failure after merge of the efi tree

[Ard Biesheuvel]

On Mon, 19 Sept 2022 at 11:12, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Mon, 19 Sept 2022 at 11:11, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > After merging the efi tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> >
> > x86_64-linux-gnu-ld: drivers/firmware/efi/libstub/x86-stub.stub.o:(.bss.efistub+0x8): multiple definition of `efi_system_table'; drivers/firmware/efi/libstub/systable.stub.o:(.bss.efistub+0x0): first defined here
> >
> > Presumably caused by commit
> >
> >   8fd3c9a90998 ("efi/libstub: move efi_system_table global var into separate object")
> >
> > (or maybe commit
> >
> >   ba2dd31b7588 ("efi/libstub: implement generic EFI zboot")
> > )
> >
> > I have used the efi tree from next-20220916 for today.
> >
>
> Thanks for the report. I'll take a look and fix this asap.

Fixed now on efi/next so we should be ok for tomorrow.

Re: linux-next: build failure after merge of the efi tree

[Ard Biesheuvel]

On Mon, 19 Sept 2022 at 11:11, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the efi tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> x86_64-linux-gnu-ld: drivers/firmware/efi/libstub/x86-stub.stub.o:(.bss.efistub+0x8): multiple definition of `efi_system_table'; drivers/firmware/efi/libstub/systable.stub.o:(.bss.efistub+0x0): first defined here
>
> Presumably caused by commit
>
>   8fd3c9a90998 ("efi/libstub: move efi_system_table global var into separate object")
>
> (or maybe commit
>
>   ba2dd31b7588 ("efi/libstub: implement generic EFI zboot")
> )
>
> I have used the efi tree from next-20220916 for today.
>

Thanks for the report. I'll take a look and fix this asap.

linux-next: build failure after merge of the efi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]

Hi all,

After merging the efi tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

x86_64-linux-gnu-ld: drivers/firmware/efi/libstub/x86-stub.stub.o:(.bss.efistub+0x8): multiple definition of `efi_system_table'; drivers/firmware/efi/libstub/systable.stub.o:(.bss.efistub+0x0): first defined here

Presumably caused by commit

  8fd3c9a90998 ("efi/libstub: move efi_system_table global var into separate object")

(or maybe commit

  ba2dd31b7588 ("efi/libstub: implement generic EFI zboot")
)

I have used the efi tree from next-20220916 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]