* [-next]: s390 *_irq() link errors
@ 2012-09-16 19:07 Geert Uytterhoeven
2012-09-27 11:51 ` Heiko Carstens
0 siblings, 1 reply; 9+ messages in thread
From: Geert Uytterhoeven @ 2012-09-16 19:07 UTC (permalink / raw)
To: linux-s390; +Cc: Linux-Next, linux-kernel
After applying http://www.spinics.net/lists/linux-next/msg21973.html,
the s390 allmodconfig build in linux-next fails in the linking stage with:
ERROR: "free_irq" [drivers/power/smb347-charger.ko] undefined!
ERROR: "free_irq" [drivers/power/sbs-battery.ko] undefined!
ERROR: "enable_irq" [drivers/power/max17042_battery.ko] undefined!
ERROR: "request_irq" [drivers/power/max17042_battery.ko] undefined!
ERROR: "free_irq" [drivers/power/max17042_battery.ko] undefined!
ERROR: "disable_irq" [drivers/power/max17042_battery.ko] undefined!
ERROR: "request_irq" [drivers/power/lp8727_charger.ko] undefined!
ERROR: "free_irq" [drivers/power/lp8727_charger.ko] undefined!
ERROR: "request_irq" [drivers/nfc/pn544_hci.ko] undefined!
ERROR: "free_irq" [drivers/nfc/pn544_hci.ko] undefined!
ERROR: "request_irq" [drivers/nfc/pn544.ko] undefined!
ERROR: "free_irq" [drivers/nfc/pn544.ko] undefined!
ERROR: "request_irq" [drivers/misc/fsa9480.ko] undefined!
ERROR: "free_irq" [drivers/misc/fsa9480.ko] undefined!
ERROR: "request_irq" [drivers/misc/bh1770glc.ko] undefined!
ERROR: "free_irq" [drivers/misc/bh1770glc.ko] undefined!
ERROR: "request_irq" [drivers/misc/apds990x.ko] undefined!
ERROR: "free_irq" [drivers/misc/apds990x.ko] undefined!
What should these drivers depend on? GENERIC_HARDIRQS?
S390 is the only non-GENERIC_HARDIRQS architecture left, but all
other former non-GENERIC_HARDIRQS architectures did provide e.g. request_irq()
and free_irq().
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [-next]: s390 *_irq() link errors
2012-09-16 19:07 [-next]: s390 *_irq() link errors Geert Uytterhoeven
@ 2012-09-27 11:51 ` Heiko Carstens
2012-09-29 16:39 ` Geert Uytterhoeven
0 siblings, 1 reply; 9+ messages in thread
From: Heiko Carstens @ 2012-09-27 11:51 UTC (permalink / raw)
To: Geert Uytterhoeven, Peter Huewe, Jean Delvare
Cc: linux-s390, Linux-Next, linux-kernel
On Sun, Sep 16, 2012 at 09:07:54PM +0200, Geert Uytterhoeven wrote:
> After applying http://www.spinics.net/lists/linux-next/msg21973.html,
> the s390 allmodconfig build in linux-next fails in the linking stage with:
>
> ERROR: "free_irq" [drivers/power/smb347-charger.ko] undefined!
> ERROR: "free_irq" [drivers/power/sbs-battery.ko] undefined!
> ERROR: "enable_irq" [drivers/power/max17042_battery.ko] undefined!
> ERROR: "request_irq" [drivers/power/max17042_battery.ko] undefined!
> ERROR: "free_irq" [drivers/power/max17042_battery.ko] undefined!
> ERROR: "disable_irq" [drivers/power/max17042_battery.ko] undefined!
> ERROR: "request_irq" [drivers/power/lp8727_charger.ko] undefined!
> ERROR: "free_irq" [drivers/power/lp8727_charger.ko] undefined!
> ERROR: "request_irq" [drivers/nfc/pn544_hci.ko] undefined!
> ERROR: "free_irq" [drivers/nfc/pn544_hci.ko] undefined!
> ERROR: "request_irq" [drivers/nfc/pn544.ko] undefined!
> ERROR: "free_irq" [drivers/nfc/pn544.ko] undefined!
> ERROR: "request_irq" [drivers/misc/fsa9480.ko] undefined!
> ERROR: "free_irq" [drivers/misc/fsa9480.ko] undefined!
> ERROR: "request_irq" [drivers/misc/bh1770glc.ko] undefined!
> ERROR: "free_irq" [drivers/misc/bh1770glc.ko] undefined!
> ERROR: "request_irq" [drivers/misc/apds990x.ko] undefined!
> ERROR: "free_irq" [drivers/misc/apds990x.ko] undefined!
>
> What should these drivers depend on? GENERIC_HARDIRQS?
Probably, but...
> S390 is the only non-GENERIC_HARDIRQS architecture left, but all
> other former non-GENERIC_HARDIRQS architectures did provide e.g. request_irq()
> and free_irq().
All of this started because I2C lost its HAS_IOMEM dependency. Can't
we simply add an !S390 dependency instead and all is well? :)
Something like below?
>From 24c68e72b6198b8412a8605fac7d9c90796502ac Mon Sep 17 00:00:00 2001
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Date: Thu, 27 Sep 2012 13:37:14 +0200
Subject: [PATCH] i2c: Make I2C unavailable on s390 again
"i2c: Make I2C available on UML" removed the IOMEM dependency from I2C which
resulted in I2C being avaible on s390 and causing allmodconfig and allyesconfig
builds to fail:
drivers/misc/altera-stapl/altera-lpt.c: In function 'byteblaster_write':
drivers/misc/altera-stapl/altera-lpt.c:34:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]
Adding a HAS_PORT dependency to that driver reveals that there are lots
of other build errors waiting for discovery because of this change since
s390 does not support generic hardirqs:
ERROR: "free_irq" [drivers/power/smb347-charger.ko] undefined!
ERROR: "free_irq" [drivers/power/sbs-battery.ko] undefined!
ERROR: "enable_irq" [drivers/power/max17042_battery.ko] undefined!
ERROR: "request_irq" [drivers/power/max17042_battery.ko] undefined!
ERROR: "free_irq" [drivers/power/max17042_battery.ko] undefined!
ERROR: "disable_irq" [drivers/power/max17042_battery.ko] undefined!
ERROR: "request_irq" [drivers/power/lp8727_charger.ko] undefined!
ERROR: "free_irq" [drivers/power/lp8727_charger.ko] undefined!
ERROR: "request_irq" [drivers/nfc/pn544_hci.ko] undefined!
ERROR: "free_irq" [drivers/nfc/pn544_hci.ko] undefined!
ERROR: "request_irq" [drivers/nfc/pn544.ko] undefined!
ERROR: "free_irq" [drivers/nfc/pn544.ko] undefined!
ERROR: "request_irq" [drivers/misc/fsa9480.ko] undefined!
ERROR: "free_irq" [drivers/misc/fsa9480.ko] undefined!
ERROR: "request_irq" [drivers/misc/bh1770glc.ko] undefined!
ERROR: "free_irq" [drivers/misc/bh1770glc.ko] undefined!
ERROR: "request_irq" [drivers/misc/apds990x.ko] undefined!
ERROR: "free_irq" [drivers/misc/apds990x.ko] undefined!
Since UML seems to need generic I2C support, but lot's of now available
drivers fail to compile on s390, just add a !S390 dependency.
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Peter Huewe <peterhuewe@gmx.de>
Cc: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
drivers/i2c/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
index 17b35c1..2f8c76b 100644
--- a/drivers/i2c/Kconfig
+++ b/drivers/i2c/Kconfig
@@ -4,6 +4,7 @@
menuconfig I2C
tristate "I2C support"
+ depends on !S390
select RT_MUTEXES
---help---
I2C (pronounce: I-squared-C) is a slow serial bus protocol used in
--
1.7.11.7
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [-next]: s390 *_irq() link errors
2012-09-27 11:51 ` Heiko Carstens
@ 2012-09-29 16:39 ` Geert Uytterhoeven
2012-09-30 8:53 ` Jean Delvare
0 siblings, 1 reply; 9+ messages in thread
From: Geert Uytterhoeven @ 2012-09-29 16:39 UTC (permalink / raw)
To: Heiko Carstens
Cc: Peter Huewe, Jean Delvare, linux-s390, Linux-Next, linux-kernel
Hi Heiko,
On Thu, Sep 27, 2012 at 1:51 PM, Heiko Carstens
<heiko.carstens@de.ibm.com> wrote:
> On Sun, Sep 16, 2012 at 09:07:54PM +0200, Geert Uytterhoeven wrote:
>> After applying http://www.spinics.net/lists/linux-next/msg21973.html,
>> the s390 allmodconfig build in linux-next fails in the linking stage with:
>>
>> ERROR: "free_irq" [drivers/power/smb347-charger.ko] undefined!
>> ERROR: "free_irq" [drivers/power/sbs-battery.ko] undefined!
>> ERROR: "enable_irq" [drivers/power/max17042_battery.ko] undefined!
>> ERROR: "request_irq" [drivers/power/max17042_battery.ko] undefined!
>> ERROR: "free_irq" [drivers/power/max17042_battery.ko] undefined!
>> ERROR: "disable_irq" [drivers/power/max17042_battery.ko] undefined!
>> ERROR: "request_irq" [drivers/power/lp8727_charger.ko] undefined!
>> ERROR: "free_irq" [drivers/power/lp8727_charger.ko] undefined!
>> ERROR: "request_irq" [drivers/nfc/pn544_hci.ko] undefined!
>> ERROR: "free_irq" [drivers/nfc/pn544_hci.ko] undefined!
>> ERROR: "request_irq" [drivers/nfc/pn544.ko] undefined!
>> ERROR: "free_irq" [drivers/nfc/pn544.ko] undefined!
>> ERROR: "request_irq" [drivers/misc/fsa9480.ko] undefined!
>> ERROR: "free_irq" [drivers/misc/fsa9480.ko] undefined!
>> ERROR: "request_irq" [drivers/misc/bh1770glc.ko] undefined!
>> ERROR: "free_irq" [drivers/misc/bh1770glc.ko] undefined!
>> ERROR: "request_irq" [drivers/misc/apds990x.ko] undefined!
>> ERROR: "free_irq" [drivers/misc/apds990x.ko] undefined!
>>
>> What should these drivers depend on? GENERIC_HARDIRQS?
>
> Probably, but...
>
>> S390 is the only non-GENERIC_HARDIRQS architecture left, but all
>> other former non-GENERIC_HARDIRQS architectures did provide e.g. request_irq()
>> and free_irq().
>
> All of this started because I2C lost its HAS_IOMEM dependency. Can't
> we simply add an !S390 dependency instead and all is well? :)
>
> Something like below?
>
> From 24c68e72b6198b8412a8605fac7d9c90796502ac Mon Sep 17 00:00:00 2001
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
> Date: Thu, 27 Sep 2012 13:37:14 +0200
> Subject: [PATCH] i2c: Make I2C unavailable on s390 again
>
> "i2c: Make I2C available on UML" removed the IOMEM dependency from I2C which
> resulted in I2C being avaible on s390 and causing allmodconfig and allyesconfig
> builds to fail:
>
> drivers/misc/altera-stapl/altera-lpt.c: In function 'byteblaster_write':
> drivers/misc/altera-stapl/altera-lpt.c:34:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]
>
> Adding a HAS_PORT dependency to that driver reveals that there are lots
> of other build errors waiting for discovery because of this change since
> s390 does not support generic hardirqs:
>
> ERROR: "free_irq" [drivers/power/smb347-charger.ko] undefined!
> ERROR: "free_irq" [drivers/power/sbs-battery.ko] undefined!
> ERROR: "enable_irq" [drivers/power/max17042_battery.ko] undefined!
> ERROR: "request_irq" [drivers/power/max17042_battery.ko] undefined!
> ERROR: "free_irq" [drivers/power/max17042_battery.ko] undefined!
> ERROR: "disable_irq" [drivers/power/max17042_battery.ko] undefined!
> ERROR: "request_irq" [drivers/power/lp8727_charger.ko] undefined!
> ERROR: "free_irq" [drivers/power/lp8727_charger.ko] undefined!
> ERROR: "request_irq" [drivers/nfc/pn544_hci.ko] undefined!
> ERROR: "free_irq" [drivers/nfc/pn544_hci.ko] undefined!
> ERROR: "request_irq" [drivers/nfc/pn544.ko] undefined!
> ERROR: "free_irq" [drivers/nfc/pn544.ko] undefined!
> ERROR: "request_irq" [drivers/misc/fsa9480.ko] undefined!
> ERROR: "free_irq" [drivers/misc/fsa9480.ko] undefined!
> ERROR: "request_irq" [drivers/misc/bh1770glc.ko] undefined!
> ERROR: "free_irq" [drivers/misc/bh1770glc.ko] undefined!
> ERROR: "request_irq" [drivers/misc/apds990x.ko] undefined!
> ERROR: "free_irq" [drivers/misc/apds990x.ko] undefined!
>
> Since UML seems to need generic I2C support, but lot's of now available
> drivers fail to compile on s390, just add a !S390 dependency.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Peter Huewe <peterhuewe@gmx.de>
> Cc: Jean Delvare <khali@linux-fr.org>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Yeah, s390 is so special that it's the only architecture that can be used
in depends on !, so
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/i2c/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
> index 17b35c1..2f8c76b 100644
> --- a/drivers/i2c/Kconfig
> +++ b/drivers/i2c/Kconfig
> @@ -4,6 +4,7 @@
>
> menuconfig I2C
> tristate "I2C support"
> + depends on !S390
> select RT_MUTEXES
> ---help---
> I2C (pronounce: I-squared-C) is a slow serial bus protocol used in
> --
> 1.7.11.7
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [-next]: s390 *_irq() link errors
2012-09-29 16:39 ` Geert Uytterhoeven
@ 2012-09-30 8:53 ` Jean Delvare
2012-09-30 9:08 ` Geert Uytterhoeven
0 siblings, 1 reply; 9+ messages in thread
From: Jean Delvare @ 2012-09-30 8:53 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Heiko Carstens, Peter Huewe, linux-s390, Linux-Next, linux-kernel
On Sat, 29 Sep 2012 18:39:13 +0200, Geert Uytterhoeven wrote:
> On Thu, Sep 27, 2012 at 1:51 PM, Heiko Carstens
> > From 24c68e72b6198b8412a8605fac7d9c90796502ac Mon Sep 17 00:00:00 2001
> > From: Heiko Carstens <heiko.carstens@de.ibm.com>
> > Date: Thu, 27 Sep 2012 13:37:14 +0200
> > Subject: [PATCH] i2c: Make I2C unavailable on s390 again
> >
> > "i2c: Make I2C available on UML" removed the IOMEM dependency from I2C which
> > resulted in I2C being avaible on s390 and causing allmodconfig and allyesconfig
> > builds to fail:
> >
> > drivers/misc/altera-stapl/altera-lpt.c: In function 'byteblaster_write':
> > drivers/misc/altera-stapl/altera-lpt.c:34:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]
> >
> > Adding a HAS_PORT dependency to that driver reveals that there are lots
> > of other build errors waiting for discovery because of this change since
> > s390 does not support generic hardirqs:
> >
> > ERROR: "free_irq" [drivers/power/smb347-charger.ko] undefined!
> > ERROR: "free_irq" [drivers/power/sbs-battery.ko] undefined!
> > ERROR: "enable_irq" [drivers/power/max17042_battery.ko] undefined!
> > ERROR: "request_irq" [drivers/power/max17042_battery.ko] undefined!
> > ERROR: "free_irq" [drivers/power/max17042_battery.ko] undefined!
> > ERROR: "disable_irq" [drivers/power/max17042_battery.ko] undefined!
> > ERROR: "request_irq" [drivers/power/lp8727_charger.ko] undefined!
> > ERROR: "free_irq" [drivers/power/lp8727_charger.ko] undefined!
> > ERROR: "request_irq" [drivers/nfc/pn544_hci.ko] undefined!
> > ERROR: "free_irq" [drivers/nfc/pn544_hci.ko] undefined!
> > ERROR: "request_irq" [drivers/nfc/pn544.ko] undefined!
> > ERROR: "free_irq" [drivers/nfc/pn544.ko] undefined!
> > ERROR: "request_irq" [drivers/misc/fsa9480.ko] undefined!
> > ERROR: "free_irq" [drivers/misc/fsa9480.ko] undefined!
> > ERROR: "request_irq" [drivers/misc/bh1770glc.ko] undefined!
> > ERROR: "free_irq" [drivers/misc/bh1770glc.ko] undefined!
> > ERROR: "request_irq" [drivers/misc/apds990x.ko] undefined!
> > ERROR: "free_irq" [drivers/misc/apds990x.ko] undefined!
> >
> > Since UML seems to need generic I2C support, but lot's of now available
> > drivers fail to compile on s390, just add a !S390 dependency.
> >
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Cc: Peter Huewe <peterhuewe@gmx.de>
> > Cc: Jean Delvare <khali@linux-fr.org>
> > Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> Yeah, s390 is so special that it's the only architecture that can be used
> in depends on !, so
>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > ---
> > drivers/i2c/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
> > index 17b35c1..2f8c76b 100644
> > --- a/drivers/i2c/Kconfig
> > +++ b/drivers/i2c/Kconfig
> > @@ -4,6 +4,7 @@
> >
> > menuconfig I2C
> > tristate "I2C support"
> > + depends on !S390
> > select RT_MUTEXES
> > ---help---
> > I2C (pronounce: I-squared-C) is a slow serial bus protocol used in
I thought we were trying to move away from explicit arch exclusions,
but if S390 is special then fine with me. I've folded Heiko's fix into
Peter's patch, as it is not committed yet. Result is at:
http://khali.linux-fr.org/devel/linux-3/jdelvare-i2c/i2c-make-I2C-available-on-UML.patch
That's what will be in the next linux-next.
--
Jean Delvare
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [-next]: s390 *_irq() link errors
2012-09-30 8:53 ` Jean Delvare
@ 2012-09-30 9:08 ` Geert Uytterhoeven
2012-09-30 9:20 ` Jean Delvare
0 siblings, 1 reply; 9+ messages in thread
From: Geert Uytterhoeven @ 2012-09-30 9:08 UTC (permalink / raw)
To: Jean Delvare
Cc: Heiko Carstens, Peter Huewe, linux-s390, Linux-Next, linux-kernel
On Sun, Sep 30, 2012 at 10:53 AM, Jean Delvare <khali@linux-fr.org> wrote:
> On Sat, 29 Sep 2012 18:39:13 +0200, Geert Uytterhoeven wrote:
>> On Thu, Sep 27, 2012 at 1:51 PM, Heiko Carstens
>> > From 24c68e72b6198b8412a8605fac7d9c90796502ac Mon Sep 17 00:00:00 2001
>> > From: Heiko Carstens <heiko.carstens@de.ibm.com>
>> > Date: Thu, 27 Sep 2012 13:37:14 +0200
>> > Subject: [PATCH] i2c: Make I2C unavailable on s390 again
>> >
>> > "i2c: Make I2C available on UML" removed the IOMEM dependency from I2C which
>> > resulted in I2C being avaible on s390 and causing allmodconfig and allyesconfig
>> > builds to fail:
>> >
>> > drivers/misc/altera-stapl/altera-lpt.c: In function 'byteblaster_write':
>> > drivers/misc/altera-stapl/altera-lpt.c:34:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]
>> >
>> > Adding a HAS_PORT dependency to that driver reveals that there are lots
>> > of other build errors waiting for discovery because of this change since
>> > s390 does not support generic hardirqs:
>> >
>> > ERROR: "free_irq" [drivers/power/smb347-charger.ko] undefined!
>> > ERROR: "free_irq" [drivers/power/sbs-battery.ko] undefined!
>> > ERROR: "enable_irq" [drivers/power/max17042_battery.ko] undefined!
>> > ERROR: "request_irq" [drivers/power/max17042_battery.ko] undefined!
>> > ERROR: "free_irq" [drivers/power/max17042_battery.ko] undefined!
>> > ERROR: "disable_irq" [drivers/power/max17042_battery.ko] undefined!
>> > ERROR: "request_irq" [drivers/power/lp8727_charger.ko] undefined!
>> > ERROR: "free_irq" [drivers/power/lp8727_charger.ko] undefined!
>> > ERROR: "request_irq" [drivers/nfc/pn544_hci.ko] undefined!
>> > ERROR: "free_irq" [drivers/nfc/pn544_hci.ko] undefined!
>> > ERROR: "request_irq" [drivers/nfc/pn544.ko] undefined!
>> > ERROR: "free_irq" [drivers/nfc/pn544.ko] undefined!
>> > ERROR: "request_irq" [drivers/misc/fsa9480.ko] undefined!
>> > ERROR: "free_irq" [drivers/misc/fsa9480.ko] undefined!
>> > ERROR: "request_irq" [drivers/misc/bh1770glc.ko] undefined!
>> > ERROR: "free_irq" [drivers/misc/bh1770glc.ko] undefined!
>> > ERROR: "request_irq" [drivers/misc/apds990x.ko] undefined!
>> > ERROR: "free_irq" [drivers/misc/apds990x.ko] undefined!
>> >
>> > Since UML seems to need generic I2C support, but lot's of now available
>> > drivers fail to compile on s390, just add a !S390 dependency.
>> >
>> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> > Cc: Peter Huewe <peterhuewe@gmx.de>
>> > Cc: Jean Delvare <khali@linux-fr.org>
>> > Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
>>
>> Yeah, s390 is so special that it's the only architecture that can be used
>> in depends on !, so
>>
>> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> > ---
>> > drivers/i2c/Kconfig | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
>> > index 17b35c1..2f8c76b 100644
>> > --- a/drivers/i2c/Kconfig
>> > +++ b/drivers/i2c/Kconfig
>> > @@ -4,6 +4,7 @@
>> >
>> > menuconfig I2C
>> > tristate "I2C support"
>> > + depends on !S390
>> > select RT_MUTEXES
>> > ---help---
>> > I2C (pronounce: I-squared-C) is a slow serial bus protocol used in
>
> I thought we were trying to move away from explicit arch exclusions,
> but if S390 is special then fine with me. I've folded Heiko's fix into
"depends on GENERIC_HARDIRQS" is the alternative...
Hmm, I just noticed we already have lots of dependencies on GENERIC_HARDIRQS,
especially w.r.t I2C:
drivers/gpio/Kconfig: depends on GPIO_MAX732X=y && GENERIC_HARDIRQS
drivers/iio/Kconfig: depends on GENERIC_HARDIRQS
drivers/input/touchscreen/Kconfig: depends on SPI_MASTER &&
GENERIC_HARDIRQS
drivers/mfd/Kconfig: depends on I2C=y && GENERIC_HARDIRQS
drivers/mfd/Kconfig: depends on I2C=y && GENERIC_HARDIRQS
drivers/mfd/Kconfig: depends on I2C=y && GENERIC_HARDIRQS
drivers/mfd/Kconfig: depends on GENERIC_HARDIRQS && GPIOLIB && ARM
drivers/mfd/Kconfig: depends on GENERIC_HARDIRQS && GPIOLIB && ARM
drivers/mfd/Kconfig: depends on I2C=y && GENERIC_HARDIRQS
drivers/mfd/Kconfig: depends on I2C=y && GENERIC_HARDIRQS
drivers/mfd/Kconfig: depends on I2C=y && GENERIC_HARDIRQS
drivers/mfd/Kconfig: depends on (I2C=y || SPI_MASTER=y) && GENERIC_HARDIRQS
drivers/mfd/Kconfig: depends on I2C=y && GENERIC_HARDIRQS
drivers/mfd/Kconfig: depends on I2C=y && GENERIC_HARDIRQS
drivers/mfd/Kconfig: depends on I2C=y && GENERIC_HARDIRQS
drivers/mfd/Kconfig: depends on I2C=y && GENERIC_HARDIRQS
drivers/mfd/Kconfig: depends on I2C=y && GENERIC_HARDIRQS
drivers/mfd/Kconfig: depends on I2C=y && GENERIC_HARDIRQS
drivers/mfd/Kconfig: depends on I2C=y && GENERIC_HARDIRQS
drivers/mfd/Kconfig: depends on GENERIC_HARDIRQS
drivers/mfd/Kconfig: depends on I2C=y && GENERIC_HARDIRQS
drivers/mfd/Kconfig: depends on SPI_MASTER && GENERIC_HARDIRQS
drivers/mfd/Kconfig: depends on GENERIC_HARDIRQS
drivers/mfd/Kconfig: depends on I2C=y && GENERIC_HARDIRQS
drivers/mfd/Kconfig: depends on I2C=y && GENERIC_HARDIRQS
drivers/mfd/Kconfig: depends on GENERIC_HARDIRQS && SPI_MASTER
drivers/mfd/Kconfig: depends on GENERIC_HARDIRQS && ABX500_CORE &&
MFD_DB8500_PRCMU
drivers/mfd/Kconfig: depends on I2C=y && GENERIC_HARDIRQS
drivers/mfd/Kconfig: depends on I2C=y && GENERIC_HARDIRQS
drivers/net/wireless/p54/Kconfig: depends on P54_COMMON && SPI_MASTER
&& GENERIC_HARDIRQS
drivers/net/wireless/ti/wl1251/Kconfig: depends on MAC80211 &&
EXPERIMENTAL && GENERIC_HARDIRQS
drivers/net/wireless/ti/wlcore/Kconfig: depends on WL_TI &&
GENERIC_HARDIRQS && MAC80211
drivers/power/Kconfig: depends on GENERIC_HARDIRQS
drivers/pps/clients/Kconfig: depends on PPS && GENERIC_HARDIRQS
drivers/w1/masters/Kconfig: depends on W1 && GENERIC_HARDIRQS
kernel/irq/Kconfig:config GENERIC_HARDIRQS
lib/Kconfig.debug: depends on DEBUG_KERNEL && GENERIC_HARDIRQS
net/Kconfig: depends on RPS && GENERIC_HARDIRQS
sound/soc/samsung/Kconfig: depends on I2C=y && GENERIC_HARDIRQS
sound/soc/samsung/Kconfig: depends on I2C=y && GENERIC_HARDIRQS
sound/soc/samsung/Kconfig: depends on I2C=y && GENERIC_HARDIRQS
> Peter's patch, as it is not committed yet. Result is at:
>
> http://khali.linux-fr.org/devel/linux-3/jdelvare-i2c/i2c-make-I2C-available-on-UML.patch
>
> That's what will be in the next linux-next.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [-next]: s390 *_irq() link errors
2012-09-30 9:08 ` Geert Uytterhoeven
@ 2012-09-30 9:20 ` Jean Delvare
2012-09-30 9:35 ` Geert Uytterhoeven
0 siblings, 1 reply; 9+ messages in thread
From: Jean Delvare @ 2012-09-30 9:20 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Heiko Carstens, Peter Huewe, linux-s390, Linux-Next, linux-kernel
On Sun, 30 Sep 2012 11:08:41 +0200, Geert Uytterhoeven wrote:
> On Sun, Sep 30, 2012 at 10:53 AM, Jean Delvare <khali@linux-fr.org> wrote:
> > I thought we were trying to move away from explicit arch exclusions,
> > but if S390 is special then fine with me. I've folded Heiko's fix into
>
> "depends on GENERIC_HARDIRQS" is the alternative...
That would make even less sense to me, I2C can work just fine without
IRQs.
--
Jean Delvare
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [-next]: s390 *_irq() link errors
2012-09-30 9:20 ` Jean Delvare
@ 2012-09-30 9:35 ` Geert Uytterhoeven
2012-09-30 10:05 ` Jean Delvare
0 siblings, 1 reply; 9+ messages in thread
From: Geert Uytterhoeven @ 2012-09-30 9:35 UTC (permalink / raw)
To: Jean Delvare
Cc: Heiko Carstens, Peter Huewe, linux-s390, Linux-Next, linux-kernel
On Sun, Sep 30, 2012 at 11:20 AM, Jean Delvare <khali@linux-fr.org> wrote:
> On Sun, 30 Sep 2012 11:08:41 +0200, Geert Uytterhoeven wrote:
>> On Sun, Sep 30, 2012 at 10:53 AM, Jean Delvare <khali@linux-fr.org> wrote:
>> > I thought we were trying to move away from explicit arch exclusions,
>> > but if S390 is special then fine with me. I've folded Heiko's fix into
>>
>> "depends on GENERIC_HARDIRQS" is the alternative...
>
> That would make even less sense to me, I2C can work just fine without
> IRQs.
For the individual drivers that need it...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [-next]: s390 *_irq() link errors
2012-09-30 9:35 ` Geert Uytterhoeven
@ 2012-09-30 10:05 ` Jean Delvare
2012-09-30 11:08 ` Geert Uytterhoeven
0 siblings, 1 reply; 9+ messages in thread
From: Jean Delvare @ 2012-09-30 10:05 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Heiko Carstens, Peter Huewe, linux-s390, Linux-Next, linux-kernel
On Sun, 30 Sep 2012 11:35:41 +0200, Geert Uytterhoeven wrote:
> On Sun, Sep 30, 2012 at 11:20 AM, Jean Delvare <khali@linux-fr.org> wrote:
> > On Sun, 30 Sep 2012 11:08:41 +0200, Geert Uytterhoeven wrote:
> >> On Sun, Sep 30, 2012 at 10:53 AM, Jean Delvare <khali@linux-fr.org> wrote:
> >> > I thought we were trying to move away from explicit arch exclusions,
> >> > but if S390 is special then fine with me. I've folded Heiko's fix into
> >>
> >> "depends on GENERIC_HARDIRQS" is the alternative...
> >
> > That would make even less sense to me, I2C can work just fine without
> > IRQs.
>
> For the individual drivers that need it...
Oh, of course. Sorry I was probably not completely awaken ;)
Either way is fine with me if it makes developers and users happy.
--
Jean Delvare
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [-next]: s390 *_irq() link errors
2012-09-30 10:05 ` Jean Delvare
@ 2012-09-30 11:08 ` Geert Uytterhoeven
0 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2012-09-30 11:08 UTC (permalink / raw)
To: Jean Delvare
Cc: Heiko Carstens, Peter Huewe, linux-s390, Linux-Next, linux-kernel
On Sun, Sep 30, 2012 at 12:05 PM, Jean Delvare <khali@linux-fr.org> wrote:
> On Sun, 30 Sep 2012 11:35:41 +0200, Geert Uytterhoeven wrote:
>> On Sun, Sep 30, 2012 at 11:20 AM, Jean Delvare <khali@linux-fr.org> wrote:
>> > On Sun, 30 Sep 2012 11:08:41 +0200, Geert Uytterhoeven wrote:
>> >> On Sun, Sep 30, 2012 at 10:53 AM, Jean Delvare <khali@linux-fr.org> wrote:
>> >> > I thought we were trying to move away from explicit arch exclusions,
>> >> > but if S390 is special then fine with me. I've folded Heiko's fix into
>> >>
>> >> "depends on GENERIC_HARDIRQS" is the alternative...
>> >
>> > That would make even less sense to me, I2C can work just fine without
>> > IRQs.
>>
>> For the individual drivers that need it...
>
> Oh, of course. Sorry I was probably not completely awaken ;)
Me neither ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-09-30 11:08 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-16 19:07 [-next]: s390 *_irq() link errors Geert Uytterhoeven
2012-09-27 11:51 ` Heiko Carstens
2012-09-29 16:39 ` Geert Uytterhoeven
2012-09-30 8:53 ` Jean Delvare
2012-09-30 9:08 ` Geert Uytterhoeven
2012-09-30 9:20 ` Jean Delvare
2012-09-30 9:35 ` Geert Uytterhoeven
2012-09-30 10:05 ` Jean Delvare
2012-09-30 11:08 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).