* [PATCH -next] [media] altera-stapl should depend on HAS_IOPORT
@ 2012-09-16 9:21 Geert Uytterhoeven
2012-09-16 10:07 ` Jean Delvare
[not found] ` <1347787283-11994-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2012-09-16 9:21 UTC (permalink / raw)
To: Igor M. Liplianin, Peter Huewe, Jean Delvare, Mauro Carvalho Chehab
Cc: linux-i2c, user-mode-linux-devel, linux-next, Geert Uytterhoeven
On s390:
drivers/misc/altera-stapl/altera-lpt.c: In function 'byteblaster_write':
drivers/misc/altera-stapl/altera-lpt.c:34:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]
drivers/misc/altera-stapl/altera-lpt.c: In function 'byteblaster_read':
drivers/misc/altera-stapl/altera-lpt.c:40:2: error: implicit declaration of function 'inb' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[6]: *** [drivers/misc/altera-stapl/altera-lpt.o] Error 1
Before commit 3969d54acd70be70e1b2a72184cba5415bf326c2 ("i2c: Make I2C
available on UML"), this was hidden because I2C depended on HAS_IOMEM, which
is a superset of HAS_IOPORT.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
--
http://kisskb.ellerman.id.au/kisskb/buildresult/7194502/
http://kisskb.ellerman.id.au/kisskb/buildresult/7194476/
---
drivers/misc/altera-stapl/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/misc/altera-stapl/Kconfig b/drivers/misc/altera-stapl/Kconfig
index 7f01d8e..c7e4c77 100644
--- a/drivers/misc/altera-stapl/Kconfig
+++ b/drivers/misc/altera-stapl/Kconfig
@@ -2,7 +2,7 @@ comment "Altera FPGA firmware download module"
config ALTERA_STAPL
tristate "Altera FPGA firmware download module"
- depends on I2C
+ depends on I2C && HAS_IOPORT
default n
help
An Altera FPGA module. Say Y when you want to support this tool.
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] [media] altera-stapl should depend on HAS_IOPORT
2012-09-16 9:21 [PATCH -next] [media] altera-stapl should depend on HAS_IOPORT Geert Uytterhoeven
@ 2012-09-16 10:07 ` Jean Delvare
[not found] ` <1347787283-11994-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
1 sibling, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2012-09-16 10:07 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Igor M. Liplianin, Peter Huewe, Mauro Carvalho Chehab, linux-i2c,
user-mode-linux-devel, linux-next
On Sun, 16 Sep 2012 11:21:23 +0200, Geert Uytterhoeven wrote:
> On s390:
>
> drivers/misc/altera-stapl/altera-lpt.c: In function 'byteblaster_write':
> drivers/misc/altera-stapl/altera-lpt.c:34:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]
> drivers/misc/altera-stapl/altera-lpt.c: In function 'byteblaster_read':
> drivers/misc/altera-stapl/altera-lpt.c:40:2: error: implicit declaration of function 'inb' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[6]: *** [drivers/misc/altera-stapl/altera-lpt.o] Error 1
>
> Before commit 3969d54acd70be70e1b2a72184cba5415bf326c2 ("i2c: Make I2C
> available on UML"), this was hidden because I2C depended on HAS_IOMEM, which
> is a superset of HAS_IOPORT.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Good catch.
Acked-by: Jean Delvare <khali@linux-fr.org>
> --
> http://kisskb.ellerman.id.au/kisskb/buildresult/7194502/
> http://kisskb.ellerman.id.au/kisskb/buildresult/7194476/
> ---
> drivers/misc/altera-stapl/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/misc/altera-stapl/Kconfig b/drivers/misc/altera-stapl/Kconfig
> index 7f01d8e..c7e4c77 100644
> --- a/drivers/misc/altera-stapl/Kconfig
> +++ b/drivers/misc/altera-stapl/Kconfig
> @@ -2,7 +2,7 @@ comment "Altera FPGA firmware download module"
>
> config ALTERA_STAPL
> tristate "Altera FPGA firmware download module"
> - depends on I2C
> + depends on I2C && HAS_IOPORT
> default n
> help
> An Altera FPGA module. Say Y when you want to support this tool.
--
Jean Delvare
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] [media] altera-stapl should depend on HAS_IOPORT
[not found] ` <1347787283-11994-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
@ 2012-09-16 19:00 ` Geert Uytterhoeven
0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2012-09-16 19:00 UTC (permalink / raw)
To: Igor M. Liplianin, Peter Huewe, Jean Delvare, Mauro Carvalho Chehab
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA,
user-mode-linux-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
linux-next-u79uwXL29TY76Z2rM5mHXA, Geert Uytterhoeven
On Sun, Sep 16, 2012 at 11:21 AM, Geert Uytterhoeven
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org> wrote:
> On s390:
>
> drivers/misc/altera-stapl/altera-lpt.c: In function 'byteblaster_write':
> drivers/misc/altera-stapl/altera-lpt.c:34:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]
> drivers/misc/altera-stapl/altera-lpt.c: In function 'byteblaster_read':
> drivers/misc/altera-stapl/altera-lpt.c:40:2: error: implicit declaration of function 'inb' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[6]: *** [drivers/misc/altera-stapl/altera-lpt.o] Error 1
>
> Before commit 3969d54acd70be70e1b2a72184cba5415bf326c2 ("i2c: Make I2C
> available on UML"), this was hidden because I2C depended on HAS_IOMEM, which
> is a superset of HAS_IOPORT.
>
> Signed-off-by: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Apparently Arnd sent out a patch to fix this while the driver was
still in staging:
http://lkml.indiana.edu/hypermail/linux/kernel/1107.0/00432.html
> --
> http://kisskb.ellerman.id.au/kisskb/buildresult/7194502/
> http://kisskb.ellerman.id.au/kisskb/buildresult/7194476/
> ---
> drivers/misc/altera-stapl/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/misc/altera-stapl/Kconfig b/drivers/misc/altera-stapl/Kconfig
> index 7f01d8e..c7e4c77 100644
> --- a/drivers/misc/altera-stapl/Kconfig
> +++ b/drivers/misc/altera-stapl/Kconfig
> @@ -2,7 +2,7 @@ comment "Altera FPGA firmware download module"
>
> config ALTERA_STAPL
> tristate "Altera FPGA firmware download module"
> - depends on I2C
> + depends on I2C && HAS_IOPORT
> default n
> help
> An Altera FPGA module. Say Y when you want to support this tool.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-16 19:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-16 9:21 [PATCH -next] [media] altera-stapl should depend on HAS_IOPORT Geert Uytterhoeven
2012-09-16 10:07 ` Jean Delvare
[not found] ` <1347787283-11994-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2012-09-16 19:00 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).