* Re: [PATCH] slub: prefetch next freelist pointer in slab_alloc()
[not found] ` <alpine.LFD.2.02.1201242152480.1658@tux.localdomain>
@ 2012-01-30 21:32 ` Geert Uytterhoeven
2012-01-30 21:53 ` Christoph Lameter
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2012-01-30 21:32 UTC (permalink / raw)
To: Pekka Enberg
Cc: Christoph Lameter, Eric Dumazet, linux-kernel, David Rientjes,
Alex,Shi, Shaohua Li, Matt Mackall, Linux-Next
On Tue, Jan 24, 2012 at 20:54, Pekka Enberg <penberg@kernel.org> wrote:
> On Fri, 16 Dec 2011, Eric Dumazet wrote:
>>> Recycling a page is a problem, since freelist link chain is hot on
>>> cpu(s) which freed objects, and possibly very cold on cpu currently
>>> owning slab.
>
> On Fri, 16 Dec 2011, Christoph Lameter wrote:
>> Good idea. How do the tcp benchmarks look after this?
>>
>> Looks sane.
>>
>> Acked-by: Christoph Lameter <cl@linux.com>
>
> Applied, thanks!
m68k/allmodconfig at http://kisskb.ellerman.id.au/kisskb/buildresult/5527349/
mm/slub.c:274: error: implicit declaration of function 'prefetch'
Sorry, didn't notice it earlier due to other build breakage in -next.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] slub: prefetch next freelist pointer in slab_alloc()
2012-01-30 21:32 ` [PATCH] slub: prefetch next freelist pointer in slab_alloc() Geert Uytterhoeven
@ 2012-01-30 21:53 ` Christoph Lameter
2012-02-09 20:00 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Lameter @ 2012-01-30 21:53 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Pekka Enberg, Eric Dumazet, linux-kernel, David Rientjes,
Alex,Shi, Shaohua Li, Matt Mackall, Linux-Next
On Mon, 30 Jan 2012, Geert Uytterhoeven wrote:
> On Tue, Jan 24, 2012 at 20:54, Pekka Enberg <penberg@kernel.org> wrote:
> > On Fri, 16 Dec 2011, Eric Dumazet wrote:
> >>> Recycling a page is a problem, since freelist link chain is hot on
> >>> cpu(s) which freed objects, and possibly very cold on cpu currently
> >>> owning slab.
> >
> > On Fri, 16 Dec 2011, Christoph Lameter wrote:
> >> Good idea. How do the tcp benchmarks look after this?
> >>
> >> Looks sane.
> >>
> >> Acked-by: Christoph Lameter <cl@linux.com>
> >
> > Applied, thanks!
>
> m68k/allmodconfig at http://kisskb.ellerman.id.au/kisskb/buildresult/5527349/
>
> mm/slub.c:274: error: implicit declaration of function 'prefetch'
>
> Sorry, didn't notice it earlier due to other build breakage in -next.
Does this fix it?
Subject: slub: include include for prefetch
Otherwise m68k breaks.
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Christoph Lameter <cl@linux.com>
---
mm/slub.c | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6/mm/slub.c
===================================================================
--- linux-2.6.orig/mm/slub.c 2012-01-13 10:04:06.000000000 -0600
+++ linux-2.6/mm/slub.c 2012-01-30 15:51:55.000000000 -0600
@@ -29,6 +29,7 @@
#include <linux/math64.h>
#include <linux/fault-inject.h>
#include <linux/stacktrace.h>
+#include <linux/prefetch.h>
#include <trace/events/kmem.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] slub: prefetch next freelist pointer in slab_alloc()
2012-01-30 21:53 ` Christoph Lameter
@ 2012-02-09 20:00 ` Geert Uytterhoeven
0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2012-02-09 20:00 UTC (permalink / raw)
To: Christoph Lameter
Cc: Pekka Enberg, Eric Dumazet, linux-kernel, David Rientjes,
Alex,Shi, Shaohua Li, Matt Mackall, Linux-Next
On Mon, Jan 30, 2012 at 22:53, Christoph Lameter <cl@linux.com> wrote:
> On Mon, 30 Jan 2012, Geert Uytterhoeven wrote:
>> m68k/allmodconfig at http://kisskb.ellerman.id.au/kisskb/buildresult/5527349/
>>
>> mm/slub.c:274: error: implicit declaration of function 'prefetch'
>>
>> Sorry, didn't notice it earlier due to other build breakage in -next.
>
> Does this fix it?
Yep. Thx!
> Subject: slub: include include for prefetch
>
> Otherwise m68k breaks.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Christoph Lameter <cl@linux.com>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> mm/slub.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-2.6/mm/slub.c
> ===================================================================
> --- linux-2.6.orig/mm/slub.c 2012-01-13 10:04:06.000000000 -0600
> +++ linux-2.6/mm/slub.c 2012-01-30 15:51:55.000000000 -0600
> @@ -29,6 +29,7 @@
> #include <linux/math64.h>
> #include <linux/fault-inject.h>
> #include <linux/stacktrace.h>
> +#include <linux/prefetch.h>
>
> #include <trace/events/kmem.h>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-09 20:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1324049134.25554.29.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
[not found] ` <alpine.DEB.2.00.1112161030270.26651@router.home>
[not found] ` <alpine.LFD.2.02.1201242152480.1658@tux.localdomain>
2012-01-30 21:32 ` [PATCH] slub: prefetch next freelist pointer in slab_alloc() Geert Uytterhoeven
2012-01-30 21:53 ` Christoph Lameter
2012-02-09 20:00 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).