* Re: [PATCH 1/2] fault-inject: allow configuration via configfs [not found] ` <20230327143733.14599-2-akinobu.mita@gmail.com> @ 2023-04-15 14:53 ` Geert Uytterhoeven 2023-04-15 16:50 ` Akinobu Mita 0 siblings, 1 reply; 2+ messages in thread From: Geert Uytterhoeven @ 2023-04-15 14:53 UTC (permalink / raw) To: Akinobu Mita; +Cc: linux-kernel, linux-block, akpm, axboe, Linux-Next Hi Mita-san, On Mon, Mar 27, 2023 at 4:48 PM Akinobu Mita <akinobu.mita@gmail.com> wrote: > This provides a helper function to allow configuration of fault-injection > for configfs-based drivers. > > The config items created by this function have the same interface as the > one created under debugfs by fault_create_debugfs_attr(). > > Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Thanks for your patch, which is now commit 4668c7a2940d134b ("fault-inject: allow configuration via configfs") in linux-next (to be tagged soon as next-20140414). > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -1977,9 +1977,20 @@ config FAIL_SUNRPC > Provide fault-injection capability for SunRPC and > its consumers. > > +config FAULT_INJECTION_CONFIGFS > + bool "Configfs interface for fault-injection capabilities" > + depends on FAULT_INJECTION && CONFIGFS_FS noreply@ellerman.id.au reported build failures for e.g. m68k-allmodconfig http://kisskb.ellerman.id.au/kisskb/buildresult/14911188/: fault-inject.c:(.text+0x1ee): undefined reference to `config_group_init_type_name' This fails because FAULT_INJECTION=y but CONFIGFS_FS=m. > + help > + This option allows configfs-based drivers to dynamically configure > + fault-injection via configfs. Each parameter for driver-specific > + fault-injection can be made visible as a configfs attribute in a > + configfs group. > + > + Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] fault-inject: allow configuration via configfs 2023-04-15 14:53 ` [PATCH 1/2] fault-inject: allow configuration via configfs Geert Uytterhoeven @ 2023-04-15 16:50 ` Akinobu Mita 0 siblings, 0 replies; 2+ messages in thread From: Akinobu Mita @ 2023-04-15 16:50 UTC (permalink / raw) To: Geert Uytterhoeven; +Cc: linux-kernel, linux-block, akpm, axboe, Linux-Next 2023年4月15日(土) 23:53 Geert Uytterhoeven <geert@linux-m68k.org>: > > Hi Mita-san, > > On Mon, Mar 27, 2023 at 4:48 PM Akinobu Mita <akinobu.mita@gmail.com> wrote: > > This provides a helper function to allow configuration of fault-injection > > for configfs-based drivers. > > > > The config items created by this function have the same interface as the > > one created under debugfs by fault_create_debugfs_attr(). > > > > Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> > > Thanks for your patch, which is now commit 4668c7a2940d134b > ("fault-inject: allow configuration via configfs") in linux-next > (to be tagged soon as next-20140414). > > > --- a/lib/Kconfig.debug > > +++ b/lib/Kconfig.debug > > @@ -1977,9 +1977,20 @@ config FAIL_SUNRPC > > Provide fault-injection capability for SunRPC and > > its consumers. > > > > +config FAULT_INJECTION_CONFIGFS > > + bool "Configfs interface for fault-injection capabilities" > > + depends on FAULT_INJECTION && CONFIGFS_FS > > noreply@ellerman.id.au reported build failures for e.g. m68k-allmodconfig > http://kisskb.ellerman.id.au/kisskb/buildresult/14911188/: > > fault-inject.c:(.text+0x1ee): undefined reference to > `config_group_init_type_name' > > This fails because FAULT_INJECTION=y but CONFIGFS_FS=m. Oh, I just sent that build fix patch. https://lore.kernel.org/all/20230415125705.180426-1-akinobu.mita@gmail.com/ Could you please check if this is the correct way to fix it? ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-15 16:51 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20230327143733.14599-1-akinobu.mita@gmail.com> [not found] ` <20230327143733.14599-2-akinobu.mita@gmail.com> 2023-04-15 14:53 ` [PATCH 1/2] fault-inject: allow configuration via configfs Geert Uytterhoeven 2023-04-15 16:50 ` Akinobu Mita
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).