* linux-next: Fixes tag needs some work in the nvdimm-fixes tree
@ 2019-04-09 21:15 Stephen Rothwell
2019-04-09 21:59 ` Dan Williams
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2019-04-09 21:15 UTC (permalink / raw)
To: Dan Williams
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Dave Jiang
[-- Attachment #1: Type: text/plain, Size: 449 bytes --]
Hi Dan,
In commit
631804370762 ("tools/testing/nvdimm: Retain security state after overwrite")
Fixes tag
Fixes: 926f74802cb ("tools/testing/nvdimm: Add overwrite support for nfit_test")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Fixes tag needs some work in the nvdimm-fixes tree
2019-04-09 21:15 linux-next: Fixes tag needs some work in the nvdimm-fixes tree Stephen Rothwell
@ 2019-04-09 21:59 ` Dan Williams
0 siblings, 0 replies; 6+ messages in thread
From: Dan Williams @ 2019-04-09 21:59 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Dave Jiang
Dang it. should have validated that more people weren't following that
bad example.
Sorry for the noise.
On Tue, Apr 9, 2019 at 2:16 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Dan,
>
> In commit
>
> 631804370762 ("tools/testing/nvdimm: Retain security state after overwrite")
>
> Fixes tag
>
> Fixes: 926f74802cb ("tools/testing/nvdimm: Add overwrite support for nfit_test")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Fixes tag needs some work in the nvdimm-fixes tree
2019-08-29 22:08 Stephen Rothwell
@ 2019-08-29 22:45 ` Dan Williams
0 siblings, 0 replies; 6+ messages in thread
From: Dan Williams @ 2019-08-29 22:45 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jeff Moyer
On Thu, Aug 29, 2019 at 3:09 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
> dcbce3cd20be ("libnvdimm/pfn: Fix namespace creation on misaligned addresses")
>
> Fixes tag
>
> Fixes: commit a3619190d62e ("libnvdimm/pfn: stop padding pmem namespaces ...")
>
> has these problem(s):
>
> - leading word 'commit' unexpected
"Fixes" fixed, thanks Stephen.
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: Fixes tag needs some work in the nvdimm-fixes tree
@ 2019-08-29 22:08 Stephen Rothwell
2019-08-29 22:45 ` Dan Williams
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2019-08-29 22:08 UTC (permalink / raw)
To: Dan Williams
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jeff Moyer
[-- Attachment #1: Type: text/plain, Size: 302 bytes --]
Hi all,
In commit
dcbce3cd20be ("libnvdimm/pfn: Fix namespace creation on misaligned addresses")
Fixes tag
Fixes: commit a3619190d62e ("libnvdimm/pfn: stop padding pmem namespaces ...")
has these problem(s):
- leading word 'commit' unexpected
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Fixes tag needs some work in the nvdimm-fixes tree
2019-04-08 5:52 Stephen Rothwell
@ 2019-04-08 15:08 ` Dan Williams
0 siblings, 0 replies; 6+ messages in thread
From: Dan Williams @ 2019-04-08 15:08 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Li RongQing,
Liang ZhiCheng
On Sun, Apr 7, 2019 at 10:53 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Dan,
>
> In commit
>
> 7c33bd4e3e97 ("libnvdimm/pmem: fix a possible OOB access when read and write pmem")
>
> Fixes tag
>
> Fixes: 98cc093cba1e "(block, THP: make block_device_operations.rw_page support THP)"
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
Thanks for the heads up Stephen, will get this fixed.
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: Fixes tag needs some work in the nvdimm-fixes tree
@ 2019-04-08 5:52 Stephen Rothwell
2019-04-08 15:08 ` Dan Williams
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2019-04-08 5:52 UTC (permalink / raw)
To: Dan Williams
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Li RongQing,
Liang ZhiCheng
[-- Attachment #1: Type: text/plain, Size: 380 bytes --]
Hi Dan,
In commit
7c33bd4e3e97 ("libnvdimm/pmem: fix a possible OOB access when read and write pmem")
Fixes tag
Fixes: 98cc093cba1e "(block, THP: make block_device_operations.rw_page support THP)"
has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-08-29 22:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-09 21:15 linux-next: Fixes tag needs some work in the nvdimm-fixes tree Stephen Rothwell
2019-04-09 21:59 ` Dan Williams
-- strict thread matches above, loose matches on Subject: below --
2019-08-29 22:08 Stephen Rothwell
2019-08-29 22:45 ` Dan Williams
2019-04-08 5:52 Stephen Rothwell
2019-04-08 15:08 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).