From: Dominique Martinet <asmadeus@codewreck.org>
To: Christian Schoenebeck <linux_oss@crudebyte.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the v9fs tree
Date: Sat, 10 Dec 2022 06:24:26 +0900 [thread overview]
Message-ID: <Y5OnimhNCFGVYvrq@codewreck.org> (raw)
In-Reply-To: <3078112.XLg7Fjt2ba@silver>
Christian Schoenebeck wrote on Fri, Dec 09, 2022 at 03:40:06PM +0100:
> > > You remember updating the 1st patch as well, right? :)
> >
> > It looks up to date to me, e.g. zc is added at the end of the p9_fcall
> > structure.
> > (and these are the only two patches you sent, right? :D)
>
> Mmm, that's the queued patch I see:
> https://github.com/martinetd/linux/commit/298468c26c14682a5be80a6ec1b4880c8eb3b261
>
> Which is v1 ('zc' is not at the end of the structure, and in v1 there were
> multiple assignment in the same line like:
>
> req->tc.zc = req->rc.zc = false;
>
> which caused code style checker to bark (as well as on the commit log which it
> found too short). So in v2 it is:
>
> req->tc.zc = false;
> req->rc.zc = false;
>
> And yes, only two patches. :)
Ah. . . what did I just say about applying patches in my local branch
for testing later, they correct one is just sitting there but wasn't
tested/pushed yet :/
(if you care, I'm using my 9p-test branch for that, but it's not sent
sent to -next obviously)
> Well, workflows are quite different. Personally I always manually reply to
> mailed patches once I queued them, so that people can verify and correct me in
> case I queued the wrong ones. I never had the feeling to script that part.
Yes I usually do write a note about it when I take the patch locally,
but in this case I think I just applied the patches for checkpatch
(indentation looked off without being sure it'd complain) and didn't
intend to queue it; then came back later and "oh they're here, thanks
past me!" (incorrectly)
I guess at this point the problem comes back down to not running
tests/pushing to next immediately; if I finish automating that part I
think this kind of errors wouldn't happen as non-pushed patches wouldn't
make sense...
Well, it's been rare enough but still worth thinking about safeguards
imo, there's usually a reason for v2 patchs so getting the v1 in even
occasionally is bad :-D
--
Dominique
next prev parent reply other threads:[~2022-12-09 21:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 4:03 linux-next: build failure after merge of the v9fs tree Stephen Rothwell
2022-12-05 4:10 ` Dominique Martinet
2022-12-05 4:55 ` Stephen Rothwell
2022-12-05 14:31 ` Christian Schoenebeck
2022-12-05 20:40 ` Christian Schoenebeck
2022-12-05 22:41 ` Dominique Martinet
2022-12-08 15:55 ` Christian Schoenebeck
2022-12-08 23:53 ` Dominique Martinet
2022-12-09 14:40 ` Christian Schoenebeck
2022-12-09 21:24 ` Dominique Martinet [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-07-13 1:02 Stephen Rothwell
2022-07-13 1:06 ` Dominique Martinet
2011-12-01 1:02 Stephen Rothwell
2011-12-01 16:57 ` Joe Perches
2011-02-22 0:53 Stephen Rothwell
2011-02-22 5:20 ` Venkateswararao Jujjuri (JV)
2011-02-22 5:30 ` Stephen Rothwell
2011-02-22 6:22 ` Venkateswararao Jujjuri (JV)
2011-02-22 14:57 ` Eric Van Hensbergen
2011-02-22 16:48 ` Venkateswararao Jujjuri (JV)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5OnimhNCFGVYvrq@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).