linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roman Gushchin <guro@fb.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Tejun Heo <tj@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the cgroup tree
Date: Mon, 10 May 2021 18:10:36 -0700	[thread overview]
Message-ID: <YJnZjCXe7uPrJxFo@carbon.DHCP.thefacebook.com> (raw)
In-Reply-To: <20210511105114.55e90534@canb.auug.org.au>

On Tue, May 11, 2021 at 10:51:14AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the cgroup tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:

Hi Stephen!

I've noticed this error and sent v2 almost immediately after the first version,
however it looks like the first version got merged by a mistake.

Tejun, can you, please, drop the first version and replace it with v2?
There is a trivial s/task/tsk fix.

Thank you and sorry for the confusion!

Roman

> 
> In file included from include/linux/string.h:6,
> In file included from include/linux/string.h:6,
>                  from arch/powerpc/include/asm/paca.h:15,
>                  from arch/powerpc/include/asm/current.h:13,
>                  from include/linux/sched.h:12,
>                  from include/linux/cgroup.h:12,
>                  from kernel/cgroup/cgroup-internal.h:5,
>                  from kernel/cgroup/cgroup.c:31:
> kernel/cgroup/cgroup.c: In function 'cgroup_exit':
> kernel/cgroup/cgroup.c:6270:17: error: 'task' undeclared (first use in this function); did you mean 'tsk'?
>  6270 |  if (unlikely(!(task->flags & PF_KTHREAD) &&
>       |                 ^~~~
> include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
>    78 | # define unlikely(x) __builtin_expect(!!(x), 0)
>       |                                          ^
> kernel/cgroup/cgroup.c:6270:17: note: each undeclared identifier is reported only once for each function it appears in
>  6270 |  if (unlikely(!(task->flags & PF_KTHREAD) &&
>       |                 ^~~~
> include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
>    78 | # define unlikely(x) __builtin_expect(!!(x), 0)
>       |                                          ^
> 
> Caused by commit
> 
>   c740aad01e41 ("cgroup: inline cgroup_task_freeze()")
> 
> I have used the cgroup tree from next-20210510 for today.
> 
> -- 
> Cheers,
> Stephen Rothwell



  reply	other threads:[~2021-05-11  1:10 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11  0:51 linux-next: build failure after merge of the cgroup tree Stephen Rothwell
2021-05-11  1:10 ` Roman Gushchin [this message]
2021-05-11  1:31   ` Tejun Heo
  -- strict thread matches above, loose matches on Subject: below --
2023-12-07  3:38 Stephen Rothwell
2023-12-07  4:18 ` Waiman Long
2023-07-17  1:34 Stephen Rothwell
2023-07-17  6:45 ` Miaohe Lin
2022-10-31  2:23 Stephen Rothwell
2022-10-31 17:52 ` Tejun Heo
2022-09-12  6:18 Stephen Rothwell
2022-09-12  7:38 ` Peter Zijlstra
2022-09-12 18:44   ` Tejun Heo
2022-09-12 22:16     ` Tejun Heo
2022-09-15 10:46       ` Peter Zijlstra
2022-10-10 20:57 ` Stephen Rothwell
2022-10-10 20:59   ` Tejun Heo
2022-08-29  3:29 Stephen Rothwell
2021-04-22  6:31 Stephen Rothwell
2015-09-25  3:26 Stephen Rothwell
2014-02-26  6:46 Stephen Rothwell
2014-02-26 13:44 ` Tejun Heo
2013-04-29  4:04 Stephen Rothwell
2013-04-29 22:55 ` Tejun Heo
2013-04-30  1:51   ` Benjamin Herrenschmidt
2012-09-14  3:17 Stephen Rothwell
2012-09-14  6:56 ` Daniel Wagner
2012-09-14 17:00   ` Tejun Heo
2012-09-14 18:32     ` Sedat Dilek
2012-09-14 18:34       ` Tejun Heo
2012-09-15  7:55         ` Sedat Dilek
2011-11-25  3:50 Stephen Rothwell
2011-11-27 19:33 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJnZjCXe7uPrJxFo@carbon.DHCP.thefacebook.com \
    --to=guro@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).