From: Miaohe Lin <linmiaohe@huawei.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Tejun Heo <tj@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: Josh Don <joshdon@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the cgroup tree
Date: Mon, 17 Jul 2023 14:45:56 +0800 [thread overview]
Message-ID: <d9d7faf1-8add-e3f3-75ac-64c7069c4ec8@huawei.com> (raw)
In-Reply-To: <20230717113457.527d7483@canb.auug.org.au>
On 2023/7/17 9:34, Stephen Rothwell wrote:
> Hi all,
>
> After merging the cgroup tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> kernel/cgroup/cgroup.c: In function 'cgroup_local_stat_show':
> kernel/cgroup/cgroup.c:3699:15: error: implicit declaration of function 'cgroup_tryget_css'; did you mean 'cgroup_tryget'? [-Werror=implicit-function-declaration]
> 3699 | css = cgroup_tryget_css(cgrp, ss);
> | ^~~~~~~~~~~~~~~~~
> | cgroup_tryget
> kernel/cgroup/cgroup.c:3699:13: warning: assignment to 'struct cgroup_subsys_state *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
> 3699 | css = cgroup_tryget_css(cgrp, ss);
> | ^
>
> Caused by commit
>
> d1d4ff5d11a5 ("cgroup: put cgroup_tryget_css() inside CONFIG_CGROUP_SCHED")
>
> interacting with commit
>
> 677ea015f231 ("sched: add throttled time stat for throttled children")
>
> from the tip tree.
>
> I have reverted commit d1d4ff5d11a5 for today.
677ea015f231 ("sched: add throttled time stat for throttled children") use the cgroup_tryget_css again. So I will
re-clean the relevant codes later.
Thanks all.
next prev parent reply other threads:[~2023-07-17 6:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 1:34 linux-next: build failure after merge of the cgroup tree Stephen Rothwell
2023-07-17 6:45 ` Miaohe Lin [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-12-07 3:38 Stephen Rothwell
2023-12-07 4:18 ` Waiman Long
2022-10-31 2:23 Stephen Rothwell
2022-10-31 17:52 ` Tejun Heo
2022-09-12 6:18 Stephen Rothwell
2022-09-12 7:38 ` Peter Zijlstra
2022-09-12 18:44 ` Tejun Heo
2022-09-12 22:16 ` Tejun Heo
2022-09-15 10:46 ` Peter Zijlstra
2022-10-10 20:57 ` Stephen Rothwell
2022-10-10 20:59 ` Tejun Heo
2022-08-29 3:29 Stephen Rothwell
2021-05-11 0:51 Stephen Rothwell
2021-05-11 1:10 ` Roman Gushchin
2021-05-11 1:31 ` Tejun Heo
2021-04-22 6:31 Stephen Rothwell
2015-09-25 3:26 Stephen Rothwell
2014-02-26 6:46 Stephen Rothwell
2014-02-26 13:44 ` Tejun Heo
2013-04-29 4:04 Stephen Rothwell
2013-04-29 22:55 ` Tejun Heo
2013-04-30 1:51 ` Benjamin Herrenschmidt
2012-09-14 3:17 Stephen Rothwell
2012-09-14 6:56 ` Daniel Wagner
2012-09-14 17:00 ` Tejun Heo
2012-09-14 18:32 ` Sedat Dilek
2012-09-14 18:34 ` Tejun Heo
2012-09-15 7:55 ` Sedat Dilek
2011-11-25 3:50 Stephen Rothwell
2011-11-27 19:33 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9d7faf1-8add-e3f3-75ac-64c7069c4ec8@huawei.com \
--to=linmiaohe@huawei.com \
--cc=hpa@zytor.com \
--cc=joshdon@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).