linux-next: Fixes tag needs some work in the input-current tree

linux-next: Fixes tag needs some work in the input-current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

Hi all,

In commit

  feee70f45686 ("Input: xpad - delete a Razer DeathAdder mouse VID/PID entry")

Fixes tag

  Fixes: f554f619b70 ("Input: xpad - sync device IDs with xboxdrv")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the input-current tree

[Dmitry Torokhov]

On Wed, May 24, 2023 at 08:12:00AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   feee70f45686 ("Input: xpad - delete a Razer DeathAdder mouse VID/PID entry")
> 
> Fixes tag
> 
>   Fixes: f554f619b70 ("Input: xpad - sync device IDs with xboxdrv")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     This can be fixed for the future by setting core.abbrev to 12 (or
>     more) or (for git v2.11 or later) just making sure it is not set
>     (or set to "auto").

Oops. Oh, well. I do not rewind my for-linus branch unless in extreme
circumstances, so it will have to stay this way. The tag still resolves
to the right commit, so not much harm done.

Thanks.

-- 
Dmitry

linux-next: Fixes tag needs some work in the input-current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

Hi Dmitry,

In commit

  3a349763cf11 ("Input: synaptics-rmi4 - write config register values to the right offset")

Fixes tag

  Fixes: ff8f83708b3e (Input: synaptics-rmi4 - add support for 2D

has these problem(s):

  - Subject has leading but no trailing parentheses

Please do not split Fixes tags across more than one line.  Just use:

  git log -1 --format='Fixes: %h ("%s")' <commit>

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the input-current tree

[Lubomir Rintel]

On Fri, 2019-01-25 at 15:58 -0800, Dmitry Torokhov wrote:
> On Fri, Jan 25, 2019 at 3:56 PM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > Hi Stephen,
> > 
> > On Thu, Jan 24, 2019 at 3:09 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > Hi Dmitry,
> > > 
> > > In commit
> > > 
> > >   ec87da107d11 ("Input: olpc_apsp - assign priv->dev earlier")
> > > 
> > > Fixes tag
> > > 
> > >   Fixes: commit af518342effd ("Input: olpc_apsp - check FIFO status on open(), not probe()")
> > > 
> > > has these problem(s):
> > > 
> > >   - No SHA1 recognised
> > > 
> > > The "commit" at the start of the tag value was unexpected.
> > 
> > Hmm, this is really weird:
> > 
> > dtor@dtor-ws:~/kernel/master (for-linus)$ git log --oneline --
> > drivers/input/serio/olpc_apsp.c
> > ec87da107d11 Input: olpc_apsp - assign priv->dev earlier
> > 2a58dd767bf9 Input: olpc_apsp - remove set but not used variable 'np'
> > ed22cee91a88 Input: olpc_apsp - enable the SP clock
> > af518342effd Input: olpc_apsp - check FIFO status on open(), not probe()
> > 
> > As you can see there is that SHA1 in question present in my for-linus branch.
> 
> Argh, I see what you mean, the word "commit" should be omitted. Oh
> well, it's in the branch that I loath to rebase, so it will have to
> stay as is.

Sorry for this. I included the word "commit" because checkpatch.pl
actually complains when it's missing when a commit is referenced
outside the tags in the commit message.

I actually did a quick search for /Fixes: commit/ in the git log at the
time, but apparently it's a common mistake to make...

Perhaps I can see if I can teach checkpatch.pl to warn about this in
future.

Lubo

Re: linux-next: Fixes tag needs some work in the input-current tree

[Dmitry Torokhov]

On Fri, Jan 25, 2019 at 3:56 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> Hi Stephen,
>
> On Thu, Jan 24, 2019 at 3:09 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi Dmitry,
> >
> > In commit
> >
> >   ec87da107d11 ("Input: olpc_apsp - assign priv->dev earlier")
> >
> > Fixes tag
> >
> >   Fixes: commit af518342effd ("Input: olpc_apsp - check FIFO status on open(), not probe()")
> >
> > has these problem(s):
> >
> >   - No SHA1 recognised
> >
> > The "commit" at the start of the tag value was unexpected.
>
> Hmm, this is really weird:
>
> dtor@dtor-ws:~/kernel/master (for-linus)$ git log --oneline --
> drivers/input/serio/olpc_apsp.c
> ec87da107d11 Input: olpc_apsp - assign priv->dev earlier
> 2a58dd767bf9 Input: olpc_apsp - remove set but not used variable 'np'
> ed22cee91a88 Input: olpc_apsp - enable the SP clock
> af518342effd Input: olpc_apsp - check FIFO status on open(), not probe()
>
> As you can see there is that SHA1 in question present in my for-linus branch.

Argh, I see what you mean, the word "commit" should be omitted. Oh
well, it's in the branch that I loath to rebase, so it will have to
stay as is.

-- 
Dmitry

Re: linux-next: Fixes tag needs some work in the input-current tree

[Dmitry Torokhov]

Hi Stephen,

On Thu, Jan 24, 2019 at 3:09 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Dmitry,
>
> In commit
>
>   ec87da107d11 ("Input: olpc_apsp - assign priv->dev earlier")
>
> Fixes tag
>
>   Fixes: commit af518342effd ("Input: olpc_apsp - check FIFO status on open(), not probe()")
>
> has these problem(s):
>
>   - No SHA1 recognised
>
> The "commit" at the start of the tag value was unexpected.

Hmm, this is really weird:

dtor@dtor-ws:~/kernel/master (for-linus)$ git log --oneline --
drivers/input/serio/olpc_apsp.c
ec87da107d11 Input: olpc_apsp - assign priv->dev earlier
2a58dd767bf9 Input: olpc_apsp - remove set but not used variable 'np'
ed22cee91a88 Input: olpc_apsp - enable the SP clock
af518342effd Input: olpc_apsp - check FIFO status on open(), not probe()

As you can see there is that SHA1 in question present in my for-linus branch.

Thanks.

-- 
Dmitry

linux-next: Fixes tag needs some work in the input-current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

Hi Dmitry,

In commit

  ec87da107d11 ("Input: olpc_apsp - assign priv->dev earlier")

Fixes tag

  Fixes: commit af518342effd ("Input: olpc_apsp - check FIFO status on open(), not probe()")

has these problem(s):

  - No SHA1 recognised

The "commit" at the start of the tag value was unexpected.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]