* arc-elf32-ld: net/xfrm/xfrm_algo.o:(.rodata+0x24): undefined reference to `crypto_has_aead'
@ 2023-09-29 7:11 Naresh Kamboju
2023-09-29 13:20 ` Sabrina Dubroca
0 siblings, 1 reply; 3+ messages in thread
From: Naresh Kamboju @ 2023-09-29 7:11 UTC (permalink / raw)
To: Linux-Next Mailing List, Netdev, linux-snps-arc
Cc: Paolo Abeni, Jakub Kicinski, David S. Miller, Eric Dumazet
The arc defconfig builds failed on Linux next from Sept 22.
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Build log:
-----------
arc-elf32-ld: net/xfrm/xfrm_algo.o:(.rodata+0x24): undefined reference
to `crypto_has_aead'
arc-elf32-ld: net/xfrm/xfrm_algo.o:(.rodata+0x24): undefined reference
to `crypto_has_aead'
make[3]: *** [/builds/linux/scripts/Makefile.vmlinux:36: vmlinux] Error 1
make[3]: Target '__default' not remade because of errors.
Links:
- https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230928/testrun/20145384/suite/build/test/gcc-9-defconfig/log
- https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230928/testrun/20145384/suite/build/test/gcc-9-defconfig/history/
- https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230928/testrun/20145384/suite/build/test/gcc-9-defconfig/details/
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: arc-elf32-ld: net/xfrm/xfrm_algo.o:(.rodata+0x24): undefined reference to `crypto_has_aead'
2023-09-29 7:11 arc-elf32-ld: net/xfrm/xfrm_algo.o:(.rodata+0x24): undefined reference to `crypto_has_aead' Naresh Kamboju
@ 2023-09-29 13:20 ` Sabrina Dubroca
2023-10-01 7:30 ` Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: Sabrina Dubroca @ 2023-09-29 13:20 UTC (permalink / raw)
To: Naresh Kamboju, Herbert Xu
Cc: Linux-Next Mailing List, Netdev, linux-snps-arc, Paolo Abeni,
Jakub Kicinski, David S. Miller, Eric Dumazet
2023-09-29, 12:41:51 +0530, Naresh Kamboju wrote:
> The arc defconfig builds failed on Linux next from Sept 22.
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> Build log:
> -----------
> arc-elf32-ld: net/xfrm/xfrm_algo.o:(.rodata+0x24): undefined reference
> to `crypto_has_aead'
> arc-elf32-ld: net/xfrm/xfrm_algo.o:(.rodata+0x24): undefined reference
> to `crypto_has_aead'
> make[3]: *** [/builds/linux/scripts/Makefile.vmlinux:36: vmlinux] Error 1
> make[3]: Target '__default' not remade because of errors.
Use of crypto_has_aead was added to net/xfrm/xfrm_algo.c in commit
a1383e2ab102 ("ipsec: Stop using crypto_has_alg").
I guess the problem is that CONFIG_XFRM_ALGO doesn't select
CONFIG_CRYPTO_AEAD (or _AEAD2?), just CRYPTO_HASH and CRYPTO_SKCIPHER.
Herbert, does that seem reasonable?
-------- 8< --------
diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig
index 3adf31a83a79..d7b16f2c23e9 100644
--- a/net/xfrm/Kconfig
+++ b/net/xfrm/Kconfig
@@ -15,6 +15,7 @@ config XFRM_ALGO
tristate
select XFRM
select CRYPTO
+ select CRYPTO_AEAD
select CRYPTO_HASH
select CRYPTO_SKCIPHER
--
Sabrina
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: arc-elf32-ld: net/xfrm/xfrm_algo.o:(.rodata+0x24): undefined reference to `crypto_has_aead'
2023-09-29 13:20 ` Sabrina Dubroca
@ 2023-10-01 7:30 ` Herbert Xu
0 siblings, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2023-10-01 7:30 UTC (permalink / raw)
To: Sabrina Dubroca
Cc: Naresh Kamboju, Linux-Next Mailing List, Netdev, linux-snps-arc,
Paolo Abeni, Jakub Kicinski, David S. Miller, Eric Dumazet
On Fri, Sep 29, 2023 at 03:20:05PM +0200, Sabrina Dubroca wrote:
>
> I guess the problem is that CONFIG_XFRM_ALGO doesn't select
> CONFIG_CRYPTO_AEAD (or _AEAD2?), just CRYPTO_HASH and CRYPTO_SKCIPHER.
>
> Herbert, does that seem reasonable?
Sorry Sabrina, this patch is already in my queue but I forgot to
push it out. I'll get onto it now.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-01 7:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-29 7:11 arc-elf32-ld: net/xfrm/xfrm_algo.o:(.rodata+0x24): undefined reference to `crypto_has_aead' Naresh Kamboju
2023-09-29 13:20 ` Sabrina Dubroca
2023-10-01 7:30 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).