linux-next: build failure after merge of the dmaengine tree

linux-next: build failure after merge of the dmaengine tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 711 bytes --]

Hi all,

After merging the dmaengine tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

ld: warning: discarding dynamic section .glink
ld: warning: discarding dynamic section .plt
ld: linkage table error against `ioread64'
ld: stubs don't match calculated size
ld: can not build stubs: bad value
ld: fs/debugfs/file.o: in function `debugfs_print_regs':
file.c:(.text+0xee8): undefined reference to `ioread64be'
ld: file.c:(.text+0xf50): undefined reference to `ioread64'

Caused by commit

  09289d0ad122 ("debugfs_create_regset32() support 8/16/64 bit width registers")

I have used the dmaengine tree from next-20230928 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the dmaengine tree

[Vinod Koul]

On 29-09-23, 13:13, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the dmaengine tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> ld: warning: discarding dynamic section .glink
> ld: warning: discarding dynamic section .plt
> ld: linkage table error against `ioread64'
> ld: stubs don't match calculated size
> ld: can not build stubs: bad value
> ld: fs/debugfs/file.o: in function `debugfs_print_regs':
> file.c:(.text+0xee8): undefined reference to `ioread64be'
> ld: file.c:(.text+0xf50): undefined reference to `ioread64'
> 
> Caused by commit
> 
>   09289d0ad122 ("debugfs_create_regset32() support 8/16/64 bit width registers")
> 
> I have used the dmaengine tree from next-20230928 for today.

Thanks for report, I have dropped offending commits for now.

BR
-- 
~Vinod

RE: [EXT] Re: linux-next: build failure after merge of the dmaengine tree

[Frank Li]

> -----Original Message-----
> From: Vinod Koul <vkoul@kernel.org>
> Sent: Monday, October 2, 2023 11:10 AM
> To: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Frank Li <frank.li@nxp.com>; Linux Kernel Mailing List <linux-
> kernel@vger.kernel.org>; Linux Next Mailing List <linux-next@vger.kernel.org>
> Subject: [EXT] Re: linux-next: build failure after merge of the dmaengine tree
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On 29-09-23, 13:13, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the dmaengine tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> >
> > ld: warning: discarding dynamic section .glink
> > ld: warning: discarding dynamic section .plt
> > ld: linkage table error against `ioread64'
> > ld: stubs don't match calculated size
> > ld: can not build stubs: bad value
> > ld: fs/debugfs/file.o: in function `debugfs_print_regs':
> > file.c:(.text+0xee8): undefined reference to `ioread64be'
> > ld: file.c:(.text+0xf50): undefined reference to `ioread64'
> >
> > Caused by commit
> >
> >   09289d0ad122 ("debugfs_create_regset32() support 8/16/64 bit width
> registers")
> >
> > I have used the dmaengine tree from next-20230928 for today.
> 
> Thanks for report, I have dropped offending commits for now.

Fixed patch already post at
https://lore.kernel.org/dmaengine/20231002145737.538934-1-Frank.Li@nxp.com/T/#u

Frank

> 
> BR
> --
> ~Vinod

Re: [EXT] Re: linux-next: build failure after merge of the dmaengine tree

[Vinod Koul]

Hello Frank,

On 02-10-23, 16:26, Frank Li wrote:
> > On 29-09-23, 13:13, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > After merging the dmaengine tree, today's linux-next build (powerpc
> > > ppc64_defconfig) failed like this:
> > >
> > > ld: warning: discarding dynamic section .glink
> > > ld: warning: discarding dynamic section .plt
> > > ld: linkage table error against `ioread64'
> > > ld: stubs don't match calculated size
> > > ld: can not build stubs: bad value
> > > ld: fs/debugfs/file.o: in function `debugfs_print_regs':
> > > file.c:(.text+0xee8): undefined reference to `ioread64be'
> > > ld: file.c:(.text+0xf50): undefined reference to `ioread64'
> > >
> > > Caused by commit
> > >
> > >   09289d0ad122 ("debugfs_create_regset32() support 8/16/64 bit width
> > registers")
> > >
> > > I have used the dmaengine tree from next-20230928 for today.
> > 
> > Thanks for report, I have dropped offending commits for now.
> 
> Fixed patch already post at
> https://lore.kernel.org/dmaengine/20231002145737.538934-1-Frank.Li@nxp.com/T/#u

I am not sure of this fix, someone has to pick this. let this get fixed
first and we can always pick back these patches.

My tree was broken meanwhile impacting others, so it was better to drop
for now.

Thanks for you understanding

-- 
~Vinod

Re: linux-next: build failure after merge of the dmaengine tree

[Vinod Koul]

On 11-10-23, 08:41, Rob Herring wrote:
> On Mon, Oct 9, 2023 at 10:54 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > After merging the dmaengine tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/dma/mmp_tdma.c: In function 'mmp_tdma_probe':
> > drivers/dma/mmp_tdma.c:638:36: error: unused variable 'of_id' [-Werror=unused-variable]
> >   638 |         const struct of_device_id *of_id;
> >       |                                    ^~~~~
> > cc1: all warnings being treated as errors
> >
> > Caused by commit
> >
> >   a67ba97dfb30 ("dmaengine: Use device_get_match_data()")
> 
> FWIW, my patch has the above line removed. Seems it got dropped when applying.

Looks like it got missed while applying the patch. The patch had a
conflict so I had to manually apply this one...

Sorry to have missed that

-- 
~Vinod

Re: linux-next: build failure after merge of the dmaengine tree

[Rob Herring]

On Mon, Oct 9, 2023 at 10:54 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the dmaengine tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/dma/mmp_tdma.c: In function 'mmp_tdma_probe':
> drivers/dma/mmp_tdma.c:638:36: error: unused variable 'of_id' [-Werror=unused-variable]
>   638 |         const struct of_device_id *of_id;
>       |                                    ^~~~~
> cc1: all warnings being treated as errors
>
> Caused by commit
>
>   a67ba97dfb30 ("dmaengine: Use device_get_match_data()")

FWIW, my patch has the above line removed. Seems it got dropped when applying.

Rob

Re: linux-next: build failure after merge of the dmaengine tree

[Vinod Koul]

On 10-10-23, 14:54, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the dmaengine tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/dma/mmp_tdma.c: In function 'mmp_tdma_probe':
> drivers/dma/mmp_tdma.c:638:36: error: unused variable 'of_id' [-Werror=unused-variable]
>   638 |         const struct of_device_id *of_id;
>       |                                    ^~~~~
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>   a67ba97dfb30 ("dmaengine: Use device_get_match_data()")
> 
> I have used the dmaengine tree from next-20231009 for today.

Thanks for the report, I have posted the fix:
https://lore.kernel.org/dmaengine/20231010065729.29385-1-vkoul@kernel.org/

-- 
~Vinod

linux-next: build failure after merge of the dmaengine tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

Hi all,

After merging the dmaengine tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/dma/mmp_tdma.c: In function 'mmp_tdma_probe':
drivers/dma/mmp_tdma.c:638:36: error: unused variable 'of_id' [-Werror=unused-variable]
  638 |         const struct of_device_id *of_id;
      |                                    ^~~~~
cc1: all warnings being treated as errors

Caused by commit

  a67ba97dfb30 ("dmaengine: Use device_get_match_data()")

I have used the dmaengine tree from next-20231009 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the dmaengine tree

[Vinod Koul]

On 10-06-22, 12:46, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the dmaengine tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> In file included from include/linux/printk.h:584,
>                  from include/linux/kernel.h:29,
>                  from arch/x86/include/asm/percpu.h:27,
>                  from arch/x86/include/asm/current.h:6,
>                  from include/linux/sched.h:12,
>                  from include/linux/ratelimit.h:6,
>                  from include/linux/dev_printk.h:16,
>                  from include/linux/device.h:15,
>                  from drivers/dma/apple-admac.c:10:
> drivers/dma/apple-admac.c: In function 'admac_cyclic_write_one_desc':
> drivers/dma/apple-admac.c:209:26: error: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'long unsigned int' [-Werror=format=]
>   209 |         dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%x\n",

Thanks for the report, I have fixed it up and send the patch to fix the
print format

https://lore.kernel.org/dmaengine/20220610043117.39337-1-vkoul@kernel.org/

-- 
~Vinod

linux-next: build failure after merge of the dmaengine tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2692 bytes --]

Hi all,

After merging the dmaengine tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from include/linux/printk.h:584,
                 from include/linux/kernel.h:29,
                 from arch/x86/include/asm/percpu.h:27,
                 from arch/x86/include/asm/current.h:6,
                 from include/linux/sched.h:12,
                 from include/linux/ratelimit.h:6,
                 from include/linux/dev_printk.h:16,
                 from include/linux/device.h:15,
                 from drivers/dma/apple-admac.c:10:
drivers/dma/apple-admac.c: In function 'admac_cyclic_write_one_desc':
drivers/dma/apple-admac.c:209:26: error: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'long unsigned int' [-Werror=format=]
  209 |         dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%x\n",
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
  134 |                 func(&id, ##__VA_ARGS__);               \
      |                             ^~~~~~~~~~~
include/linux/dynamic_debug.h:166:9: note: in expansion of macro '_dynamic_func_call'
  166 |         _dynamic_func_call(fmt,__dynamic_dev_dbg,               \
      |         ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
  155 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
      |         ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:30: note: in expansion of macro 'dev_fmt'
  155 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
      |                              ^~~~~~~
drivers/dma/apple-admac.c:209:9: note: in expansion of macro 'dev_dbg'
  209 |         dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%x\n",
      |         ^~~~~~~
drivers/dma/apple-admac.c:209:75: note: format string is defined here
  209 |         dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%x\n",
      |                                                                          ~^
      |                                                                           |
      |                                                                           unsigned int
      |                                                                          %lx
cc1: all warnings being treated as errors

Caused by commit

  b127315d9a78 ("dmaengine: apple-admac: Add Apple ADMAC driver")

I have used the dmaengine tree from next-20220609 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the dmaengine tree

[Vinod Koul]

On 26-10-21, 16:06, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the dmaengine tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> 
> Caused by commit
> 
>   981b43434b28 ("message: fusion: switch from 'pci_' to 'dma_' API")
> 
> I have used the dmaengine tree from next-20211025 for today.

Thanks Stephen,

I have fixed it up (dropped the offending commit, which should not
anyway go thru dmaengine tree)

-- 
~Vinod

Re: linux-next: build failure after merge of the dmaengine tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 3814 bytes --]

Hi all,

On Tue, 26 Oct 2021 16:06:57 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
> 
> After merging the dmaengine tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

drivers/message/fusion/mptbase.c: In function 'PrimeIocFifos':
drivers/message/fusion/mptbase.c:4446:35: error: passing argument 1 of 'dma_set_mask_and_coherent' from incompatible pointer type [-Werror=incompatible-pointer-types]
 4446 |    if (!dma_set_mask_and_coherent(&ioc->pcidev, DMA_BIT_MASK(32))) {
      |                                   ^~~~~~~~~~~~
      |                                   |
      |                                   struct pci_dev **
In file included from include/linux/pci-dma-compat.h:8,
                 from include/linux/pci.h:2443,
                 from drivers/message/fusion/mptbase.c:56:
include/linux/dma-mapping.h:442:60: note: expected 'struct device *' but argument is of type 'struct pci_dev **'
  442 | static inline int dma_set_mask_and_coherent(struct device *dev, u64 mask)
      |                                             ~~~~~~~~~~~~~~~^~~
drivers/message/fusion/mptbase.c:4454:31: error: passing argument 1 of 'dma_set_mask_and_coherent' from incompatible pointer type [-Werror=incompatible-pointer-types]
 4454 |     dma_set_mask_and_coherent(&ioc->pcidev, DMA_BIT_MASK(64));
      |                               ^~~~~~~~~~~~
      |                               |
      |                               struct pci_dev **
In file included from include/linux/pci-dma-compat.h:8,
                 from include/linux/pci.h:2443,
                 from drivers/message/fusion/mptbase.c:56:
include/linux/dma-mapping.h:442:60: note: expected 'struct device *' but argument is of type 'struct pci_dev **'
  442 | static inline int dma_set_mask_and_coherent(struct device *dev, u64 mask)
      |                                             ~~~~~~~~~~~~~~~^~~
drivers/message/fusion/mptbase.c:4590:33: error: passing argument 1 of 'dma_set_mask_and_coherent' from incompatible pointer type [-Werror=incompatible-pointer-types]
 4590 |      !dma_set_mask_and_coherent(&ioc->pcidev, ioc->dma_mask))
      |                                 ^~~~~~~~~~~~
      |                                 |
      |                                 struct pci_dev **
In file included from include/linux/pci-dma-compat.h:8,
                 from include/linux/pci.h:2443,
                 from drivers/message/fusion/mptbase.c:56:
include/linux/dma-mapping.h:442:60: note: expected 'struct device *' but argument is of type 'struct pci_dev **'
  442 | static inline int dma_set_mask_and_coherent(struct device *dev, u64 mask)
      |                                             ~~~~~~~~~~~~~~~^~~
drivers/message/fusion/mptbase.c:4614:33: error: passing argument 1 of 'dma_set_mask_and_coherent' from incompatible pointer type [-Werror=incompatible-pointer-types]
 4614 |      !dma_set_mask_and_coherent(&ioc->pcidev, DMA_BIT_MASK(64)))
      |                                 ^~~~~~~~~~~~
      |                                 |
      |                                 struct pci_dev **
In file included from include/linux/pci-dma-compat.h:8,
                 from include/linux/pci.h:2443,
                 from drivers/message/fusion/mptbase.c:56:
include/linux/dma-mapping.h:442:60: note: expected 'struct device *' but argument is of type 'struct pci_dev **'
  442 | static inline int dma_set_mask_and_coherent(struct device *dev, u64 mask)
      |                                             ~~~~~~~~~~~~~~~^~~

> Caused by commit
> 
>   981b43434b28 ("message: fusion: switch from 'pci_' to 'dma_' API")
> 
> I have used the dmaengine tree from next-20211025 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the dmaengine tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

Hi all,

After merging the dmaengine tree, today's linux-next build (x86_64
allmodconfig) failed like this:


Caused by commit

  981b43434b28 ("message: fusion: switch from 'pci_' to 'dma_' API")

I have used the dmaengine tree from next-20211025 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]