linux-next: build warning after merge of the workqueues tree

linux-next: build warning after merge of the workqueues tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

Hi all,

After merging the workqueues tree, today's linux-next build (x86_64
allnoconfig) produced this warning:

WARNING: unmet direct dependencies detected for IRQ_WORK
  Depends on [n]: SMP [=n]
  Selected by [y]:
  - PRINTK [=y]
  - PERF_EVENTS [=y] && HAVE_PERF_EVENTS [=y]

Other allnoconfig builds produced similar warnings.

Introduced by commit

  9d6efa8d0dd0 ("workqueue, irq_work: Build fix for !CONFIG_IRQ_WORK")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the workqueues tree

[Tejun Heo]

Hello,

On Fri, Feb 16, 2024 at 02:00:14PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the workqueues tree, today's linux-next build (x86_64
> allnoconfig) produced this warning:
> 
> WARNING: unmet direct dependencies detected for IRQ_WORK
>   Depends on [n]: SMP [=n]
>   Selected by [y]:
>   - PRINTK [=y]
>   - PERF_EVENTS [=y] && HAVE_PERF_EVENTS [=y]
> 
> Other allnoconfig builds produced similar warnings.
> 
> Introduced by commit
> 
>   9d6efa8d0dd0 ("workqueue, irq_work: Build fix for !CONFIG_IRQ_WORK")

Ah, sorry. I made it worse. I should have selected IRQ_WORK from SMP not
depend on it. Will update. Thank you.

-- 
tejun

Re: linux-next: build warning after merge of the workqueues tree

[Tejun Heo]

Hello,

I applied the following patch to wq/for-6.10.

The offending line wasn't introduced recently tho. It goes way back.
5797b1c18919 just touches the surrounding lines. Maybe that triggered
something?

Thanks.
------ 8< ------
From 51da7f68edae38e81543d57fd71811f7481c0472 Mon Sep 17 00:00:00 2001
From: Tejun Heo <tj@kernel.org>
Date: Mon, 22 Apr 2024 10:03:13 -1000
Subject: [PATCH] workqueue: Use "@..." in function comment to describe
 variable length argument

Previously, it was using "remaining args" without leading "@" which isn't
valid. Let's follow snprintf()'s example and use "@...".

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/workqueue.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
index 2df1188c0f96..fb3993894536 100644
--- a/include/linux/workqueue.h
+++ b/include/linux/workqueue.h
@@ -473,7 +473,7 @@ void workqueue_softirq_dead(unsigned int cpu);
  * @fmt: printf format for the name of the workqueue
  * @flags: WQ_* flags
  * @max_active: max in-flight work items, 0 for default
- * remaining args: args for @fmt
+ * @...: args for @fmt
  *
  * For a per-cpu workqueue, @max_active limits the number of in-flight work
  * items for each CPU. e.g. @max_active of 1 indicates that each CPU can be
-- 
2.44.0

Re: linux-next: build warning after merge of the workqueues tree

[Tejun Heo]

On Mon, Apr 22, 2024 at 09:48:16AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> On Tue, 30 Jan 2024 13:37:48 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > 
> > After merging the workqueues tree, today's linux-next build (htmldocs)
> > produced this warning:
> > 
> > Documentation/core-api/workqueue:761: include/linux/workqueue.h:476: WARNING: Inline literal start-string without end-string.
> > 
> > Introduced by commit
> > 
> >   5797b1c18919 ("workqueue: Implement system-wide nr_active enforcement for unbound workqueues")
> 
> I am still seeing the above warning.

Oops, sorry about missing that. Will fix.

Thanks.

-- 
tejun

Re: linux-next: build warning after merge of the workqueues tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

Hi all,

On Tue, 30 Jan 2024 13:37:48 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> After merging the workqueues tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/core-api/workqueue:761: include/linux/workqueue.h:476: WARNING: Inline literal start-string without end-string.
> 
> Introduced by commit
> 
>   5797b1c18919 ("workqueue: Implement system-wide nr_active enforcement for unbound workqueues")

I am still seeing the above warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the workqueues tree

[Waiman Long]

On 2/8/24 22:24, Stephen Rothwell wrote:
> Hi all,
>
> After merging the workqueues tree, today's linux-next build (htmldocs)
> produced this warning:
>
> Documentation/core-api/workqueue:778: kernel/workqueue.c:1801: WARNING: Line block ends without a blank line.
> Documentation/core-api/workqueue:778: kernel/workqueue.c:1804: WARNING: Line block ends without a blank line.
>
> Introduced by commit
>
>    4c065dbce1e8 ("workqueue: Enable unbound cpumask update on ordered workqueues")

That warning is likely by the following function comment:

/**
  * unplug_oldest_pwq - restart an oldest plugged pool_workqueue
  * @wq: workqueue_struct to be restarted
  *
  * pwq's are linked into wq->pwqs with the oldest first. For ordered
  * workqueues, only the oldest pwq is unplugged, the others are plugged to
  * suspend execution until the oldest one is drained. When this 
happens, the
  * next oldest one (first plugged pwq in iteration) will be unplugged to
  * restart work item execution to ensure proper work item ordering.
  *
  *    dfl_pwq --------------+     [P] - plugged
  *                          |
  *                          v
  *    pwqs -> A -> B [P] -> C [P] (newest)
  *            |    |        |
  *            1    3        5
  *            |    |        |
  *            2    4        6
  */

One possible solution is to take out one '*' of the leading "/**" so 
that it is not regarded as an inline documentation block. Any other 
suggestion is welcome.

Cheers,
Longman

linux-next: build warning after merge of the workqueues tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

Hi all,

After merging the workqueues tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/core-api/workqueue:778: kernel/workqueue.c:1801: WARNING: Line block ends without a blank line.
Documentation/core-api/workqueue:778: kernel/workqueue.c:1804: WARNING: Line block ends without a blank line.

Introduced by commit

  4c065dbce1e8 ("workqueue: Enable unbound cpumask update on ordered workqueues")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the workqueues tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

Hi all,

After merging the workqueues tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/core-api/workqueue:761: include/linux/workqueue.h:476: WARNING: Inline literal start-string without end-string.

Introduced by commit

  5797b1c18919 ("workqueue: Implement system-wide nr_active enforcement for unbound workqueues")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the workqueues tree

[Tejun Heo]

On Fri, Jan 13, 2023 at 04:48:29PM +0000, Valentin Schneider wrote:
> On 13/01/23 16:47, Valentin Schneider wrote:
> > On 13/01/23 06:31, Tejun Heo wrote:
> >> On Fri, Jan 13, 2023 at 02:31:02PM +1100, Stephen Rothwell wrote:
> >>> Hi all,
> >>>
> >>> After merging the workqueues tree, today's linux-next build (x86_64
> >>> allnoconfig and several others) produced this warning:
> >>>
> >>> kernel/workqueue.c:1993:13: warning: 'rebind_worker' defined but not used [-Wunused-function]
> >>>  1993 | static void rebind_worker(struct worker *worker, struct worker_pool *pool)
> >>>       |             ^~~~~~~~~~~~~
> >>>
> >>> Introduced by commit
> >>>
> >>>   793777bc193b ("workqueue: Factorize unbind/rebind_workers() logic")
> >>
> >> Valentin, this is caused by rebind_worker() being only used by
> >> rebind_workers() which is inside CONFIG_SMP. I don't see any other uses of
> >> rebind_worker(). Just fold it back into rebind_workers()?
> >>
> >
> > Woops! Yes I only did it to keep things aligned with unbind_workers(), let
> > me resend with that folded back in. Sorry!
> >
> 
> Unless you'd prefer a fixup patch on top of those you've already picked up?

Yeah, just send another patch to fold it back in.

Thanks.

-- 
tejun

Re: linux-next: build warning after merge of the workqueues tree

[Valentin Schneider]

On 13/01/23 16:47, Valentin Schneider wrote:
> On 13/01/23 06:31, Tejun Heo wrote:
>> On Fri, Jan 13, 2023 at 02:31:02PM +1100, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> After merging the workqueues tree, today's linux-next build (x86_64
>>> allnoconfig and several others) produced this warning:
>>>
>>> kernel/workqueue.c:1993:13: warning: 'rebind_worker' defined but not used [-Wunused-function]
>>>  1993 | static void rebind_worker(struct worker *worker, struct worker_pool *pool)
>>>       |             ^~~~~~~~~~~~~
>>>
>>> Introduced by commit
>>>
>>>   793777bc193b ("workqueue: Factorize unbind/rebind_workers() logic")
>>
>> Valentin, this is caused by rebind_worker() being only used by
>> rebind_workers() which is inside CONFIG_SMP. I don't see any other uses of
>> rebind_worker(). Just fold it back into rebind_workers()?
>>
>
> Woops! Yes I only did it to keep things aligned with unbind_workers(), let
> me resend with that folded back in. Sorry!
>

Unless you'd prefer a fixup patch on top of those you've already picked up?

>> Thanks.
>>
>> --
>> tejun

Re: linux-next: build warning after merge of the workqueues tree

[Valentin Schneider]

On 13/01/23 06:31, Tejun Heo wrote:
> On Fri, Jan 13, 2023 at 02:31:02PM +1100, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the workqueues tree, today's linux-next build (x86_64
>> allnoconfig and several others) produced this warning:
>>
>> kernel/workqueue.c:1993:13: warning: 'rebind_worker' defined but not used [-Wunused-function]
>>  1993 | static void rebind_worker(struct worker *worker, struct worker_pool *pool)
>>       |             ^~~~~~~~~~~~~
>>
>> Introduced by commit
>>
>>   793777bc193b ("workqueue: Factorize unbind/rebind_workers() logic")
>
> Valentin, this is caused by rebind_worker() being only used by
> rebind_workers() which is inside CONFIG_SMP. I don't see any other uses of
> rebind_worker(). Just fold it back into rebind_workers()?
>

Woops! Yes I only did it to keep things aligned with unbind_workers(), let
me resend with that folded back in. Sorry!

> Thanks.
>
> --
> tejun

Re: linux-next: build warning after merge of the workqueues tree

[Tejun Heo]

On Fri, Jan 13, 2023 at 02:31:02PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the workqueues tree, today's linux-next build (x86_64
> allnoconfig and several others) produced this warning:
> 
> kernel/workqueue.c:1993:13: warning: 'rebind_worker' defined but not used [-Wunused-function]
>  1993 | static void rebind_worker(struct worker *worker, struct worker_pool *pool)
>       |             ^~~~~~~~~~~~~
> 
> Introduced by commit
> 
>   793777bc193b ("workqueue: Factorize unbind/rebind_workers() logic")

Valentin, this is caused by rebind_worker() being only used by
rebind_workers() which is inside CONFIG_SMP. I don't see any other uses of
rebind_worker(). Just fold it back into rebind_workers()?

Thanks.

-- 
tejun

linux-next: build warning after merge of the workqueues tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

Hi all,

After merging the workqueues tree, today's linux-next build (x86_64
allnoconfig and several others) produced this warning:

kernel/workqueue.c:1993:13: warning: 'rebind_worker' defined but not used [-Wunused-function]
 1993 | static void rebind_worker(struct worker *worker, struct worker_pool *pool)
      |             ^~~~~~~~~~~~~

Introduced by commit

  793777bc193b ("workqueue: Factorize unbind/rebind_workers() logic")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the workqueues tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

Hi Tejun,

After merging the workqueues tree, today's linux-next build (powerpc
allnoconfig) produced this warning:

kernel/workqueue.c:260:13: warning: 'workqueue_freezing' defined but not used [-Wunused-variable]

Introduced by commit 699ce097efe8 ("workqueue: implement and use
pwq_adjust_max_active()").  This build does not have CONFIG_FREEZER set.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]