* linux-next: build warning after merge of the tpmdd tree
@ 2017-09-07 2:31 Stephen Rothwell
2017-09-07 8:43 ` Colin Ian King
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2017-09-07 2:31 UTC (permalink / raw)
To: Jarkko Sakkinen
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Colin Ian King
Hi Jarkko,
After merging the tpmdd tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/char/tpm/tpm_tis_core.c: In function 'probe_itpm':
drivers/char/tpm/tpm_tis_core.c:469:31: warning: passing argument 2 of 'tpm_tis_send_data' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
rc = tpm_tis_send_data(chip, cmd_getticks, len);
^
drivers/char/tpm/tpm_tis_core.c:255:12: note: expected 'u8 * {aka unsigned char *}' but argument is of type 'const u8 * {aka const unsigned char *}'
static int tpm_tis_send_data(struct tpm_chip *chip, u8 *buf, size_t len)
^
drivers/char/tpm/tpm_tis_core.c:477:31: warning: passing argument 2 of 'tpm_tis_send_data' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
rc = tpm_tis_send_data(chip, cmd_getticks, len);
^
drivers/char/tpm/tpm_tis_core.c:255:12: note: expected 'u8 * {aka unsigned char *}' but argument is of type 'const u8 * {aka const unsigned char *}'
static int tpm_tis_send_data(struct tpm_chip *chip, u8 *buf, size_t len)
^
Introduced by commit
5e35bd8e06b9 ("tpm_tis: make array cmd_getticks static const to shink object code size")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: linux-next: build warning after merge of the tpmdd tree
2017-09-07 2:31 linux-next: build warning after merge of the tpmdd tree Stephen Rothwell
@ 2017-09-07 8:43 ` Colin Ian King
2017-09-07 16:21 ` Jarkko Sakkinen
0 siblings, 1 reply; 11+ messages in thread
From: Colin Ian King @ 2017-09-07 8:43 UTC (permalink / raw)
To: Stephen Rothwell, Jarkko Sakkinen
Cc: Linux-Next Mailing List, Linux Kernel Mailing List
Thanks for reporting that Stephen, I've sent a fix to address this issue.
Colin
On 07/09/17 03:31, Stephen Rothwell wrote:
> Hi Jarkko,
>
> After merging the tpmdd tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/char/tpm/tpm_tis_core.c: In function 'probe_itpm':
> drivers/char/tpm/tpm_tis_core.c:469:31: warning: passing argument 2 of 'tpm_tis_send_data' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> rc = tpm_tis_send_data(chip, cmd_getticks, len);
> ^
> drivers/char/tpm/tpm_tis_core.c:255:12: note: expected 'u8 * {aka unsigned char *}' but argument is of type 'const u8 * {aka const unsigned char *}'
> static int tpm_tis_send_data(struct tpm_chip *chip, u8 *buf, size_t len)
> ^
> drivers/char/tpm/tpm_tis_core.c:477:31: warning: passing argument 2 of 'tpm_tis_send_data' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> rc = tpm_tis_send_data(chip, cmd_getticks, len);
> ^
> drivers/char/tpm/tpm_tis_core.c:255:12: note: expected 'u8 * {aka unsigned char *}' but argument is of type 'const u8 * {aka const unsigned char *}'
> static int tpm_tis_send_data(struct tpm_chip *chip, u8 *buf, size_t len)
> ^
>
> Introduced by commit
>
> 5e35bd8e06b9 ("tpm_tis: make array cmd_getticks static const to shink object code size")
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: linux-next: build warning after merge of the tpmdd tree
2017-09-07 8:43 ` Colin Ian King
@ 2017-09-07 16:21 ` Jarkko Sakkinen
0 siblings, 0 replies; 11+ messages in thread
From: Jarkko Sakkinen @ 2017-09-07 16:21 UTC (permalink / raw)
To: Colin Ian King
Cc: Stephen Rothwell, Linux-Next Mailing List, Linux Kernel Mailing List
Colin, Stephen,
Thank you. I'll apply Colin's fix.
/Jarkko
On Thu, Sep 07, 2017 at 09:43:37AM +0100, Colin Ian King wrote:
> Thanks for reporting that Stephen, I've sent a fix to address this issue.
>
> Colin
>
> On 07/09/17 03:31, Stephen Rothwell wrote:
> > Hi Jarkko,
> >
> > After merging the tpmdd tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > drivers/char/tpm/tpm_tis_core.c: In function 'probe_itpm':
> > drivers/char/tpm/tpm_tis_core.c:469:31: warning: passing argument 2 of 'tpm_tis_send_data' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> > rc = tpm_tis_send_data(chip, cmd_getticks, len);
> > ^
> > drivers/char/tpm/tpm_tis_core.c:255:12: note: expected 'u8 * {aka unsigned char *}' but argument is of type 'const u8 * {aka const unsigned char *}'
> > static int tpm_tis_send_data(struct tpm_chip *chip, u8 *buf, size_t len)
> > ^
> > drivers/char/tpm/tpm_tis_core.c:477:31: warning: passing argument 2 of 'tpm_tis_send_data' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> > rc = tpm_tis_send_data(chip, cmd_getticks, len);
> > ^
> > drivers/char/tpm/tpm_tis_core.c:255:12: note: expected 'u8 * {aka unsigned char *}' but argument is of type 'const u8 * {aka const unsigned char *}'
> > static int tpm_tis_send_data(struct tpm_chip *chip, u8 *buf, size_t len)
> > ^
> >
> > Introduced by commit
> >
> > 5e35bd8e06b9 ("tpm_tis: make array cmd_getticks static const to shink object code size")
> >
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* linux-next: build warning after merge of the tpmdd tree
@ 2019-06-11 4:52 Stephen Rothwell
2019-06-13 15:13 ` Jarkko Sakkinen
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2019-06-11 4:52 UTC (permalink / raw)
To: Jarkko Sakkinen
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Matthew Garrett
[-- Attachment #1: Type: text/plain, Size: 967 bytes --]
Hi all,
After merging the tpmdd tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
drivers/firmware/efi/tpm.c: In function 'efi_tpm_eventlog_init':
drivers/firmware/efi/tpm.c:80:10: warning: passing argument 1 of 'tpm2_calc_event_log_size' makes pointer from integer without a cast [-Wint-conversion]
tbl_size = tpm2_calc_event_log_size(efi.tpm_final_log
~~~~~~~~~~~~~~~~~
+ sizeof(final_tbl->version)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ sizeof(final_tbl->nr_events),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/firmware/efi/tpm.c:19:43: note: expected 'void *' but argument is of type 'long unsigned int'
static int tpm2_calc_event_log_size(void *data, int count, void *size_info)
~~~~~~^~~~
Introduced by commit
a537b15c54a3 ("tpm: Reserve the TPM final events table")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: linux-next: build warning after merge of the tpmdd tree
2019-06-11 4:52 Stephen Rothwell
@ 2019-06-13 15:13 ` Jarkko Sakkinen
0 siblings, 0 replies; 11+ messages in thread
From: Jarkko Sakkinen @ 2019-06-13 15:13 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Matthew Garrett
Matthew, can you provide a fixup for this?
/Jarkko
On Tue, Jun 11, 2019 at 02:52:55PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the tpmdd tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/firmware/efi/tpm.c: In function 'efi_tpm_eventlog_init':
> drivers/firmware/efi/tpm.c:80:10: warning: passing argument 1 of 'tpm2_calc_event_log_size' makes pointer from integer without a cast [-Wint-conversion]
> tbl_size = tpm2_calc_event_log_size(efi.tpm_final_log
> ~~~~~~~~~~~~~~~~~
> + sizeof(final_tbl->version)
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> + sizeof(final_tbl->nr_events),
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/firmware/efi/tpm.c:19:43: note: expected 'void *' but argument is of type 'long unsigned int'
> static int tpm2_calc_event_log_size(void *data, int count, void *size_info)
> ~~~~~~^~~~
>
> Introduced by commit
>
> a537b15c54a3 ("tpm: Reserve the TPM final events table")
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 11+ messages in thread
* linux-next: build warning after merge of the tpmdd tree
@ 2019-02-07 2:47 Stephen Rothwell
2019-02-07 21:16 ` Jarkko Sakkinen
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2019-02-07 2:47 UTC (permalink / raw)
To: Jarkko Sakkinen
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Roberto Sassu
[-- Attachment #1: Type: text/plain, Size: 2295 bytes --]
Hi Jarkko,
After merging the tpmdd tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/char/tpm/tpm_i2c_nuvoton.c:45: warning: "TPM_RETRY" redefined
#define TPM_RETRY 5
In file included from drivers/char/tpm/tpm_i2c_nuvoton.c:35:
drivers/char/tpm/tpm.h:43: note: this is the location of the previous definition
#define TPM_RETRY 50
drivers/char/tpm/tpm_i2c_infineon.c:30: warning: "TPM_BUFSIZE" redefined
#define TPM_BUFSIZE 1260
In file included from drivers/char/tpm/tpm_i2c_infineon.c:27:
drivers/char/tpm/tpm.h:41: note: this is the location of the previous definition
#define TPM_BUFSIZE 4096
In file included from drivers/char/tpm/st33zp24/i2c.c:30:
drivers/char/tpm/st33zp24/st33zp24.h:22: warning: "TPM_BUFSIZE" redefined
#define TPM_BUFSIZE 2048
In file included from drivers/char/tpm/st33zp24/i2c.c:29:
drivers/char/tpm/st33zp24/../tpm.h:41: note: this is the location of the previous definition
#define TPM_BUFSIZE 4096
In file included from drivers/char/tpm/st33zp24/spi.c:30:
drivers/char/tpm/st33zp24/st33zp24.h:22: warning: "TPM_BUFSIZE" redefined
#define TPM_BUFSIZE 2048
In file included from drivers/char/tpm/st33zp24/spi.c:29:
drivers/char/tpm/st33zp24/../tpm.h:41: note: this is the location of the previous definition
#define TPM_BUFSIZE 4096
In file included from drivers/char/tpm/st33zp24/st33zp24.c:34:
drivers/char/tpm/st33zp24/st33zp24.h:22: warning: "TPM_BUFSIZE" redefined
#define TPM_BUFSIZE 2048
In file included from drivers/char/tpm/st33zp24/st33zp24.c:33:
drivers/char/tpm/st33zp24/../tpm.h:41: note: this is the location of the previous definition
#define TPM_BUFSIZE 4096
In file included from drivers/char/tpm/st33zp24/st33zp24.c:34:
drivers/char/tpm/st33zp24/st33zp24.h:22: warning: "TPM_BUFSIZE" redefined
#define TPM_BUFSIZE 2048
In file included from drivers/char/tpm/st33zp24/st33zp24.c:33:
drivers/char/tpm/st33zp24/../tpm.h:41: note: this is the location of the previous definition
#define TPM_BUFSIZE 4096
Introduced by commit
569c1057f9ac ("tpm: move tpm_chip definition to include/linux/tpm.h")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: linux-next: build warning after merge of the tpmdd tree
2019-02-07 2:47 Stephen Rothwell
@ 2019-02-07 21:16 ` Jarkko Sakkinen
0 siblings, 0 replies; 11+ messages in thread
From: Jarkko Sakkinen @ 2019-02-07 21:16 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Roberto Sassu
On Thu, Feb 07, 2019 at 01:47:33PM +1100, Stephen Rothwell wrote:
> Hi Jarkko,
>
> After merging the tpmdd tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/char/tpm/tpm_i2c_nuvoton.c:45: warning: "TPM_RETRY" redefined
> #define TPM_RETRY 5
>
> In file included from drivers/char/tpm/tpm_i2c_nuvoton.c:35:
> drivers/char/tpm/tpm.h:43: note: this is the location of the previous definition
> #define TPM_RETRY 50
>
> drivers/char/tpm/tpm_i2c_infineon.c:30: warning: "TPM_BUFSIZE" redefined
> #define TPM_BUFSIZE 1260
>
> In file included from drivers/char/tpm/tpm_i2c_infineon.c:27:
> drivers/char/tpm/tpm.h:41: note: this is the location of the previous definition
> #define TPM_BUFSIZE 4096
>
> In file included from drivers/char/tpm/st33zp24/i2c.c:30:
> drivers/char/tpm/st33zp24/st33zp24.h:22: warning: "TPM_BUFSIZE" redefined
> #define TPM_BUFSIZE 2048
>
> In file included from drivers/char/tpm/st33zp24/i2c.c:29:
> drivers/char/tpm/st33zp24/../tpm.h:41: note: this is the location of the previous definition
> #define TPM_BUFSIZE 4096
>
> In file included from drivers/char/tpm/st33zp24/spi.c:30:
> drivers/char/tpm/st33zp24/st33zp24.h:22: warning: "TPM_BUFSIZE" redefined
> #define TPM_BUFSIZE 2048
>
> In file included from drivers/char/tpm/st33zp24/spi.c:29:
> drivers/char/tpm/st33zp24/../tpm.h:41: note: this is the location of the previous definition
> #define TPM_BUFSIZE 4096
>
> In file included from drivers/char/tpm/st33zp24/st33zp24.c:34:
> drivers/char/tpm/st33zp24/st33zp24.h:22: warning: "TPM_BUFSIZE" redefined
> #define TPM_BUFSIZE 2048
>
> In file included from drivers/char/tpm/st33zp24/st33zp24.c:33:
> drivers/char/tpm/st33zp24/../tpm.h:41: note: this is the location of the previous definition
> #define TPM_BUFSIZE 4096
>
> In file included from drivers/char/tpm/st33zp24/st33zp24.c:34:
> drivers/char/tpm/st33zp24/st33zp24.h:22: warning: "TPM_BUFSIZE" redefined
> #define TPM_BUFSIZE 2048
>
> In file included from drivers/char/tpm/st33zp24/st33zp24.c:33:
> drivers/char/tpm/st33zp24/../tpm.h:41: note: this is the location of the previous definition
> #define TPM_BUFSIZE 4096
>
>
> Introduced by commit
>
> 569c1057f9ac ("tpm: move tpm_chip definition to include/linux/tpm.h")
Hi I forgot apply this before that commit:
tpm: Fix some name collisions with drivers/char/tpm.h
* Rename TPM_BUFSIZE defined in drivers/char/tpm/st33zp24/st33zp24.h to
ST33ZP24_BUFSIZE.
* Rename TPM_BUFSIZE defined in drivers/char/tpm/tpm_i2c_infineon.c to
TPM_I2C_INFINEON_BUFSIZE.
* Rename TPM_RETRY in tpm_i2c_nuvoton to TPM_I2C_RETRIES.
* Remove TPM_HEADER_SIZE from tpm_i2c_nuvoton.
Cc: stable@vger.kernel.org
Fixes: bf38b8710892 ("tpm/tpm_i2c_stm_st33: Split tpm_i2c_tpm_st33 in 2 layers (core + phy)")
Fixes: aad628c1d91a ("char/tpm: Add new driver for Infineon I2C TIS TPM")
Fixes: 32d33b29ba07 ("TPM: Retry SaveState command in suspend path")
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
It is now pushed.
/Jarkko
^ permalink raw reply [flat|nested] 11+ messages in thread
* linux-next: build warning after merge of the tpmdd tree
@ 2018-01-02 2:50 Stephen Rothwell
2018-01-02 4:05 ` Shaikh, Azhar
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2018-01-02 2:50 UTC (permalink / raw)
To: Jarkko Sakkinen
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Azhar Shaikh
Hi Jarkko,
After merging the tpmdd tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/char/tpm/tpm_tis.c: In function 'tpm_tis_pnp_remove':
drivers/char/tpm/tpm_tis.c:274:23: warning: unused variable 'priv' [-Wunused-variable]
struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
^
drivers/char/tpm/tpm_tis.c: In function 'tpm_tis_plat_remove':
drivers/char/tpm/tpm_tis.c:324:23: warning: unused variable 'priv' [-Wunused-variable]
struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
^
Introduced by commit
6d0866cbc2d3 ("tpm: Keep CLKRUN enabled throughout the duration of transmit_cmd()")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 11+ messages in thread* RE: linux-next: build warning after merge of the tpmdd tree
2018-01-02 2:50 Stephen Rothwell
@ 2018-01-02 4:05 ` Shaikh, Azhar
0 siblings, 0 replies; 11+ messages in thread
From: Shaikh, Azhar @ 2018-01-02 4:05 UTC (permalink / raw)
To: Stephen Rothwell, Jarkko Sakkinen
Cc: Linux-Next Mailing List, Linux Kernel Mailing List
Hi Stephen,
Thanks for reporting this.
I have uploaded new patchset to tpmdd mailing list.
Regards,
Azhar Shaikh
>-----Original Message-----
>From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
>Sent: Monday, January 1, 2018 6:51 PM
>To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing
>List <linux-kernel@vger.kernel.org>; Shaikh, Azhar <azhar.shaikh@intel.com>
>Subject: linux-next: build warning after merge of the tpmdd tree
>
>Hi Jarkko,
>
>After merging the tpmdd tree, today's linux-next build (x86_64
>allmodconfig) produced this warning:
>
>drivers/char/tpm/tpm_tis.c: In function 'tpm_tis_pnp_remove':
>drivers/char/tpm/tpm_tis.c:274:23: warning: unused variable 'priv' [-
>Wunused-variable]
> struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
> ^
>drivers/char/tpm/tpm_tis.c: In function 'tpm_tis_plat_remove':
>drivers/char/tpm/tpm_tis.c:324:23: warning: unused variable 'priv' [-
>Wunused-variable]
> struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
> ^
>
>Introduced by commit
>
> 6d0866cbc2d3 ("tpm: Keep CLKRUN enabled throughout the duration of
>transmit_cmd()")
>
>--
>Cheers,
>Stephen Rothwell
^ permalink raw reply [flat|nested] 11+ messages in thread
* linux-next: build warning after merge of the tpmdd tree
@ 2016-11-15 1:01 Stephen Rothwell
2016-11-15 2:13 ` Jarkko Sakkinen
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2016-11-15 1:01 UTC (permalink / raw)
To: Jarkko Sakkinen; +Cc: linux-next, linux-kernel, Nayna Jain
Hi Jarkko,
After merging the tpmdd tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/char/tpm/tpm_of.c: In function 'read_log_of':
drivers/char/tpm/tpm_of.c:37:8: warning: 'np' may be used uninitialized in this function [-Wmaybe-uninitialized]
sizep = of_get_property(np, "linux,sml-size", NULL);
^
Introduced by commit
4a45d9669ac1 ("tpm: replace of_find_node_by_name() with dev of_node property")
This commit is just wrong :-(
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: linux-next: build warning after merge of the tpmdd tree
2016-11-15 1:01 Stephen Rothwell
@ 2016-11-15 2:13 ` Jarkko Sakkinen
0 siblings, 0 replies; 11+ messages in thread
From: Jarkko Sakkinen @ 2016-11-15 2:13 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Nayna Jain
On Tue, Nov 15, 2016 at 12:01:07PM +1100, Stephen Rothwell wrote:
> Hi Jarkko,
>
> After merging the tpmdd tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/char/tpm/tpm_of.c: In function 'read_log_of':
> drivers/char/tpm/tpm_of.c:37:8: warning: 'np' may be used uninitialized in this function [-Wmaybe-uninitialized]
> sizep = of_get_property(np, "linux,sml-size", NULL);
> ^
>
> Introduced by commit
>
> 4a45d9669ac1 ("tpm: replace of_find_node_by_name() with dev of_node property")
>
> This commit is just wrong :-(
It really is. I'll drop it from my tree.
> --
> Cheers,
> Stephen Rothwell
/Jarkko
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-06-13 15:14 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-07 2:31 linux-next: build warning after merge of the tpmdd tree Stephen Rothwell
2017-09-07 8:43 ` Colin Ian King
2017-09-07 16:21 ` Jarkko Sakkinen
-- strict thread matches above, loose matches on Subject: below --
2019-06-11 4:52 Stephen Rothwell
2019-06-13 15:13 ` Jarkko Sakkinen
2019-02-07 2:47 Stephen Rothwell
2019-02-07 21:16 ` Jarkko Sakkinen
2018-01-02 2:50 Stephen Rothwell
2018-01-02 4:05 ` Shaikh, Azhar
2016-11-15 1:01 Stephen Rothwell
2016-11-15 2:13 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).