linux-next: build failure after merge of the spi-nor tree

linux-next: build failure after merge of the spi-nor tree

[Stephen Rothwell]

Hi Cyrille,

After merging the spi-nor tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/mtd/spi-nor/aspeed-smc.c: In function 'aspeed_smc_chip_set_segment':
drivers/mtd/spi-nor/aspeed-smc.c:554:14: error: 'SZ_128M' undeclared (first use in this function)
      size == SZ_128M) {
              ^

Caused by commit

  bb3a588d2151 ("mtd: spi-nor: aspeed: configure chip window on AHB bus")

Forgot to include linux/sizes.h.

I have used the spi-nor tree from next-20170620 for today.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the spi-nor tree

[Cyrille Pitchen]

Hi Stephen,

Le 21/06/2017 à 04:19, Stephen Rothwell a écrit :
> Hi Cyrille,
> 
> After merging the spi-nor tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/mtd/spi-nor/aspeed-smc.c: In function 'aspeed_smc_chip_set_segment':
> drivers/mtd/spi-nor/aspeed-smc.c:554:14: error: 'SZ_128M' undeclared (first use in this function)
>       size == SZ_128M) {
>               ^
> 
> Caused by commit
> 
>   bb3a588d2151 ("mtd: spi-nor: aspeed: configure chip window on AHB bus")
> 
> Forgot to include linux/sizes.h.

I've squashed the fixup into the faulty patch in the spi-nor/next branch
of l2-mtd, so it should be OK now.

Thank you for your report and sorry for the noise!

Best regards,

Cyrille

> 
> I have used the spi-nor tree from next-20170620 for today.
> 

linux-next: build failure after merge of the spi-nor tree

[Stephen Rothwell]

Hi Cyrille,

After merging the spi-nor tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from include/linux/printk.h:329:0,
                 from include/linux/kernel.h:13,
                 from include/linux/clk.h:16,
                 from drivers/mtd/spi-nor/stm32-quadspi.c:8:
drivers/mtd/spi-nor/stm32-quadspi.c: In function 'stm32_qspi_read':
drivers/mtd/spi-nor/stm32-quadspi.c:378:21: warning: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'size_t {aka long unsigned int}' [-Wformat=]
  dev_dbg(qspi->dev, "read(%#.2x): buf:%p from:%#.8x len:%#x\n",
                     ^
include/linux/dynamic_debug.h:134:39: note: in definition of macro 'dynamic_dev_dbg'
   __dynamic_dev_dbg(&descriptor, dev, fmt, \
                                       ^
drivers/mtd/spi-nor/stm32-quadspi.c:378:2: note: in expansion of macro 'dev_dbg'
  dev_dbg(qspi->dev, "read(%#.2x): buf:%p from:%#.8x len:%#x\n",
  ^
drivers/mtd/spi-nor/stm32-quadspi.c: In function 'stm32_qspi_write':
drivers/mtd/spi-nor/stm32-quadspi.c:405:15: warning: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'size_t {aka long unsigned int}' [-Wformat=]
  dev_dbg(dev, "write(%#.2x): buf:%p to:%#.8x len:%#x\n",
               ^
include/linux/dynamic_debug.h:134:39: note: in definition of macro 'dynamic_dev_dbg'
   __dynamic_dev_dbg(&descriptor, dev, fmt, \
                                       ^
drivers/mtd/spi-nor/stm32-quadspi.c:405:2: note: in expansion of macro 'dev_dbg'
  dev_dbg(dev, "write(%#.2x): buf:%p to:%#.8x len:%#x\n",
  ^
drivers/mtd/spi-nor/stm32-quadspi.c: In function 'stm32_qspi_flash_setup':
drivers/mtd/spi-nor/stm32-quadspi.c:543:27: error: 'SZ_1K' undeclared (first use in this function)
  flash->fsize = FSIZE_VAL(SZ_1K);
                           ^
drivers/mtd/spi-nor/stm32-quadspi.c:110:33: note: in definition of macro 'FSIZE_VAL'
 #define FSIZE_VAL(size)  (__fls(size) - 1)
                                 ^
drivers/mtd/spi-nor/stm32-quadspi.c:543:27: note: each undeclared identifier is reported only once for each function it appears in
  flash->fsize = FSIZE_VAL(SZ_1K);
                           ^
drivers/mtd/spi-nor/stm32-quadspi.c:110:33: note: in definition of macro 'FSIZE_VAL'
 #define FSIZE_VAL(size)  (__fls(size) - 1)
                                 ^

Exposed by commit

  7a754f2016a0 ("mtd: spi-nor: stm32-quadspi: allow building with COMPILE_TEST")

I have used the spi-nor tree from next-20170503 for today.

-- 
Cheers,
Stephen Rothwell