Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: <Tudor.Ambarus@microchip.com>
To: <keescook@chromium.org>
Cc: <boris.brezillon@collabora.com>, <gustavo@embeddedor.com>,
	<linux-next@vger.kernel.org>
Subject: Re: Coverity: spi_nor_erase_sector(): Null pointer dereferences
Date: Tue, 29 Oct 2019 05:59:04 +0000
Message-ID: <c1fae93d-ea1c-ace1-28d9-00ac558129c4@microchip.com> (raw)
In-Reply-To: <201910281605.9E90B64E86@keescook>

Hi. Thanks for the report!

On 10/29/2019 01:05 AM, coverity-bot wrote:
> External E-Mail
> 
> 
> Hello!
> 
> This is an experimental automated report about issues detected by Coverity
> from a scan of next-20191025 as part of the linux-next weekly scan project:
> https://scan.coverity.com/projects/linux-next-weekly-scan
> 
> You're getting this email because you were associated with the identified
> lines of code (noted below) that were touched by recent commits:
> 
> 453977875364 ("mtd: spi-nor: Introduce 'struct spi_nor_controller_ops'")
> 
> Coverity reported the following:
> 
> *** CID 1487363:  Null pointer dereferences  (FORWARD_NULL)
> /drivers/mtd/spi-nor/spi-nor.c: 967 in spi_nor_erase_sector()
> 961     	 */
> 962     	for (i = nor->addr_width - 1; i >= 0; i--) {
> 963     		nor->bouncebuf[i] = addr & 0xff;
> 964     		addr >>= 8;
> 965     	}
> 966
> vvv     CID 1487363:  Null pointer dereferences  (FORWARD_NULL)
> vvv     Dereferencing null pointer "nor->controller_ops".
> 967     	return nor->controller_ops->write_reg(nor, nor->erase_opcode,
> 968     					      nor->bouncebuf, nor->addr_width);
> 969     }
> 970
> 971     /**
> 972      * spi_nor_div_by_erase_size() - calculate remainder and update new dividend
> 
> If this is a false positive, please let us know so we can mark it as
> such, or teach the Coverity rules to be smarter. If not, please make
> sure fixes get into linux-next. :) For patches fixing this, please
> include:

It's a false positive, but the bug report helped us improve the code. I received
similar report with smatch, see the discussion here:
https://www.spinics.net/lists/linux-mtd/msg09701.html


Cheers,
ta
> 
> Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
> Addresses-Coverity-ID: 1487363 ("Null pointer dereferences")
> Fixes: 453977875364 ("mtd: spi-nor: Introduce 'struct spi_nor_controller_ops'")
> 
> 
> Thanks for your attention!
> 

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28 23:05 coverity-bot
2019-10-29  5:59 ` Tudor.Ambarus [this message]
2019-10-29 16:05   ` Kees Cook

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1fae93d-ea1c-ace1-28d9-00ac558129c4@microchip.com \
    --to=tudor.ambarus@microchip.com \
    --cc=boris.brezillon@collabora.com \
    --cc=gustavo@embeddedor.com \
    --cc=keescook@chromium.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git