linux-next: build warning after merge of the devicetree tree

linux-next: build warning after merge of the devicetree tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

Hi all,

After merging the devicetree tree, today's linux-next build (htmldocs)
produced this warning:

include/linux/of.h:115: warning: cannot understand function prototype: 'const struct kobj_type of_node_ktype; '

Introduced by commit

  39459ce717b8 ("of: dynamic: add lifecycle docbook info to node creation functions")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[PATCH] of: fix htmldocs build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]


Fix this htmldoc build warning:

include/linux/of.h:115: warning: cannot understand function prototype: 'const struct kobj_type of_node_ktype; '

Reported by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 39459ce717b8 ("of: dynamic: add lifecycle docbook info to node creation functions")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/of.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

This is actually untested, but seems pretty straight forward.

diff --git a/include/linux/of.h b/include/linux/of.h
index 0af611307db2..814d33f3835a 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -100,6 +100,9 @@ struct of_reconfig_data {
 	struct property		*old_prop;
 };
 
+extern const struct kobj_type of_node_ktype;
+extern const struct fwnode_operations of_fwnode_ops;
+
 /**
  * of_node_init - initialize a devicetree node
  * @node: Pointer to device node that has been created by kzalloc()
@@ -111,9 +114,6 @@ struct of_reconfig_data {
  * whether to free the memory will be done by node->release(), which is
  * of_node_release().
  */
-/* initialize a node */
-extern const struct kobj_type of_node_ktype;
-extern const struct fwnode_operations of_fwnode_ops;
 static inline void of_node_init(struct device_node *node)
 {
 #if defined(CONFIG_OF_KOBJ)
-- 
2.39.2

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] of: fix htmldocs build warning

[Randy Dunlap]

On 3/9/23 16:32, Stephen Rothwell wrote:
> 
> Fix this htmldoc build warning:
> 
> include/linux/of.h:115: warning: cannot understand function prototype: 'const struct kobj_type of_node_ktype; '
> 
> Reported by: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: 39459ce717b8 ("of: dynamic: add lifecycle docbook info to node creation functions")
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>


Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.

After this patch, there is another warning for this function:

../include/linux/of.h:118: warning: Excess function parameter 'phandle_name' description in 'of_node_init'

> ---
>  include/linux/of.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> This is actually untested, but seems pretty straight forward.
> 
> diff --git a/include/linux/of.h b/include/linux/of.h
> index 0af611307db2..814d33f3835a 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -100,6 +100,9 @@ struct of_reconfig_data {
>  	struct property		*old_prop;
>  };
>  
> +extern const struct kobj_type of_node_ktype;
> +extern const struct fwnode_operations of_fwnode_ops;
> +
>  /**
>   * of_node_init - initialize a devicetree node
>   * @node: Pointer to device node that has been created by kzalloc()
> @@ -111,9 +114,6 @@ struct of_reconfig_data {
>   * whether to free the memory will be done by node->release(), which is
>   * of_node_release().
>   */
> -/* initialize a node */
> -extern const struct kobj_type of_node_ktype;
> -extern const struct fwnode_operations of_fwnode_ops;
>  static inline void of_node_init(struct device_node *node)
>  {
>  #if defined(CONFIG_OF_KOBJ)

-- 
~Randy

Re: [PATCH] of: fix htmldocs build warning

[Randy Dunlap]

Hi--

On 3/9/23 20:52, Randy Dunlap wrote:
> 
> 
> On 3/9/23 16:32, Stephen Rothwell wrote:
>>
>> Fix this htmldoc build warning:
>>
>> include/linux/of.h:115: warning: cannot understand function prototype: 'const struct kobj_type of_node_ktype; '
>>
>> Reported by: Stephen Rothwell <sfr@canb.auug.org.au>
>> Fixes: 39459ce717b8 ("of: dynamic: add lifecycle docbook info to node creation functions")
>> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> 

Can we get Stephen's patch merged, please?
Thanks.

> 
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> Tested-by: Randy Dunlap <rdunlap@infradead.org>
> Thanks.
> 
> After this patch, there is another warning for this function:
> 
> ../include/linux/of.h:118: warning: Excess function parameter 'phandle_name' description in 'of_node_init'
> 
>> ---
>>  include/linux/of.h | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> This is actually untested, but seems pretty straight forward.
>>
>> diff --git a/include/linux/of.h b/include/linux/of.h
>> index 0af611307db2..814d33f3835a 100644
>> --- a/include/linux/of.h
>> +++ b/include/linux/of.h
>> @@ -100,6 +100,9 @@ struct of_reconfig_data {
>>  	struct property		*old_prop;
>>  };
>>  
>> +extern const struct kobj_type of_node_ktype;
>> +extern const struct fwnode_operations of_fwnode_ops;
>> +
>>  /**
>>   * of_node_init - initialize a devicetree node
>>   * @node: Pointer to device node that has been created by kzalloc()
>> @@ -111,9 +114,6 @@ struct of_reconfig_data {
>>   * whether to free the memory will be done by node->release(), which is
>>   * of_node_release().
>>   */
>> -/* initialize a node */
>> -extern const struct kobj_type of_node_ktype;
>> -extern const struct fwnode_operations of_fwnode_ops;
>>  static inline void of_node_init(struct device_node *node)
>>  {
>>  #if defined(CONFIG_OF_KOBJ)
> 

-- 
~Randy

[PATCH] of: fix htmldocs build warnings

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1793 bytes --]

Fix these htmldoc build warnings:

include/linux/of.h:115: warning: cannot understand function prototype: 'const struct kobj_type of_node_ktype; '
include/linux/of.h:118: warning: Excess function parameter 'phandle_name' description in 'of_node_init'

Reported by: Stephen Rothwell <sfr@canb.auug.org.au>
Reported by: Randy Dunlap <rdunlap@infradead.org>
Fixes: 39459ce717b8 ("of: dynamic: add lifecycle docbook info to node creation functions")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/of.h | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Replaces "[PATCH] of: fix htmldocs build warning" and additionally
fixes the new warning about phandle that Randy reported.

diff --git a/include/linux/of.h b/include/linux/of.h
index 9b7a99499ef3..d55dab9ad728 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -100,10 +100,12 @@ struct of_reconfig_data {
 	struct property		*old_prop;
 };
 
+extern const struct kobj_type of_node_ktype;
+extern const struct fwnode_operations of_fwnode_ops;
+
 /**
  * of_node_init - initialize a devicetree node
  * @node: Pointer to device node that has been created by kzalloc()
- * @phandle_name: Name of property holding a phandle value
  *
  * On return the device_node refcount is set to one.  Use of_node_put()
  * on @node when done to free the memory allocated for it.  If the node
@@ -111,9 +113,6 @@ struct of_reconfig_data {
  * whether to free the memory will be done by node->release(), which is
  * of_node_release().
  */
-/* initialize a node */
-extern const struct kobj_type of_node_ktype;
-extern const struct fwnode_operations of_fwnode_ops;
 static inline void of_node_init(struct device_node *node)
 {
 #if defined(CONFIG_OF_KOBJ)
-- 
2.39.2

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] of: fix htmldocs build warnings

[Randy Dunlap]

On 3/22/23 00:00, Stephen Rothwell wrote:
> Fix these htmldoc build warnings:
> 
> include/linux/of.h:115: warning: cannot understand function prototype: 'const struct kobj_type of_node_ktype; '
> include/linux/of.h:118: warning: Excess function parameter 'phandle_name' description in 'of_node_init'
> 
> Reported by: Stephen Rothwell <sfr@canb.auug.org.au>
> Reported by: Randy Dunlap <rdunlap@infradead.org>
> Fixes: 39459ce717b8 ("of: dynamic: add lifecycle docbook info to node creation functions")
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>


Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  include/linux/of.h | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> Replaces "[PATCH] of: fix htmldocs build warning" and additionally
> fixes the new warning about phandle that Randy reported.
> 
> diff --git a/include/linux/of.h b/include/linux/of.h
> index 9b7a99499ef3..d55dab9ad728 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -100,10 +100,12 @@ struct of_reconfig_data {
>  	struct property		*old_prop;
>  };
>  
> +extern const struct kobj_type of_node_ktype;
> +extern const struct fwnode_operations of_fwnode_ops;
> +
>  /**
>   * of_node_init - initialize a devicetree node
>   * @node: Pointer to device node that has been created by kzalloc()
> - * @phandle_name: Name of property holding a phandle value
>   *
>   * On return the device_node refcount is set to one.  Use of_node_put()
>   * on @node when done to free the memory allocated for it.  If the node
> @@ -111,9 +113,6 @@ struct of_reconfig_data {
>   * whether to free the memory will be done by node->release(), which is
>   * of_node_release().
>   */
> -/* initialize a node */
> -extern const struct kobj_type of_node_ktype;
> -extern const struct fwnode_operations of_fwnode_ops;
>  static inline void of_node_init(struct device_node *node)
>  {
>  #if defined(CONFIG_OF_KOBJ)

-- 
~Randy

Re: [PATCH] of: fix htmldocs build warnings

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2256 bytes --]

Hi Rob,

On Wed, 22 Mar 2023 11:50:53 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 3/22/23 00:00, Stephen Rothwell wrote:
> > Fix these htmldoc build warnings:
> > 
> > include/linux/of.h:115: warning: cannot understand function prototype: 'const struct kobj_type of_node_ktype; '
> > include/linux/of.h:118: warning: Excess function parameter 'phandle_name' description in 'of_node_init'
> > 
> > Reported by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Reported by: Randy Dunlap <rdunlap@infradead.org>
> > Fixes: 39459ce717b8 ("of: dynamic: add lifecycle docbook info to node creation functions")
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>  
> 
> 
> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
> 
> Thanks.
> 
> > ---
> >  include/linux/of.h | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> > 
> > Replaces "[PATCH] of: fix htmldocs build warning" and additionally
> > fixes the new warning about phandle that Randy reported.
> > 
> > diff --git a/include/linux/of.h b/include/linux/of.h
> > index 9b7a99499ef3..d55dab9ad728 100644
> > --- a/include/linux/of.h
> > +++ b/include/linux/of.h
> > @@ -100,10 +100,12 @@ struct of_reconfig_data {
> >  	struct property		*old_prop;
> >  };
> >  
> > +extern const struct kobj_type of_node_ktype;
> > +extern const struct fwnode_operations of_fwnode_ops;
> > +
> >  /**
> >   * of_node_init - initialize a devicetree node
> >   * @node: Pointer to device node that has been created by kzalloc()
> > - * @phandle_name: Name of property holding a phandle value
> >   *
> >   * On return the device_node refcount is set to one.  Use of_node_put()
> >   * on @node when done to free the memory allocated for it.  If the node
> > @@ -111,9 +113,6 @@ struct of_reconfig_data {
> >   * whether to free the memory will be done by node->release(), which is
> >   * of_node_release().
> >   */
> > -/* initialize a node */
> > -extern const struct kobj_type of_node_ktype;
> > -extern const struct fwnode_operations of_fwnode_ops;
> >  static inline void of_node_init(struct device_node *node)
> >  {
> >  #if defined(CONFIG_OF_KOBJ)  

I am still getting the above warnings :-(
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] of: fix htmldocs build warnings

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2059 bytes --]

Hi Rob,

On Wed, 22 Mar 2023 18:00:32 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Fix these htmldoc build warnings:
> 
> include/linux/of.h:115: warning: cannot understand function prototype: 'const struct kobj_type of_node_ktype; '
> include/linux/of.h:118: warning: Excess function parameter 'phandle_name' description in 'of_node_init'
> 
> Reported by: Stephen Rothwell <sfr@canb.auug.org.au>
> Reported by: Randy Dunlap <rdunlap@infradead.org>
> Fixes: 39459ce717b8 ("of: dynamic: add lifecycle docbook info to node creation functions")
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  include/linux/of.h | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> Replaces "[PATCH] of: fix htmldocs build warning" and additionally
> fixes the new warning about phandle that Randy reported.
> 
> diff --git a/include/linux/of.h b/include/linux/of.h
> index 9b7a99499ef3..d55dab9ad728 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -100,10 +100,12 @@ struct of_reconfig_data {
>  	struct property		*old_prop;
>  };
>  
> +extern const struct kobj_type of_node_ktype;
> +extern const struct fwnode_operations of_fwnode_ops;
> +
>  /**
>   * of_node_init - initialize a devicetree node
>   * @node: Pointer to device node that has been created by kzalloc()
> - * @phandle_name: Name of property holding a phandle value
>   *
>   * On return the device_node refcount is set to one.  Use of_node_put()
>   * on @node when done to free the memory allocated for it.  If the node
> @@ -111,9 +113,6 @@ struct of_reconfig_data {
>   * whether to free the memory will be done by node->release(), which is
>   * of_node_release().
>   */
> -/* initialize a node */
> -extern const struct kobj_type of_node_ktype;
> -extern const struct fwnode_operations of_fwnode_ops;
>  static inline void of_node_init(struct device_node *node)
>  {
>  #if defined(CONFIG_OF_KOBJ)
> -- 
> 2.39.2

Any chance if this patch being applied?

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] of: fix htmldocs build warnings

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2368 bytes --]

Hi all,

On Thu, 13 Jul 2023 16:10:38 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Wed, 22 Mar 2023 18:00:32 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Fix these htmldoc build warnings:
> > 
> > include/linux/of.h:115: warning: cannot understand function prototype: 'const struct kobj_type of_node_ktype; '
> > include/linux/of.h:118: warning: Excess function parameter 'phandle_name' description in 'of_node_init'
> > 
> > Reported by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Reported by: Randy Dunlap <rdunlap@infradead.org>
> > Fixes: 39459ce717b8 ("of: dynamic: add lifecycle docbook info to node creation functions")
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > ---
> >  include/linux/of.h | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> > 
> > Replaces "[PATCH] of: fix htmldocs build warning" and additionally
> > fixes the new warning about phandle that Randy reported.
> > 
> > diff --git a/include/linux/of.h b/include/linux/of.h
> > index 9b7a99499ef3..d55dab9ad728 100644
> > --- a/include/linux/of.h
> > +++ b/include/linux/of.h
> > @@ -100,10 +100,12 @@ struct of_reconfig_data {
> >  	struct property		*old_prop;
> >  };
> >  
> > +extern const struct kobj_type of_node_ktype;
> > +extern const struct fwnode_operations of_fwnode_ops;
> > +
> >  /**
> >   * of_node_init - initialize a devicetree node
> >   * @node: Pointer to device node that has been created by kzalloc()
> > - * @phandle_name: Name of property holding a phandle value
> >   *
> >   * On return the device_node refcount is set to one.  Use of_node_put()
> >   * on @node when done to free the memory allocated for it.  If the node
> > @@ -111,9 +113,6 @@ struct of_reconfig_data {
> >   * whether to free the memory will be done by node->release(), which is
> >   * of_node_release().
> >   */
> > -/* initialize a node */
> > -extern const struct kobj_type of_node_ktype;
> > -extern const struct fwnode_operations of_fwnode_ops;
> >  static inline void of_node_init(struct device_node *node)
> >  {
> >  #if defined(CONFIG_OF_KOBJ)
> > -- 
> > 2.39.2  
> 
> Any chance if this patch being applied?

Is there something wrong with the patch?

P.S. Rob, should I use your kernel.org address as your linux-next
contact?
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] of: fix htmldocs build warnings

[Rob Herring]

On Mon, Jul 24, 2023 at 01:55:13PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> On Thu, 13 Jul 2023 16:10:38 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Wed, 22 Mar 2023 18:00:32 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > Fix these htmldoc build warnings:
> > > 
> > > include/linux/of.h:115: warning: cannot understand function prototype: 'const struct kobj_type of_node_ktype; '
> > > include/linux/of.h:118: warning: Excess function parameter 'phandle_name' description in 'of_node_init'
> > > 
> > > Reported by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > Reported by: Randy Dunlap <rdunlap@infradead.org>
> > > Fixes: 39459ce717b8 ("of: dynamic: add lifecycle docbook info to node creation functions")
> > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > ---
> > >  include/linux/of.h | 7 +++----
> > >  1 file changed, 3 insertions(+), 4 deletions(-)
> > > 
> > > Replaces "[PATCH] of: fix htmldocs build warning" and additionally
> > > fixes the new warning about phandle that Randy reported.
> > > 
> > > diff --git a/include/linux/of.h b/include/linux/of.h
> > > index 9b7a99499ef3..d55dab9ad728 100644
> > > --- a/include/linux/of.h
> > > +++ b/include/linux/of.h
> > > @@ -100,10 +100,12 @@ struct of_reconfig_data {
> > >  	struct property		*old_prop;
> > >  };
> > >  
> > > +extern const struct kobj_type of_node_ktype;
> > > +extern const struct fwnode_operations of_fwnode_ops;
> > > +
> > >  /**
> > >   * of_node_init - initialize a devicetree node
> > >   * @node: Pointer to device node that has been created by kzalloc()
> > > - * @phandle_name: Name of property holding a phandle value
> > >   *
> > >   * On return the device_node refcount is set to one.  Use of_node_put()
> > >   * on @node when done to free the memory allocated for it.  If the node
> > > @@ -111,9 +113,6 @@ struct of_reconfig_data {
> > >   * whether to free the memory will be done by node->release(), which is
> > >   * of_node_release().
> > >   */
> > > -/* initialize a node */
> > > -extern const struct kobj_type of_node_ktype;
> > > -extern const struct fwnode_operations of_fwnode_ops;
> > >  static inline void of_node_init(struct device_node *node)
> > >  {
> > >  #if defined(CONFIG_OF_KOBJ)
> > > -- 
> > > 2.39.2  
> > 
> > Any chance if this patch being applied?
> 
> Is there something wrong with the patch?

Sorry, missed this one. Now applied. If it's not sent to DT list and 
into PW, then it's a gamble when/if I see it.

> P.S. Rob, should I use your kernel.org address as your linux-next
> contact?

Yes.

Rob