Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Fixes tag needs some work in the xen-tip tree
@ 2021-04-06 21:35 Stephen Rothwell
  2021-04-06 23:15 ` Boris Ostrovsky
  0 siblings, 1 reply; 8+ messages in thread
From: Stephen Rothwell @ 2021-04-06 21:35 UTC (permalink / raw)
  To: Juergen Gross, Konrad Rzeszutek Wilk, Stefano Stabellini,
	Boris Ostrovsky, Xen Devel
  Cc: Luca Fancellu, Linux Kernel Mailing List, Linux Next Mailing List


[-- Attachment #1: Type: text/plain, Size: 488 bytes --]

Hi all,

In commit

  da3b45cbcb0f ("xen/evtchn: Change irq_info lock to raw_spinlock_t")

Fixes tag

  Fixes: 25da4618af24 ("xen/events: don't unmask an event channel

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.  Also, please
keep all the commit message tags together at the end of te commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: linux-next: Fixes tag needs some work in the xen-tip tree
  2021-04-06 21:35 linux-next: Fixes tag needs some work in the xen-tip tree Stephen Rothwell
@ 2021-04-06 23:15 ` Boris Ostrovsky
  0 siblings, 0 replies; 8+ messages in thread
From: Boris Ostrovsky @ 2021-04-06 23:15 UTC (permalink / raw)
  To: Stephen Rothwell, Juergen Gross, Konrad Rzeszutek Wilk,
	Stefano Stabellini, Xen Devel
  Cc: Luca Fancellu, Linux Kernel Mailing List, Linux Next Mailing List


On 4/6/21 5:35 PM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
>   da3b45cbcb0f ("xen/evtchn: Change irq_info lock to raw_spinlock_t")
>
> Fixes tag
>
>   Fixes: 25da4618af24 ("xen/events: don't unmask an event channel
>
> has these problem(s):
>
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than one line.  Also, please
> keep all the commit message tags together at the end of te commit message.



Thanks, fixed.



-boris


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: linux-next: Fixes tag needs some work in the xen-tip tree
  2021-03-10 21:23 Stephen Rothwell
@ 2021-03-10 22:36 ` Boris Ostrovsky
  0 siblings, 0 replies; 8+ messages in thread
From: Boris Ostrovsky @ 2021-03-10 22:36 UTC (permalink / raw)
  To: Stephen Rothwell, Juergen Gross, Konrad Rzeszutek Wilk,
	Stefano Stabellini, Xen Devel
  Cc: Linux Kernel Mailing List, Linux Next Mailing List


On 3/10/21 4:23 PM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
>   1103e2826a9f ("xen/events: don't unmask an event channel when an eoi is pending")
>
> Fixes tag
>
>   Fixes: 54c9de89895e0a36047 ("xen/events: add a new late EOI evtchn framework")
>
> has these problem(s):
>
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'


Sigh... Missed this again. Updated to


   Fixes: 54c9de89895e ("xen/events: add a new "late EOI" evtchn framework")


-boris



^ permalink raw reply	[flat|nested] 8+ messages in thread

* linux-next: Fixes tag needs some work in the xen-tip tree
@ 2021-03-10 21:23 Stephen Rothwell
  2021-03-10 22:36 ` Boris Ostrovsky
  0 siblings, 1 reply; 8+ messages in thread
From: Stephen Rothwell @ 2021-03-10 21:23 UTC (permalink / raw)
  To: Juergen Gross, Konrad Rzeszutek Wilk, Stefano Stabellini,
	Boris Ostrovsky, Xen Devel
  Cc: Linux Kernel Mailing List, Linux Next Mailing List


[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

Hi all,

In commit

  1103e2826a9f ("xen/events: don't unmask an event channel when an eoi is pending")

Fixes tag

  Fixes: 54c9de89895e0a36047 ("xen/events: add a new late EOI evtchn framework")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: linux-next: Fixes tag needs some work in the xen-tip tree
  2021-02-22 21:03 Stephen Rothwell
@ 2021-02-22 21:35 ` Boris Ostrovsky
  0 siblings, 0 replies; 8+ messages in thread
From: Boris Ostrovsky @ 2021-02-22 21:35 UTC (permalink / raw)
  To: Stephen Rothwell, Juergen Gross, Konrad Rzeszutek Wilk,
	Stefano Stabellini, Xen Devel
  Cc: Linux Kernel Mailing List, Linux Next Mailing List


On 2/22/21 4:03 PM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
>   99bbb6e0b436 ("xen/events: don't unmask an event channel when an eoi is pending")
>
> Fixes tag
>
>   Fixes: 54c9de89895e0a36047 ("xen/events: add a new late EOI evtchn framework")
>
> has these problem(s):
>
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'


Yes, it lost quotes:


   Fixes: 54c9de89895e ("xen/events: add a new "late EOI" evtchn framework")


Thanks.

-boris


^ permalink raw reply	[flat|nested] 8+ messages in thread

* linux-next: Fixes tag needs some work in the xen-tip tree
@ 2021-02-22 21:03 Stephen Rothwell
  2021-02-22 21:35 ` Boris Ostrovsky
  0 siblings, 1 reply; 8+ messages in thread
From: Stephen Rothwell @ 2021-02-22 21:03 UTC (permalink / raw)
  To: Juergen Gross, Konrad Rzeszutek Wilk, Stefano Stabellini,
	Boris Ostrovsky, Xen Devel
  Cc: Linux Kernel Mailing List, Linux Next Mailing List


[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

Hi all,

In commit

  99bbb6e0b436 ("xen/events: don't unmask an event channel when an eoi is pending")

Fixes tag

  Fixes: 54c9de89895e0a36047 ("xen/events: add a new late EOI evtchn framework")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* linux-next: Fixes tag needs some work in the xen-tip tree
@ 2020-08-13 22:07 Stephen Rothwell
  0 siblings, 0 replies; 8+ messages in thread
From: Stephen Rothwell @ 2020-08-13 22:07 UTC (permalink / raw)
  To: Juergen Gross, Konrad Rzeszutek Wilk, Stefano Stabellini,
	Boris Ostrovsky, Xen Devel
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Oleksandr Andrushchenko


[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

Hi all,

In commit

  14dee0586104 ("drm/xen-front: Fix misused IS_ERR_OR_NULL checks")

Fixes tag

  Fixes:  c575b7eeb89f: "drm/xen-front: Add support for Xen PV display frontend"

has these problem(s):

  - missing space between the SHA1 and the subject
  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Fixes: c575b7eeb89f ("drm/xen-front: Add support for Xen PV display frontend")

Also, please keep all the commit message tags together at the end of
the commit message.

Not worth rebasing over, just to remember for next time, thanks.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* linux-next: Fixes tag needs some work in the xen-tip tree
@ 2019-04-25 13:44 Stephen Rothwell
  0 siblings, 0 replies; 8+ messages in thread
From: Stephen Rothwell @ 2019-04-25 13:44 UTC (permalink / raw)
  To: Juergen Gross, Konrad Rzeszutek Wilk, Stefano Stabellini,
	Boris Ostrovsky, Xen Devel
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Mao Wenan


[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

Hi all,

In commit

  8a46b39f3aff ("xenbus: drop useless LIST_HEAD in xenbus_write_watch() and xenbus_file_write()")

Fixes tag

  Fixes: 1107ba885e469("xen: add xenfs to allow usermode <-> Xen interaction")

has these problem(s):

  - missing space between the SHA1 and the subject

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, back to index

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-06 21:35 linux-next: Fixes tag needs some work in the xen-tip tree Stephen Rothwell
2021-04-06 23:15 ` Boris Ostrovsky
  -- strict thread matches above, loose matches on Subject: below --
2021-03-10 21:23 Stephen Rothwell
2021-03-10 22:36 ` Boris Ostrovsky
2021-02-22 21:03 Stephen Rothwell
2021-02-22 21:35 ` Boris Ostrovsky
2020-08-13 22:07 Stephen Rothwell
2019-04-25 13:44 Stephen Rothwell

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git