From: Randy Dunlap <rd.dunlab@gmail.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Helge Deller <deller@gmx.de>,
Javier Martinez Canillas <javierm@redhat.com>,
linux-fbdev@vger.kernel.org,
Linux PowerPC <linuxppc-dev@lists.ozlabs.org>,
Linux Regressions <regressions@lists.linux.dev>,
Geoff Levand <geoff@infradead.org>
Subject: Re: linux-next: Tree for Jul 13 (drivers/video/fbdev/ps3fb.c)
Date: Tue, 18 Jul 2023 09:15:16 -0700 [thread overview]
Message-ID: <d9616a67-23e8-118f-dc0a-7ed4afd4bffd@gmail.com> (raw)
In-Reply-To: <874jm1jv9m.fsf@mail.lhotse>
On 7/18/23 04:48, Michael Ellerman wrote:
> Bagas Sanjaya <bagasdotme@gmail.com> writes:
>> On Thu, Jul 13, 2023 at 09:11:10AM -0700, Randy Dunlap wrote:
>>> on ppc64:
>>>
>>> In file included from ../include/linux/device.h:15,
>>> from ../arch/powerpc/include/asm/io.h:22,
>>> from ../include/linux/io.h:13,
>>> from ../include/linux/irq.h:20,
>>> from ../arch/powerpc/include/asm/hardirq.h:6,
>>> from ../include/linux/hardirq.h:11,
>>> from ../include/linux/interrupt.h:11,
>>> from ../drivers/video/fbdev/ps3fb.c:25:
>>> ../drivers/video/fbdev/ps3fb.c: In function 'ps3fb_probe':
>>> ../drivers/video/fbdev/ps3fb.c:1172:40: error: 'struct fb_info' has no member named 'dev'
>>> 1172 | dev_driver_string(info->dev), dev_name(info->dev),
>>> | ^~
>>> ../include/linux/dev_printk.h:110:37: note: in definition of macro 'dev_printk_index_wrap'
>>> 110 | _p_func(dev, fmt, ##__VA_ARGS__); \
>>> | ^~~~~~~~~~~
>>> ../drivers/video/fbdev/ps3fb.c:1171:9: note: in expansion of macro 'dev_info'
>>> 1171 | dev_info(info->device, "%s %s, using %u KiB of video memory\n",
>>> | ^~~~~~~~
>>> ../drivers/video/fbdev/ps3fb.c:1172:61: error: 'struct fb_info' has no member named 'dev'
>>> 1172 | dev_driver_string(info->dev), dev_name(info->dev),
>>> | ^~
>>> ../include/linux/dev_printk.h:110:37: note: in definition of macro 'dev_printk_index_wrap'
>>> 110 | _p_func(dev, fmt, ##__VA_ARGS__); \
>>> | ^~~~~~~~~~~
>>> ../drivers/video/fbdev/ps3fb.c:1171:9: note: in expansion of macro 'dev_info'
>>> 1171 | dev_info(info->device, "%s %s, using %u KiB of video memory\n",
>>> | ^~~~~~~~
>>>
>>>
>>
>> Hmm, there is no response from Thomas yet. I guess we should go with
>> reverting bdb616479eff419, right? Regardless, I'm adding this build regression
>> to regzbot so that parties involved are aware of it:
>>
>> #regzbot ^introduced: bdb616479eff419
>> #regzbot title: build regression in PS3 framebuffer
>
> Does regzbot track issues in linux-next?
>
> They're not really regressions because they're not in a release yet.
>
> Anyway I don't see where bdb616479eff419 comes from.
>
> The issue was introduced by:
>
> 701d2054fa31 fbdev: Make support for userspace interfaces configurable
>
> The driver seems to only use info->dev in that one dev_info() line,
> which seems purely cosmetic, so I think it could just be removed, eg:
>
> diff --git a/drivers/video/fbdev/ps3fb.c b/drivers/video/fbdev/ps3fb.c
> index d4abcf8aff75..a304a39d712b 100644
> --- a/drivers/video/fbdev/ps3fb.c
> +++ b/drivers/video/fbdev/ps3fb.c
> @@ -1168,8 +1168,7 @@ static int ps3fb_probe(struct ps3_system_bus_device *dev)
>
> ps3_system_bus_set_drvdata(dev, info);
>
> - dev_info(info->device, "%s %s, using %u KiB of video memory\n",
> - dev_driver_string(info->dev), dev_name(info->dev),
> + dev_info(info->device, "using %u KiB of video memory\n",
> info->fix.smem_len >> 10);
>
> task = kthread_run(ps3fbd, info, DEVICE_NAME);
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
--
~Randy
next prev parent reply other threads:[~2023-07-18 16:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 2:37 linux-next: Tree for Jul 13 Stephen Rothwell
2023-07-13 16:11 ` linux-next: Tree for Jul 13 (drivers/video/fbdev/ps3fb.c) Randy Dunlap
2023-07-14 20:46 ` Randy Dunlap
2023-07-18 3:32 ` Bagas Sanjaya
2023-07-18 10:06 ` Thorsten Leemhuis
2023-07-19 12:36 ` Bagas Sanjaya
2023-07-19 12:48 ` Thorsten Leemhuis
2023-07-18 11:48 ` Michael Ellerman
2023-07-18 12:17 ` Linux regression tracking (Thorsten Leemhuis)
2023-07-18 16:15 ` Randy Dunlap [this message]
2023-07-31 11:53 ` Linux regression tracking (Thorsten Leemhuis)
2023-07-31 12:33 ` Helge Deller
2023-07-31 14:01 ` Thomas Zimmermann
2023-07-18 0:45 Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9616a67-23e8-118f-dc0a-7ed4afd4bffd@gmail.com \
--to=rd.dunlab@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=deller@gmx.de \
--cc=geoff@infradead.org \
--cc=javierm@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=rdunlap@infradead.org \
--cc=regressions@lists.linux.dev \
--cc=sfr@canb.auug.org.au \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).