From: Thorsten Leemhuis <regressions@leemhuis.info>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
Thomas Zimmermann <tzimmermann@suse.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Helge Deller <deller@gmx.de>,
Javier Martinez Canillas <javierm@redhat.com>,
linux-fbdev@vger.kernel.org,
Linux PowerPC <linuxppc-dev@lists.ozlabs.org>,
Linux Regressions <regressions@lists.linux.dev>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: Tree for Jul 13 (drivers/video/fbdev/ps3fb.c)
Date: Tue, 18 Jul 2023 12:06:50 +0200 [thread overview]
Message-ID: <f5e6258b-ba76-001b-4942-588f4cbb0aa7@leemhuis.info> (raw)
In-Reply-To: <ZLYHtVuS7AElXcCb@debian.me>
On 18.07.23 05:32, Bagas Sanjaya wrote:
> On Thu, Jul 13, 2023 at 09:11:10AM -0700, Randy Dunlap wrote:
>> On 7/12/23 19:37, Stephen Rothwell wrote:
>>> Changes since 20230712:
>>
>> on ppc64:
>>
>> In file included from ../include/linux/device.h:15,
>> from ../arch/powerpc/include/asm/io.h:22,
>> from ../include/linux/io.h:13,
>> from ../include/linux/irq.h:20,
>> from ../arch/powerpc/include/asm/hardirq.h:6,
>> from ../include/linux/hardirq.h:11,
>> from ../include/linux/interrupt.h:11,
>> from ../drivers/video/fbdev/ps3fb.c:25:
>> ../drivers/video/fbdev/ps3fb.c: In function 'ps3fb_probe':
>> ../drivers/video/fbdev/ps3fb.c:1172:40: error: 'struct fb_info' has no member named 'dev'
>> 1172 | dev_driver_string(info->dev), dev_name(info->dev),
>> | ^~
>> ../include/linux/dev_printk.h:110:37: note: in definition of macro 'dev_printk_index_wrap'
>> 110 | _p_func(dev, fmt, ##__VA_ARGS__); \
>> | ^~~~~~~~~~~
>> ../drivers/video/fbdev/ps3fb.c:1171:9: note: in expansion of macro 'dev_info'
>> 1171 | dev_info(info->device, "%s %s, using %u KiB of video memory\n",
>> | ^~~~~~~~
>> ../drivers/video/fbdev/ps3fb.c:1172:61: error: 'struct fb_info' has no member named 'dev'
>> 1172 | dev_driver_string(info->dev), dev_name(info->dev),
>> | ^~
>> ../include/linux/dev_printk.h:110:37: note: in definition of macro 'dev_printk_index_wrap'
>> 110 | _p_func(dev, fmt, ##__VA_ARGS__); \
>> | ^~~~~~~~~~~
>> ../drivers/video/fbdev/ps3fb.c:1171:9: note: in expansion of macro 'dev_info'
>> 1171 | dev_info(info->device, "%s %s, using %u KiB of video memory\n",
>> | ^~~~~~~~
>
> Hmm, there is no response from Thomas yet. I guess we should go with
> reverting bdb616479eff419, right?
I'm missing something here:
* What makes you think this is caused by bdb616479eff419? I didn't see
anything in the thread that claims this, but I might be missing something
* related: if I understand Randy right, this is only happening in -next;
so why is bdb616479eff419 the culprit, which is also in mainline since
End of June?
And asking for a revert already is a bit jumping the gun; sure, it would
be good to get this fixed, but remember: developers have a lot on their
plate and thus sometimes are forced to set priorities; they also
sometimes go on vacation or are afk for other reasons; and sometimes
they just miss a mail or two. These are just a few reasons why there
might be good reasons why Thomas didn't look into this yet, hence please
first ask really kindly before asking for a revert.
Ciao, Thorsten
next prev parent reply other threads:[~2023-07-18 10:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 2:37 linux-next: Tree for Jul 13 Stephen Rothwell
2023-07-13 16:11 ` linux-next: Tree for Jul 13 (drivers/video/fbdev/ps3fb.c) Randy Dunlap
2023-07-14 20:46 ` Randy Dunlap
2023-07-18 3:32 ` Bagas Sanjaya
2023-07-18 10:06 ` Thorsten Leemhuis [this message]
2023-07-19 12:36 ` Bagas Sanjaya
2023-07-19 12:48 ` Thorsten Leemhuis
2023-07-18 11:48 ` Michael Ellerman
2023-07-18 12:17 ` Linux regression tracking (Thorsten Leemhuis)
2023-07-18 16:15 ` Randy Dunlap
2023-07-31 11:53 ` Linux regression tracking (Thorsten Leemhuis)
2023-07-31 12:33 ` Helge Deller
2023-07-31 14:01 ` Thomas Zimmermann
2023-07-18 0:45 Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5e6258b-ba76-001b-4942-588f4cbb0aa7@leemhuis.info \
--to=regressions@leemhuis.info \
--cc=bagasdotme@gmail.com \
--cc=deller@gmx.de \
--cc=javierm@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rdunlap@infradead.org \
--cc=regressions@lists.linux.dev \
--cc=sfr@canb.auug.org.au \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).