* [PATCH] lpfc: add missing Kconfig NVME dependencies
@ 2017-02-22 16:20 James Smart
2017-02-22 19:35 ` Sagi Grimberg
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: James Smart @ 2017-02-22 16:20 UTC (permalink / raw)
To: hare, martin.petersen, dick.kennedy, linux-next, sfr, linux-nvme,
sagi, linux-scsi
add missing Kconfig NVME dependencies
Can't believe I missed posting this
-- james
Signed-off-by: James Smart <james.smart@broadcom.com>
---
drivers/scsi/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index d4023bf..2558434 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -1240,6 +1240,7 @@ config SCSI_LPFC
tristate "Emulex LightPulse Fibre Channel Support"
depends on PCI && SCSI
depends on SCSI_FC_ATTRS
+ depends on NVME_FC && NVME_TARGET_FC
select CRC_T10DIF
help
This lpfc driver supports the Emulex LightPulse
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] lpfc: add missing Kconfig NVME dependencies
2017-02-22 16:20 [PATCH] lpfc: add missing Kconfig NVME dependencies James Smart
@ 2017-02-22 19:35 ` Sagi Grimberg
2017-02-23 10:09 ` Christoph Hellwig
2018-02-15 19:00 ` Ewan D. Milne
2 siblings, 0 replies; 6+ messages in thread
From: Sagi Grimberg @ 2017-02-22 19:35 UTC (permalink / raw)
To: James Smart, hare, martin.petersen, dick.kennedy, linux-next,
sfr, linux-nvme, linux-scsi
> add missing Kconfig NVME dependencies
>
> Can't believe I missed posting this
>
> -- james
Heh, the this sort of comment should come after
the '---' separator (below) unless you want it to live forever
in the git log...
>
> Signed-off-by: James Smart <james.smart@broadcom.com>
> ---
[here]
> drivers/scsi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index d4023bf..2558434 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -1240,6 +1240,7 @@ config SCSI_LPFC
> tristate "Emulex LightPulse Fibre Channel Support"
> depends on PCI && SCSI
> depends on SCSI_FC_ATTRS
> + depends on NVME_FC && NVME_TARGET_FC
> select CRC_T10DIF
> help
> This lpfc driver supports the Emulex LightPulse
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] lpfc: add missing Kconfig NVME dependencies
2017-02-22 16:20 [PATCH] lpfc: add missing Kconfig NVME dependencies James Smart
2017-02-22 19:35 ` Sagi Grimberg
@ 2017-02-23 10:09 ` Christoph Hellwig
2017-02-23 15:51 ` James Smart
2018-02-15 19:00 ` Ewan D. Milne
2 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2017-02-23 10:09 UTC (permalink / raw)
To: James Smart
Cc: hare, martin.petersen, dick.kennedy, linux-next, sfr, linux-nvme,
sagi, linux-scsi
On Wed, Feb 22, 2017 at 08:20:47AM -0800, James Smart wrote:
>
> add missing Kconfig NVME dependencies
>
> Can't believe I missed posting this
Oh. I'm not sure everyone is happy having to drag in the whole
nvme and nvme target stack when building lpfc. Is there a way
to make nvme optional? And in the future scsi as well?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] lpfc: add missing Kconfig NVME dependencies
2017-02-23 10:09 ` Christoph Hellwig
@ 2017-02-23 15:51 ` James Smart
0 siblings, 0 replies; 6+ messages in thread
From: James Smart @ 2017-02-23 15:51 UTC (permalink / raw)
To: Christoph Hellwig
Cc: hare, martin.petersen, dick.kennedy, linux-next, sfr, linux-nvme,
sagi, linux-scsi
On 2/23/2017 2:09 AM, Christoph Hellwig wrote:
> On Wed, Feb 22, 2017 at 08:20:47AM -0800, James Smart wrote:
>> add missing Kconfig NVME dependencies
>>
>> Can't believe I missed posting this
> Oh. I'm not sure everyone is happy having to drag in the whole
> nvme and nvme target stack when building lpfc. Is there a way
> to make nvme optional? And in the future scsi as well?
yes - I'll work on doing that. Scsi is a little further off as the fc
transport has to be dealt with - moved out from under scsi and put above
scsi and nvme in the device tree. The transport is where the hooks for
adapter mgmt are right now.
-- james
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] lpfc: add missing Kconfig NVME dependencies
2017-02-22 16:20 [PATCH] lpfc: add missing Kconfig NVME dependencies James Smart
2017-02-22 19:35 ` Sagi Grimberg
2017-02-23 10:09 ` Christoph Hellwig
@ 2018-02-15 19:00 ` Ewan D. Milne
2018-02-15 19:02 ` Ewan D. Milne
2 siblings, 1 reply; 6+ messages in thread
From: Ewan D. Milne @ 2018-02-15 19:00 UTC (permalink / raw)
To: James Smart
Cc: hare, martin.petersen, dick.kennedy, linux-next, sfr, linux-nvme,
sagi, linux-scsi
On Wed, 2017-02-22 at 08:20 -0800, James Smart wrote:
> add missing Kconfig NVME dependencies
>
> Can't believe I missed posting this
>
> -- james
>
> Signed-off-by: James Smart <james.smart@broadcom.com>
> ---
> drivers/scsi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index d4023bf..2558434 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -1240,6 +1240,7 @@ config SCSI_LPFC
> tristate "Emulex LightPulse Fibre Channel Support"
> depends on PCI && SCSI
> depends on SCSI_FC_ATTRS
> + depends on NVME_FC && NVME_TARGET_FC
> select CRC_T10DIF
> help
> This lpfc driver supports the Emulex LightPulse
I thought this was why you had
#if (IS_ENABLED(CONFIG_NVME_FC))
#if (IS_ENABLED(CONFIG_NVME_TARGET_FC))
at various places in the lpfc driver. Do you actually depend
on having NVME_FC and NVME_TARGET_FC, or do you selectively
include code if they are config'ed in?
Or do you want to force-enable it at this point?
-Ewan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] lpfc: add missing Kconfig NVME dependencies
2018-02-15 19:00 ` Ewan D. Milne
@ 2018-02-15 19:02 ` Ewan D. Milne
0 siblings, 0 replies; 6+ messages in thread
From: Ewan D. Milne @ 2018-02-15 19:02 UTC (permalink / raw)
To: James Smart
Cc: hare, martin.petersen, dick.kennedy, linux-next, sfr, linux-nvme,
sagi, linux-scsi
On Thu, 2018-02-15 at 14:00 -0500, Ewan D. Milne wrote:
> On Wed, 2017-02-22 at 08:20 -0800, James Smart wrote:
> > add missing Kconfig NVME dependencies
> >
> > Can't believe I missed posting this
> >
> > -- james
> >
> > Signed-off-by: James Smart <james.smart@broadcom.com>
> > ---
> > drivers/scsi/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> > index d4023bf..2558434 100644
> > --- a/drivers/scsi/Kconfig
> > +++ b/drivers/scsi/Kconfig
> > @@ -1240,6 +1240,7 @@ config SCSI_LPFC
> > tristate "Emulex LightPulse Fibre Channel Support"
> > depends on PCI && SCSI
> > depends on SCSI_FC_ATTRS
> > + depends on NVME_FC && NVME_TARGET_FC
> > select CRC_T10DIF
> > help
> > This lpfc driver supports the Emulex LightPulse
>
> I thought this was why you had
>
> #if (IS_ENABLED(CONFIG_NVME_FC))
> #if (IS_ENABLED(CONFIG_NVME_TARGET_FC))
>
> at various places in the lpfc driver. Do you actually depend
> on having NVME_FC and NVME_TARGET_FC, or do you selectively
> include code if they are config'ed in?
>
> Or do you want to force-enable it at this point?
>
> -Ewan
>
Sorry, never mind, accidentally to very old mail message.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-15 19:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-22 16:20 [PATCH] lpfc: add missing Kconfig NVME dependencies James Smart
2017-02-22 19:35 ` Sagi Grimberg
2017-02-23 10:09 ` Christoph Hellwig
2017-02-23 15:51 ` James Smart
2018-02-15 19:00 ` Ewan D. Milne
2018-02-15 19:02 ` Ewan D. Milne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).