* next: mips: cavium_octeon_defconfig failed - drivers/staging/octeon/ethernet.c:204:37: error: storage size of 'rx_status' isn't known
@ 2023-09-29 7:03 Naresh Kamboju
2023-09-29 14:18 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Naresh Kamboju @ 2023-09-29 7:03 UTC (permalink / raw)
To: Linux-Next Mailing List, linux-mips, linux-staging
Cc: Oliver Crumrine, Uwe Kleine-König
The mips cavium_octeon_defconfig builds failing on Linux next from
Sept 19th tag.
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Build log:
--------
drivers/staging/octeon/ethernet.c: In function 'cvm_oct_common_get_stats':
drivers/staging/octeon/ethernet.c:204:37: error: storage size of
'rx_status' isn't known
204 | struct cvmx_pip_port_status rx_status;
| ^~~~~~~~~
drivers/staging/octeon/ethernet.c:205:37: error: storage size of
'tx_status' isn't known
205 | struct cvmx_pko_port_status tx_status;
| ^~~~~~~~~
drivers/staging/octeon/ethernet.c:205:37: warning: unused variable
'tx_status' [-Wunused-variable]
drivers/staging/octeon/ethernet.c:204:37: warning: unused variable
'rx_status' [-Wunused-variable]
204 | struct cvmx_pip_port_status rx_status;
| ^~~~~~~~~
drivers/staging/octeon/ethernet.c: In function 'cvm_oct_probe':
drivers/staging/octeon/ethernet.c:801:22: error: variable 'imode' has
initializer but incomplete type
801 | enum cvmx_helper_interface_mode imode =
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/staging/octeon/ethernet.c:801:49: error: storage size of
'imode' isn't known
801 | enum cvmx_helper_interface_mode imode =
| ^~~~~
drivers/staging/octeon/ethernet.c:801:49: warning: unused variable
'imode' [-Wunused-variable]
make[6]: *** [scripts/Makefile.build:243:
drivers/staging/octeon/ethernet.o] Error 1
make[6]: Target 'drivers/staging/octeon/' not remade because of errors.
make[5]: *** [scripts/Makefile.build:480: drivers/staging/octeon] Error 2
Links:
- https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230928/testrun/20145550/suite/build/test/gcc-12-cavium_octeon_defconfig/log
- https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230928/testrun/20145550/suite/build/test/gcc-12-cavium_octeon_defconfig/details/
- https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230928/testrun/20145550/suite/build/test/gcc-12-cavium_octeon_defconfig/history/
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: next: mips: cavium_octeon_defconfig failed - drivers/staging/octeon/ethernet.c:204:37: error: storage size of 'rx_status' isn't known
2023-09-29 7:03 next: mips: cavium_octeon_defconfig failed - drivers/staging/octeon/ethernet.c:204:37: error: storage size of 'rx_status' isn't known Naresh Kamboju
@ 2023-09-29 14:18 ` Dan Carpenter
2023-09-29 14:39 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2023-09-29 14:18 UTC (permalink / raw)
To: Naresh Kamboju
Cc: Linux-Next Mailing List, linux-mips, linux-staging,
Oliver Crumrine, Uwe Kleine-König
This is weird.
I managed to reproduce this once but couldn't reproduce it again after
that. It seems like an intermittent thing to me.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: next: mips: cavium_octeon_defconfig failed - drivers/staging/octeon/ethernet.c:204:37: error: storage size of 'rx_status' isn't known
2023-09-29 14:18 ` Dan Carpenter
@ 2023-09-29 14:39 ` Dan Carpenter
2023-09-29 14:43 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2023-09-29 14:39 UTC (permalink / raw)
To: Naresh Kamboju
Cc: Linux-Next Mailing List, linux-mips, linux-staging,
Oliver Crumrine, Uwe Kleine-König
On Fri, Sep 29, 2023 at 05:18:31PM +0300, Dan Carpenter wrote:
> This is weird.
>
> I managed to reproduce this once but couldn't reproduce it again after
> that. It seems like an intermittent thing to me.
Nope. I'm just dumb.
Commit b33a296d8311 ("staging: octeon: remove typedef in structs
cvmx_pip_port_status_t and cvmx_pko_port_status_t") updated
drivers/staging/octeon/octeon-stubs.h but didn't update
arch/mips/include/asm/octeon/cvmx-pip.h.
I can send a patch for that.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: next: mips: cavium_octeon_defconfig failed - drivers/staging/octeon/ethernet.c:204:37: error: storage size of 'rx_status' isn't known
2023-09-29 14:39 ` Dan Carpenter
@ 2023-09-29 14:43 ` Dan Carpenter
2023-09-29 14:45 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2023-09-29 14:43 UTC (permalink / raw)
To: Naresh Kamboju
Cc: Linux-Next Mailing List, linux-mips, linux-staging,
Oliver Crumrine, Uwe Kleine-König
On Fri, Sep 29, 2023 at 05:39:46PM +0300, Dan Carpenter wrote:
> On Fri, Sep 29, 2023 at 05:18:31PM +0300, Dan Carpenter wrote:
> > This is weird.
> >
> > I managed to reproduce this once but couldn't reproduce it again after
> > that. It seems like an intermittent thing to me.
>
> Nope. I'm just dumb.
>
> Commit b33a296d8311 ("staging: octeon: remove typedef in structs
> cvmx_pip_port_status_t and cvmx_pko_port_status_t") updated
> drivers/staging/octeon/octeon-stubs.h but didn't update
> arch/mips/include/asm/octeon/cvmx-pip.h.
>
> I can send a patch for that.
Actually, perhaps we should just revert the patch? Staging patches
aren't supposed to touch outside of the staging directory.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: next: mips: cavium_octeon_defconfig failed - drivers/staging/octeon/ethernet.c:204:37: error: storage size of 'rx_status' isn't known
2023-09-29 14:43 ` Dan Carpenter
@ 2023-09-29 14:45 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2023-09-29 14:45 UTC (permalink / raw)
To: Naresh Kamboju
Cc: Linux-Next Mailing List, linux-mips, linux-staging,
Oliver Crumrine, Uwe Kleine-König
On Fri, Sep 29, 2023 at 05:43:41PM +0300, Dan Carpenter wrote:
> On Fri, Sep 29, 2023 at 05:39:46PM +0300, Dan Carpenter wrote:
> > On Fri, Sep 29, 2023 at 05:18:31PM +0300, Dan Carpenter wrote:
> > > This is weird.
> > >
> > > I managed to reproduce this once but couldn't reproduce it again after
> > > that. It seems like an intermittent thing to me.
> >
> > Nope. I'm just dumb.
> >
> > Commit b33a296d8311 ("staging: octeon: remove typedef in structs
> > cvmx_pip_port_status_t and cvmx_pko_port_status_t") updated
> > drivers/staging/octeon/octeon-stubs.h but didn't update
> > arch/mips/include/asm/octeon/cvmx-pip.h.
> >
> > I can send a patch for that.
>
> Actually, perhaps we should just revert the patch? Staging patches
> aren't supposed to touch outside of the staging directory.
I think all of these break the build...
b33a296d8311 staging: octeon: remove typedef in structs cvmx_pip_port_status_t and cvmx_pko_port_status_t
4fffe4733cfb staging: octeon: remove typedef in enum cvmx_pko_status_t
8d26aa90458f staging: octeon: remove typedef in struct cvmx_pko_lock_t
28fae776c69b staging: octeon: remove typedef in enum cvmx_pow_wait_t
a13f7e45823c staging: octeon: remove typedef in enum cvmx_helper_interface_mode_t
7bebd8321776 staging: octeon: remove typedef in enum cvmx_spi_mode_t
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-09-29 14:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-29 7:03 next: mips: cavium_octeon_defconfig failed - drivers/staging/octeon/ethernet.c:204:37: error: storage size of 'rx_status' isn't known Naresh Kamboju
2023-09-29 14:18 ` Dan Carpenter
2023-09-29 14:39 ` Dan Carpenter
2023-09-29 14:43 ` Dan Carpenter
2023-09-29 14:45 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).