linux-next: Signed-off-by missing for commits in the block tree

linux-next: Signed-off-by missing for commits in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

Hi Jens,

Commits

  287a63ebbe7c ("nvme: mark the result argument to nvme_complete_async_event volatile")
  750dde4472e4 ("nvme-pci: simplify nvme_cqe_valid")
  d1f06f4ae041 ("nvme-pci: move ->cq_vector == -1 check outside of ->q_lock")
  1ab0cd6966fc ("nvme-pci: split the nvme queue lock into submission and completion locks")
  1eae349d18fc ("nvme-pci: drop IRQ disabling on submission queue lock")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the block tree

[Jens Axboe]

On 5/25/18 9:50 PM, Stephen Rothwell wrote:
> Hi Jens,
> 
> Commits
> 
>   287a63ebbe7c ("nvme: mark the result argument to nvme_complete_async_event volatile")
>   750dde4472e4 ("nvme-pci: simplify nvme_cqe_valid")
>   d1f06f4ae041 ("nvme-pci: move ->cq_vector == -1 check outside of ->q_lock")
>   1ab0cd6966fc ("nvme-pci: split the nvme queue lock into submission and completion locks")
>   1eae349d18fc ("nvme-pci: drop IRQ disabling on submission queue lock")
> 
> are missing a Signed-off-by from their committer.

Thanks for the heads up. Not a huge problem for these particular commits,

-- 
Jens Axboe

linux-next: Signed-off-by missing for commits in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

Hi Jens,

Commits

  837d7c7005c3 ("block: enable multi-page bvec for passthrough IO")
  df88a384baa3 ("block: pass page to xen_biovec_phys_mergeable")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the block tree

[Jens Axboe]

On 4/1/19 12:08 PM, Stephen Rothwell wrote:
> Hi Jens,
> 
> Commits
> 
>   837d7c7005c3 ("block: enable multi-page bvec for passthrough IO")
>   df88a384baa3 ("block: pass page to xen_biovec_phys_mergeable")
> 
> are missing a Signed-off-by from their committer.

That's my silly error, I'll fix that up. Thanks for letting me know.

-- 
Jens Axboe

linux-next: Signed-off-by missing for commits in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

Hi all,

Commits

  5fb4aac756ac ("nvme: release namespace SRCU protection before performing controller ioctls")
  90ec611adcf2 ("nvme: merge nvme_ns_ioctl into nvme_ioctl")
  3f98bcc58cd5 ("nvme: remove the ifdef around nvme_nvm_ioctl")
  100c815cbd56 ("nvme: fix srcu locking on error return in nvme_get_ns_from_disk")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the block tree

[Keith Busch]

On Fri, May 24, 2019 at 07:45:00AM +1000, Stephen Rothwell wrote:
> Commits
> 
>   5fb4aac756ac ("nvme: release namespace SRCU protection before performing controller ioctls")
>   90ec611adcf2 ("nvme: merge nvme_ns_ioctl into nvme_ioctl")
>   3f98bcc58cd5 ("nvme: remove the ifdef around nvme_nvm_ioctl")
>   100c815cbd56 ("nvme: fix srcu locking on error return in nvme_get_ns_from_disk")
> 
> are missing a Signed-off-by from their committer.

Oops, I'd only added my Reviewed-by. Do I need to update the commit
messages and resend, or is this just putting me on notice for next time?

Re: linux-next: Signed-off-by missing for commits in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]

Hi Keith,

On Thu, 23 May 2019 15:52:07 -0600 Keith Busch <kbusch@kernel.org> wrote:
>
> On Fri, May 24, 2019 at 07:45:00AM +1000, Stephen Rothwell wrote:
> > Commits
> > 
> >   5fb4aac756ac ("nvme: release namespace SRCU protection before performing controller ioctls")
> >   90ec611adcf2 ("nvme: merge nvme_ns_ioctl into nvme_ioctl")
> >   3f98bcc58cd5 ("nvme: remove the ifdef around nvme_nvm_ioctl")
> >   100c815cbd56 ("nvme: fix srcu locking on error return in nvme_get_ns_from_disk")
> > 
> > are missing a Signed-off-by from their committer.  
> 
> Oops, I'd only added my Reviewed-by. Do I need to update the commit
> messages and resend, or is this just putting me on notice for next time?

That depends on Jens ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the block tree

[Jens Axboe]

On 5/23/19 4:33 PM, Stephen Rothwell wrote:
> Hi Keith,
> 
> On Thu, 23 May 2019 15:52:07 -0600 Keith Busch <kbusch@kernel.org> wrote:
>>
>> On Fri, May 24, 2019 at 07:45:00AM +1000, Stephen Rothwell wrote:
>>> Commits
>>>
>>>    5fb4aac756ac ("nvme: release namespace SRCU protection before performing controller ioctls")
>>>    90ec611adcf2 ("nvme: merge nvme_ns_ioctl into nvme_ioctl")
>>>    3f98bcc58cd5 ("nvme: remove the ifdef around nvme_nvm_ioctl")
>>>    100c815cbd56 ("nvme: fix srcu locking on error return in nvme_get_ns_from_disk")
>>>
>>> are missing a Signed-off-by from their committer.
>>
>> Oops, I'd only added my Reviewed-by. Do I need to update the commit
>> messages and resend, or is this just putting me on notice for next time?
> 
> That depends on Jens ...

Since they at least have a reviewed-by from the committer, I say we let
it slide this time.

-- 
Jens Axboe

linux-next: Signed-off-by missing for commits in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

Hi all,

Commits

  c363f249e7e6 ("nvmet-rdma: allocate RW ctxs according to mdts")
  ec6d20e16c2d ("nvmet-rdma: Implement get_mdts controller op")
  02cb00e233ad ("nvmet: Add get_mdts op for controllers")
  2db24e4a22bc ("nvme-pci: properly print controller address")
  e2a366a4b0fe ("nvme-pci: slimmer CQ head update")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commits in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 745 bytes --]

Hi all,

Commits

  caec515ad9ed ("md/raid5: reallocate page array after setting new stripe_size")
  6a4b2e201b37 ("md/raid5: resize stripe_head when reshape array")
  1df3ccb18cf4 ("md/raid5: let multiple devices of stripe_head share page")
  e56e7ebce809 ("md/raid6: let async recovery function support different page offset")
  2b2059f32e20 ("md/raid6: let syndrome computor support different page offset")
  f849daa2c23c ("md/raid5: convert to new xor compution interface")
  4737539e07a3 ("md/raid5: add new xor function to support different page offset")
  a5a1925b9a1a ("md/raid5: make async_copy_data() to support different page offset")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the block tree

[Jens Axboe]

On 9/24/20 4:40 PM, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>   caec515ad9ed ("md/raid5: reallocate page array after setting new stripe_size")
>   6a4b2e201b37 ("md/raid5: resize stripe_head when reshape array")
>   1df3ccb18cf4 ("md/raid5: let multiple devices of stripe_head share page")
>   e56e7ebce809 ("md/raid6: let async recovery function support different page offset")
>   2b2059f32e20 ("md/raid6: let syndrome computor support different page offset")
>   f849daa2c23c ("md/raid5: convert to new xor compution interface")
>   4737539e07a3 ("md/raid5: add new xor function to support different page offset")
>   a5a1925b9a1a ("md/raid5: make async_copy_data() to support different page offset")
> 
> are missing a Signed-off-by from their committer.

Song, I'm going to drop this series. Please re-do it and submit it again.

-- 
Jens Axboe

Re: linux-next: Signed-off-by missing for commits in the block tree

[Song Liu]

> On Sep 24, 2020, at 4:05 PM, Jens Axboe <axboe@kernel.dk> wrote:
> 
> On 9/24/20 4:40 PM, Stephen Rothwell wrote:
>> Hi all,
>> 
>> Commits
>> 
>>  caec515ad9ed ("md/raid5: reallocate page array after setting new stripe_size")
>>  6a4b2e201b37 ("md/raid5: resize stripe_head when reshape array")
>>  1df3ccb18cf4 ("md/raid5: let multiple devices of stripe_head share page")
>>  e56e7ebce809 ("md/raid6: let async recovery function support different page offset")
>>  2b2059f32e20 ("md/raid6: let syndrome computor support different page offset")
>>  f849daa2c23c ("md/raid5: convert to new xor compution interface")
>>  4737539e07a3 ("md/raid5: add new xor function to support different page offset")
>>  a5a1925b9a1a ("md/raid5: make async_copy_data() to support different page offset")
>> 
>> are missing a Signed-off-by from their committer.
> 
> Song, I'm going to drop this series. Please re-do it and submit it again.

I am really sorry for the trouble. Will fix it asap. 

Song

linux-next: Signed-off-by missing for commits in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

Hi all,

Commits

  1b40fa66ac2b ("io_uring: reliably cancel linked timeouts")
  42699d33e969 ("io_uring: cancel-match based on flags")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the block tree

[Jens Axboe]

On 3/4/21 2:19 PM, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>   1b40fa66ac2b ("io_uring: reliably cancel linked timeouts")
>   42699d33e969 ("io_uring: cancel-match based on flags")
> 
> are missing a Signed-off-by from their committer.

Fixed up, thanks.

-- 
Jens Axboe

linux-next: Signed-off-by missing for commits in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

Hi all,

Commits

  2f7eff262585 ("io_uring: allow updating linked timeouts")
  132bf9af1d0f ("io_uring: keep ltimeouts in a list")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the block tree

[Jens Axboe]

On 8/29/21 3:52 PM, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>   2f7eff262585 ("io_uring: allow updating linked timeouts")
>   132bf9af1d0f ("io_uring: keep ltimeouts in a list")
> 
> are missing a Signed-off-by from their committer.

Oops, will fix.

-- 
Jens Axboe

linux-next: Signed-off-by missing for commits in the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]

Hi all,

Commits

  e036488d8a4a ("md: update superblock after changing rdev flags in state_store")
  3a79dfe0318e ("md: remove unused argument from md_new_event")
  b6f5737bc4f2 ("md/raid5: call roundup_pow_of_two in raid5_run")
  57644bef4efb ("md/raid1: use rdev in raid1_write_request directly")
  7d5f9b337c20 ("md/raid1: only allocate write behind bio for WriteMostly device")
  78eef929e8a5 ("md: properly unwind when failing to add the kobject in md_alloc")
  c57a1efbeadb ("md: extend disks_mutex coverage")
  a1094e65cde0 ("md: add the bitmap group to the default groups for the md kobject")
  96c85588b9b6 ("md: add error handling support for add_disk()")

are missing a Signed-off-by from their committer.

Rebased?

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the block tree

[Jens Axboe]

On 10/18/21 2:48 PM, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>   e036488d8a4a ("md: update superblock after changing rdev flags in state_store")
>   3a79dfe0318e ("md: remove unused argument from md_new_event")
>   b6f5737bc4f2 ("md/raid5: call roundup_pow_of_two in raid5_run")
>   57644bef4efb ("md/raid1: use rdev in raid1_write_request directly")
>   7d5f9b337c20 ("md/raid1: only allocate write behind bio for WriteMostly device")
>   78eef929e8a5 ("md: properly unwind when failing to add the kobject in md_alloc")
>   c57a1efbeadb ("md: extend disks_mutex coverage")
>   a1094e65cde0 ("md: add the bitmap group to the default groups for the md kobject")
>   96c85588b9b6 ("md: add error handling support for add_disk()")
> 
> are missing a Signed-off-by from their committer.
> 
> Rebased?

I'll fix it up - yes had to rebase this morning.

-- 
Jens Axboe