linux-next: build failure after merge of the mmc tree

linux-next: build failure after merge of the mmc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

Hi Chris,

After merging the mmc tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/mmc/host/tmio_mmc_pio.c: In function 'sd_ctrl_read16_rep':
drivers/mmc/host/tmio_mmc_pio.c:56: error: implicit declaration of function 'readsw'
drivers/mmc/host/tmio_mmc_pio.c: In function 'sd_ctrl_write16_rep':
drivers/mmc/host/tmio_mmc_pio.c:73: error: implicit declaration of function 'writesw'

Presumably caused by commit b6147490e6aa ("mmc: tmio: split core
functionality, DMA and MFD glue").

I have used the mmc tree from next-20110325 for tdoay.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

[PATCH] mmc: SDHI should depend on SUPERH || ARCH_SHMOBILE

[Guennadi Liakhovetski]

Fix build breakage on platforms, not providing readsw and writesw
functions, e.g., on x86(_64).

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---

Subject: Re: linux-next: build failure after merge of the mmc tree

On Mon, 28 Mar 2011, Stephen Rothwell wrote:

> Hi Chris,
> 
> After merging the mmc tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/mmc/host/tmio_mmc_pio.c: In function 'sd_ctrl_read16_rep':
> drivers/mmc/host/tmio_mmc_pio.c:56: error: implicit declaration of function 'readsw'
> drivers/mmc/host/tmio_mmc_pio.c: In function 'sd_ctrl_write16_rep':
> drivers/mmc/host/tmio_mmc_pio.c:73: error: implicit declaration of function 'writesw'
> 
> Presumably caused by commit b6147490e6aa ("mmc: tmio: split core
> functionality, DMA and MFD glue").
> 
> I have used the mmc tree from next-20110325 for tdoay.

Stephen, please verify, that this fixes your problem.

 drivers/mmc/host/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 0b03cee..94df405 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -452,6 +452,7 @@ config MMC_TMIO
 
 config MMC_SDHI
 	tristate "SH-Mobile SDHI SD/SDIO controller support"
+	depends on SUPERH || ARCH_SHMOBILE
 	select MMC_TMIO_CORE
 	help
 	  This provides support for the SDHI SD/SDIO controller found in
-- 
1.7.2.5

Re: [PATCH] mmc: SDHI should depend on SUPERH || ARCH_SHMOBILE

[Chris Ball]

Hi,

On Mon, Mar 28 2011, Guennadi Liakhovetski wrote:
> Fix build breakage on platforms, not providing readsw and writesw
> functions, e.g., on x86(_64).
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
>
> Subject: Re: linux-next: build failure after merge of the mmc tree
>
> On Mon, 28 Mar 2011, Stephen Rothwell wrote:
>
>> Hi Chris,
>> 
>> After merging the mmc tree, today's linux-next build (x86_64 allmodconfig)
>> failed like this:
>> 
>> drivers/mmc/host/tmio_mmc_pio.c: In function 'sd_ctrl_read16_rep':
>> drivers/mmc/host/tmio_mmc_pio.c:56: error: implicit declaration of function 'readsw'
>> drivers/mmc/host/tmio_mmc_pio.c: In function 'sd_ctrl_write16_rep':
>> drivers/mmc/host/tmio_mmc_pio.c:73: error: implicit declaration of function 'writesw'
>> 
>> Presumably caused by commit b6147490e6aa ("mmc: tmio: split core
>> functionality, DMA and MFD glue").
>> 
>> I have used the mmc tree from next-20110325 for tdoay.
>
> Stephen, please verify, that this fixes your problem.

I've verified the fix and pushed it to mmc-next, so this should be fixed
tomorrow.  Thanks!

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child