* linux-next: build warning after merge of the hid tree
@ 2021-11-10 4:06 Stephen Rothwell
2021-11-10 8:17 ` Jiri Kosina
2021-11-10 12:16 ` [PATCH] mod_devicetable: fix kdocs for ishtp_device_id Thomas Weißschuh
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Rothwell @ 2021-11-10 4:06 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires
Cc: Thomas Weißschuh, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 427 bytes --]
Hi all,
After merging the hid tree, today's linux-next build (htmldocs) produced
this warning:
include/linux/mod_devicetable.h:909: warning: Function parameter or member 'guid' not described in 'ishtp_device_id'
Introduced by commit
fa443bc3c1e4 ("HID: intel-ish-hid: add support for MODULE_DEVICE_TABLE()")
I also notice that there is a @context description, but no field.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: build warning after merge of the hid tree
2021-11-10 4:06 linux-next: build warning after merge of the hid tree Stephen Rothwell
@ 2021-11-10 8:17 ` Jiri Kosina
2021-11-10 12:16 ` [PATCH] mod_devicetable: fix kdocs for ishtp_device_id Thomas Weißschuh
1 sibling, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2021-11-10 8:17 UTC (permalink / raw)
To: Stephen Rothwell, Thomas Weißschuh
Cc: Benjamin Tissoires, Linux Kernel Mailing List, Linux Next Mailing List
On Wed, 10 Nov 2021, Stephen Rothwell wrote:
> Hi all,
>
> After merging the hid tree, today's linux-next build (htmldocs) produced
> this warning:
>
> include/linux/mod_devicetable.h:909: warning: Function parameter or member 'guid' not described in 'ishtp_device_id'
>
> Introduced by commit
>
> fa443bc3c1e4 ("HID: intel-ish-hid: add support for MODULE_DEVICE_TABLE()")
>
> I also notice that there is a @context description, but no field.
Thanks for spotting it. The kerneldoc is clearly wrong there both on the
'guid' member name, and also the description (mind the '36 char' part,
where it should have been '16 char' instead).
Thomas, could you please send me a fixup patch for that?
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] mod_devicetable: fix kdocs for ishtp_device_id
2021-11-10 4:06 linux-next: build warning after merge of the hid tree Stephen Rothwell
2021-11-10 8:17 ` Jiri Kosina
@ 2021-11-10 12:16 ` Thomas Weißschuh
2021-11-10 12:20 ` Jiri Kosina
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Weißschuh @ 2021-11-10 12:16 UTC (permalink / raw)
To: Jiri Kosina, linux-input
Cc: Thomas Weißschuh, Stephen Rothwell, Benjamin Tissoires,
linux-kernel, linux-next
The kdocs were copied from another device_id struct and not adapted.
Fixes: fa443bc3c1e4 ("HID: intel-ish-hid: add support for MODULE_DEVICE_TABLE()")
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
include/linux/mod_devicetable.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
index befbf53c4b7c..c70abe7aaef2 100644
--- a/include/linux/mod_devicetable.h
+++ b/include/linux/mod_devicetable.h
@@ -901,8 +901,7 @@ struct dfl_device_id {
/**
* struct ishtp_device_id - ISHTP device identifier
- * @guid_string: 36 char string of the form fa50ff2b-f2e8-45de-83fa-65417f2f49ba
- * @context: pointer to driver specific data
+ * @guid: GUID of the device.
*/
struct ishtp_device_id {
guid_t guid;
base-commit: 7fb0413baa7f8a04caef0c504df9af7e0623d296
--
2.33.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mod_devicetable: fix kdocs for ishtp_device_id
2021-11-10 12:16 ` [PATCH] mod_devicetable: fix kdocs for ishtp_device_id Thomas Weißschuh
@ 2021-11-10 12:20 ` Jiri Kosina
0 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2021-11-10 12:20 UTC (permalink / raw)
To: Thomas Weißschuh
Cc: linux-input, Stephen Rothwell, Benjamin Tissoires, linux-kernel,
linux-next
On Wed, 10 Nov 2021, Thomas Weißschuh wrote:
> The kdocs were copied from another device_id struct and not adapted.
>
> Fixes: fa443bc3c1e4 ("HID: intel-ish-hid: add support for MODULE_DEVICE_TABLE()")
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
I've added
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
and applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-10 12:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-10 4:06 linux-next: build warning after merge of the hid tree Stephen Rothwell
2021-11-10 8:17 ` Jiri Kosina
2021-11-10 12:16 ` [PATCH] mod_devicetable: fix kdocs for ishtp_device_id Thomas Weißschuh
2021-11-10 12:20 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).