linux-nfc.lists.01.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: linux-nfc@lists.01.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Subject: [linux-nfc] [neard][PATCH 13/16] ndef: silence clang -Wcast-align warning
Date: Sat, 10 Jul 2021 05:38:56 +0200	[thread overview]
Message-ID: <20210710033859.3989-14-krzysztof.kozlowski@canonical.com> (raw)
In-Reply-To: <20210710033859.3989-1-krzysztof.kozlowski@canonical.com>

Fix clang warning:

    src/ndef.c:1196:28: error: cast from 'char *' to 'gunichar2 *' (aka 'unsigned short *') increases required alignment from 1 to 2 [-Werror,-Wcast-align]
                            g_str = g_utf16_to_utf8((gunichar2 *)txt, len, NULL,
                                                    ^~~~~~~~~~~~~~~~

The case is safe as length of string is an even number.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 src/ndef.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/ndef.c b/src/ndef.c
index fdd44b467027..13e3356c2c4c 100644
--- a/src/ndef.c
+++ b/src/ndef.c
@@ -1198,7 +1198,8 @@ parse_text_payload(uint8_t *payload, uint32_t length)
 		txt = (char *)(payload + offset);
 
 		if (status)
-			g_str = g_utf16_to_utf8((gunichar2 *)txt, len, NULL,
+			/* Cast to void to silence the 1-to-2 alignment warning */
+			g_str = g_utf16_to_utf8((gunichar2 *)(void *)txt, len, NULL,
 						NULL, NULL);
 		else
 			g_str = txt;
-- 
2.27.0
_______________________________________________
Linux-nfc mailing list -- linux-nfc@lists.01.org
To unsubscribe send an email to linux-nfc-leave@lists.01.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

  parent reply	other threads:[~2021-07-10  3:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-10  3:38 [linux-nfc] [neard][PATCH 00/16] neard CI under Github and rouund of fixes Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 01/16] nfctool: fix adapter_compare_idx() cast-function-type Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 02/16] nfctool: fix nfctool_send_dep_link_up() cast-function-type Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 03/16] nfctool: fix nfctool_print_and_remove_snl() cast-function-type Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 04/16] ci: temporarily disable Ubuntu Hirsute Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 05/16] dbus: fix -Wformat in near_dbus_encode_string() Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 06/16] bootstrap: parse CROSS_COMPILE and set proper configure option Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 07/16] ci: add SPDX and copyright notes to ci.yml Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 08/16] ci: enable back Ubuntu Hirsute Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 09/16] ci: print executed commands when configuring debian Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 10/16] ci: no need to print twice compiler version Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 11/16] unit: pass real UTF-8 for testing text NDEF Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 12/16] ndef: check UTF-16 text payload length Krzysztof Kozlowski
2021-07-10  3:38 ` Krzysztof Kozlowski [this message]
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 14/16] ndef: fix parsing of UTF-16 text payload Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 15/16] nfctype5: fix returning uninitialized stack value in t5_tag_is_ti_pro() Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 16/16] ci: add clang builds Krzysztof Kozlowski
2021-07-19  1:40 ` [linux-nfc] Re: [neard][PATCH 00/16] neard CI under Github and rouund of fixes Mark Greer
2021-07-19  8:04   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210710033859.3989-14-krzysztof.kozlowski@canonical.com \
    --to=krzysztof.kozlowski@canonical.com \
    --cc=linux-nfc@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).