From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Nigel Christian <nigel.l.christian@gmail.com>
Cc: linux-nfc@lists.01.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [linux-nfc] Re: [PATCH] NFC: microread: Pass err variable to async_cb()
Date: Tue, 1 Jun 2021 15:07:46 +0200 [thread overview]
Message-ID: <3e2f804b-107a-9f44-2ed2-95e4c2a2e426@canonical.com> (raw)
In-Reply-To: <YLYvcbjuPg1JFr7/@fedora>
On 01/06/2021 15:00, Nigel Christian wrote:
> In the case MICROREAD_CB_TYPE_READER_ALL clang reports a dead
> code warning. The error code is being directly passed to
> async_cb(). Fix this by passing the err variable, which is also
> done in another path.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com>
> ---
> drivers/nfc/microread/microread.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nfc/microread/microread.c b/drivers/nfc/microread/microread.c
> index 8d3988457c58..130b0f554016 100644
> --- a/drivers/nfc/microread/microread.c
> +++ b/drivers/nfc/microread/microread.c
> @@ -367,7 +367,7 @@ static void microread_im_transceive_cb(void *context, struct sk_buff *skb,
> err = -EPROTO;
Remove this line instead, please. The err is argument passed by value so
assigning it within a function is ugly.
> kfree_skb(skb);
> info->async_cb(info->async_cb_context, NULL,
> - -EPROTO);
> + err);
> return;
> }
>
>
Best regards,
Krzysztof
_______________________________________________
Linux-nfc mailing list -- linux-nfc@lists.01.org
To unsubscribe send an email to linux-nfc-leave@lists.01.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
parent reply other threads:[~2021-06-01 13:07 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <YLYvcbjuPg1JFr7/@fedora>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e2f804b-107a-9f44-2ed2-95e4c2a2e426@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=netdev@vger.kernel.org \
--cc=nigel.l.christian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).