* [linux-nfc] Re: [PATCH] NFC: microread: Pass err variable to async_cb()
[not found] <YLYvcbjuPg1JFr7/@fedora>
@ 2021-06-01 13:07 ` Krzysztof Kozlowski
0 siblings, 0 replies; only message in thread
From: Krzysztof Kozlowski @ 2021-06-01 13:07 UTC (permalink / raw)
To: Nigel Christian; +Cc: linux-nfc, netdev, kernel-janitors
On 01/06/2021 15:00, Nigel Christian wrote:
> In the case MICROREAD_CB_TYPE_READER_ALL clang reports a dead
> code warning. The error code is being directly passed to
> async_cb(). Fix this by passing the err variable, which is also
> done in another path.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com>
> ---
> drivers/nfc/microread/microread.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nfc/microread/microread.c b/drivers/nfc/microread/microread.c
> index 8d3988457c58..130b0f554016 100644
> --- a/drivers/nfc/microread/microread.c
> +++ b/drivers/nfc/microread/microread.c
> @@ -367,7 +367,7 @@ static void microread_im_transceive_cb(void *context, struct sk_buff *skb,
> err = -EPROTO;
Remove this line instead, please. The err is argument passed by value so
assigning it within a function is ugly.
> kfree_skb(skb);
> info->async_cb(info->async_cb_context, NULL,
> - -EPROTO);
> + err);
> return;
> }
>
>
Best regards,
Krzysztof
_______________________________________________
Linux-nfc mailing list -- linux-nfc@lists.01.org
To unsubscribe send an email to linux-nfc-leave@lists.01.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
^ permalink raw reply [flat|nested] only message in thread