From: Chuck Lever <chuck.lever@oracle.com>
To: Bruce Fields <bfields@fieldses.org>
Cc: Trond Myklebust <trondmy@hammerspace.com>,
Anna Schumaker <schumakeranna@gmail.com>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] sunrpc: convert unnecessary GFP_ATOMIC to GFP_NOFS
Date: Thu, 20 Dec 2018 10:47:25 -0500 [thread overview]
Message-ID: <09BE8CC3-B528-45BA-B10E-01D7F9FD264D@oracle.com> (raw)
In-Reply-To: <20181220154236.GC6063@fieldses.org>
> On Dec 20, 2018, at 10:42 AM, J. Bruce Fields <bfields@fieldses.org> wrote:
>
> From: "J. Bruce Fields" <bfields@redhat.com>
>
> It's OK to sleep here, we just don't want to recurse into the filesystem
> as this writeout could be waiting on this.
"as a writeout"
> Future work: the documentation for GFP_NOFS says "Please try to avoid
> using this flag directly and instead use memalloc_nofs_{save,restore} to
> mark the whole scope which cannot/shouldn't recurse into the FS layer
> with a short explanation why. All allocation requests will inherit
> GFP_NOFS implicitly."
>
> But I'm not sure where to do this. Should the workqueue be arranging
> that for us in the case of workqueues created with WQ_MEM_RECLAIM?
There seem to be plenty of uses of GFP_NOFS in NFS and sunrpc.
That sounds like a big project.
> Reported-by: Trond Myklebust <trondmy@hammer.space>
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
> ---
> net/sunrpc/rpcb_clnt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Also, I've still got this one. (And still haven't looked into whether
> it should be using a memalloc_nofs_{save,restore} elsewhere instead.)
>
> diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c
> index 08b5fa4a2852..41a971ac1c63 100644
> --- a/net/sunrpc/rpcb_clnt.c
> +++ b/net/sunrpc/rpcb_clnt.c
> @@ -752,7 +752,7 @@ void rpcb_getport_async(struct rpc_task *task)
> goto bailout_nofree;
> }
>
> - map = kzalloc(sizeof(struct rpcbind_args), GFP_ATOMIC);
> + map = kzalloc(sizeof(struct rpcbind_args), GFP_NOFS);
> if (!map) {
> status = -ENOMEM;
> dprintk("RPC: %5u %s: no memory available\n",
> @@ -770,7 +770,7 @@ void rpcb_getport_async(struct rpc_task *task)
> case RPCBVERS_4:
> case RPCBVERS_3:
> map->r_netid = xprt->address_strings[RPC_DISPLAY_NETID];
> - map->r_addr = rpc_sockaddr2uaddr(sap, GFP_ATOMIC);
> + map->r_addr = rpc_sockaddr2uaddr(sap, GFP_NOFS);
> if (!map->r_addr) {
> status = -ENOMEM;
> dprintk("RPC: %5u %s: no memory available\n",
> --
> 2.19.2
>
--
Chuck Lever
next prev parent reply other threads:[~2018-12-20 15:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 15:35 [PATCH] sunrpc: handle ENOMEM in rpcb_getport_async J. Bruce Fields
2018-12-20 15:42 ` [PATCH] sunrpc: convert unnecessary GFP_ATOMIC to GFP_NOFS J. Bruce Fields
2018-12-20 15:47 ` Chuck Lever [this message]
2018-12-20 15:52 ` Bruce Fields
2018-12-20 20:13 ` Bruce Fields
2018-12-21 6:37 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09BE8CC3-B528-45BA-B10E-01D7F9FD264D@oracle.com \
--to=chuck.lever@oracle.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=schumakeranna@gmail.com \
--cc=trondmy@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).