* [PATCH] NFS:remove redundant call to nfs_do_access
@ 2020-02-28 10:14 Zhouyi Zhou
0 siblings, 0 replies; only message in thread
From: Zhouyi Zhou @ 2020-02-28 10:14 UTC (permalink / raw)
To: trond.myklebust, anna.schumaker, linux-nfs, linux-kernel,
paulmck, paulmck, neilb
Cc: Zhouyi Zhou
Also the rcu_read_lock and rcu_read_unlock is unnessarry because rcu
critical data structure is already protected in
nfs_access_get_cached_rcu.
Tested in x86_64
Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
---
fs/nfs/dir.c | 9 +--------
1 files changed, 1 insertions(+), 8 deletions(-)
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index 193d6fb..37b0c10 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -2732,14 +2732,7 @@ int nfs_permission(struct inode *inode, int mask)
if (!NFS_PROTO(inode)->access)
goto out_notsup;
- /* Always try fast lookups first */
- rcu_read_lock();
- res = nfs_do_access(inode, cred, mask|MAY_NOT_BLOCK);
- rcu_read_unlock();
- if (res == -ECHILD && !(mask & MAY_NOT_BLOCK)) {
- /* Fast lookup failed, try the slow way */
- res = nfs_do_access(inode, cred, mask);
- }
+ res = nfs_do_access(inode, cred, mask);
out:
if (!res && (mask & MAY_EXEC))
res = nfs_execute_ok(inode, mask);
--
1.7.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-02-28 10:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-28 10:14 [PATCH] NFS:remove redundant call to nfs_do_access Zhouyi Zhou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).