linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net/sunrpc: Fix return value for sysctl sunrpc.transports
@ 2020-10-11 19:28 Artur Molchanov
  2020-10-11 19:34 ` Artur Molchanov
  0 siblings, 1 reply; 2+ messages in thread
From: Artur Molchanov @ 2020-10-11 19:28 UTC (permalink / raw)
  To: linux-nfs

Fix returning value for sysctl sunrpc.transports.

Without this fix sysctl returns random garbage for this sysctl key.

Signed-off-by: Artur Molchanov <arturmolchanov@gmail.com>
Cc: stable@vger.kernel.org
---
 net/sunrpc/sysctl.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/sunrpc/sysctl.c b/net/sunrpc/sysctl.c
index 999eee1ed61c..1edcecef23dc 100644
--- a/net/sunrpc/sysctl.c
+++ b/net/sunrpc/sysctl.c
@@ -70,7 +70,8 @@ static int proc_do_xprt(struct ctl_table *table, int write,
 		return 0;
 	}
 	len = svc_print_xprts(tmpbuf, sizeof(tmpbuf));
-	return memory_read_from_buffer(buffer, *lenp, ppos, tmpbuf, len);
+	*lenp = memory_read_from_buffer(buffer, *lenp, ppos, tmpbuf, len);
+	return 0;
 }
 
 static int
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net/sunrpc: Fix return value for sysctl sunrpc.transports
  2020-10-11 19:28 [PATCH] net/sunrpc: Fix return value for sysctl sunrpc.transports Artur Molchanov
@ 2020-10-11 19:34 ` Artur Molchanov
  0 siblings, 0 replies; 2+ messages in thread
From: Artur Molchanov @ 2020-10-11 19:34 UTC (permalink / raw)
  To: linux-nfs; +Cc: bfields, chuck.lever

Add maintainers.


Artur Molchanov

> 11 окт. 2020 г., в 22:28, Artur Molchanov <arturmolchanov@gmail.com> написал(а):
> 
> Fix returning value for sysctl sunrpc.transports.
> 
> Without this fix sysctl returns random garbage for this sysctl key.
> 
> Signed-off-by: Artur Molchanov <arturmolchanov@gmail.com>
> Cc: stable@vger.kernel.org
> ---
> net/sunrpc/sysctl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/sunrpc/sysctl.c b/net/sunrpc/sysctl.c
> index 999eee1ed61c..1edcecef23dc 100644
> --- a/net/sunrpc/sysctl.c
> +++ b/net/sunrpc/sysctl.c
> @@ -70,7 +70,8 @@ static int proc_do_xprt(struct ctl_table *table, int write,
> 		return 0;
> 	}
> 	len = svc_print_xprts(tmpbuf, sizeof(tmpbuf));
> -	return memory_read_from_buffer(buffer, *lenp, ppos, tmpbuf, len);
> +	*lenp = memory_read_from_buffer(buffer, *lenp, ppos, tmpbuf, len);
> +	return 0;
> }
> 
> static int
> -- 
> 2.20.1
> 
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-11 19:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-11 19:28 [PATCH] net/sunrpc: Fix return value for sysctl sunrpc.transports Artur Molchanov
2020-10-11 19:34 ` Artur Molchanov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).