* [PATCH] nfsref: switch the way libraries are linked.
@ 2018-12-11 19:09 Steve Dickson
2018-12-11 19:12 ` Chuck Lever
0 siblings, 1 reply; 5+ messages in thread
From: Steve Dickson @ 2018-12-11 19:09 UTC (permalink / raw)
To: Linux NFS Mailing list
Link the static libs before the dynamic libs allowing
the routines in the static libs to be defined
by the dynamic libs
Signed-off-by: Steve Dickson <steved@redhat.com>
---
utils/nfsref/Makefile.am | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/utils/nfsref/Makefile.am b/utils/nfsref/Makefile.am
index 44edc83..2409dd0 100644
--- a/utils/nfsref/Makefile.am
+++ b/utils/nfsref/Makefile.am
@@ -27,9 +27,9 @@ noinst_HEADERS = nfsref.h
sbin_PROGRAMS = nfsref
nfsref_SOURCES = add.c lookup.c nfsref.c remove.c
-LDADD = $(LIBXML2) $(LIBCAP) \
- ../../support/nfs/libnfs.la \
- ../../support/junction/libjunction.la
+LDADD = ../../support/nfs/libnfs.la \
+ ../../support/junction/libjunction.la \
+ $(LIBXML2) $(LIBCAP)
man8_MANS = nfsref.man
--
2.19.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] nfsref: switch the way libraries are linked.
2018-12-11 19:09 [PATCH] nfsref: switch the way libraries are linked Steve Dickson
@ 2018-12-11 19:12 ` Chuck Lever
2018-12-11 22:27 ` Steve Dickson
0 siblings, 1 reply; 5+ messages in thread
From: Chuck Lever @ 2018-12-11 19:12 UTC (permalink / raw)
To: Steve Dickson; +Cc: Linux NFS Mailing List
> On Dec 11, 2018, at 2:09 PM, Steve Dickson <steved@redhat.com> wrote:
>
> Link the static libs before the dynamic libs allowing
> the routines in the static libs to be defined
> by the dynamic libs
Hi Steve, Why is this change necessary? Is there a bug report?
> Signed-off-by: Steve Dickson <steved@redhat.com>
> ---
> utils/nfsref/Makefile.am | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/utils/nfsref/Makefile.am b/utils/nfsref/Makefile.am
> index 44edc83..2409dd0 100644
> --- a/utils/nfsref/Makefile.am
> +++ b/utils/nfsref/Makefile.am
> @@ -27,9 +27,9 @@ noinst_HEADERS = nfsref.h
>
> sbin_PROGRAMS = nfsref
> nfsref_SOURCES = add.c lookup.c nfsref.c remove.c
> -LDADD = $(LIBXML2) $(LIBCAP) \
> - ../../support/nfs/libnfs.la \
> - ../../support/junction/libjunction.la
> +LDADD = ../../support/nfs/libnfs.la \
> + ../../support/junction/libjunction.la \
> + $(LIBXML2) $(LIBCAP)
>
> man8_MANS = nfsref.man
>
> --
> 2.19.2
>
--
Chuck Lever
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nfsref: switch the way libraries are linked.
2018-12-11 19:12 ` Chuck Lever
@ 2018-12-11 22:27 ` Steve Dickson
2018-12-12 15:54 ` Chuck Lever
0 siblings, 1 reply; 5+ messages in thread
From: Steve Dickson @ 2018-12-11 22:27 UTC (permalink / raw)
To: Chuck Lever; +Cc: Linux NFS Mailing List
On 12/11/18 2:12 PM, Chuck Lever wrote:
>
>> On Dec 11, 2018, at 2:09 PM, Steve Dickson <steved@redhat.com> wrote:
>>
>> Link the static libs before the dynamic libs allowing
>> the routines in the static libs to be defined
>> by the dynamic libs
>
> Hi Steve, Why is this change necessary? Is there a bug report?
No... when I enabled junctions in the Fedora rawhide (F30) I got
a bunch of xml undefined routines
https://koji.fedoraproject.org/koji/getfile?taskID=31408933&volume=DEFAULT&name=build.log&offset=-4000
It compiled fine on f29 but not on rawhide
After asking if the XML api changed, people suggested I simply
change the order of how the static and dynamic libs are linked,
which worked
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/6UIAF47S73QFLCJDWEWXKQHZTOMB5JXQ/
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/VK2XPHV2MELV6IRKBG2ITI6GKUBMMRQW/
steved.
>
>
>> Signed-off-by: Steve Dickson <steved@redhat.com>
>> ---
>> utils/nfsref/Makefile.am | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/utils/nfsref/Makefile.am b/utils/nfsref/Makefile.am
>> index 44edc83..2409dd0 100644
>> --- a/utils/nfsref/Makefile.am
>> +++ b/utils/nfsref/Makefile.am
>> @@ -27,9 +27,9 @@ noinst_HEADERS = nfsref.h
>>
>> sbin_PROGRAMS = nfsref
>> nfsref_SOURCES = add.c lookup.c nfsref.c remove.c
>> -LDADD = $(LIBXML2) $(LIBCAP) \
>> - ../../support/nfs/libnfs.la \
>> - ../../support/junction/libjunction.la
>> +LDADD = ../../support/nfs/libnfs.la \
>> + ../../support/junction/libjunction.la \
>> + $(LIBXML2) $(LIBCAP)
>>
>> man8_MANS = nfsref.man
>>
>> --
>> 2.19.2
>>
>
> --
> Chuck Lever
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nfsref: switch the way libraries are linked.
2018-12-11 22:27 ` Steve Dickson
@ 2018-12-12 15:54 ` Chuck Lever
2018-12-12 16:17 ` Steve Dickson
0 siblings, 1 reply; 5+ messages in thread
From: Chuck Lever @ 2018-12-12 15:54 UTC (permalink / raw)
To: Steve Dickson; +Cc: Linux NFS Mailing List
> On Dec 11, 2018, at 5:27 PM, Steve Dickson <SteveD@redhat.com> wrote:
>
>
>
> On 12/11/18 2:12 PM, Chuck Lever wrote:
>>
>>> On Dec 11, 2018, at 2:09 PM, Steve Dickson <steved@redhat.com> wrote:
>>>
>>> Link the static libs before the dynamic libs allowing
>>> the routines in the static libs to be defined
>>> by the dynamic libs
>>
>> Hi Steve, Why is this change necessary? Is there a bug report?
> No... when I enabled junctions in the Fedora rawhide (F30) I got
> a bunch of xml undefined routines
> https://koji.fedoraproject.org/koji/getfile?taskID=31408933&volume=DEFAULT&name=build.log&offset=-4000
>
> It compiled fine on f29 but not on rawhide
>
> After asking if the XML api changed, people suggested I simply
> change the order of how the static and dynamic libs are linked,
> which worked
>
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/6UIAF47S73QFLCJDWEWXKQHZTOMB5JXQ/
>
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/VK2XPHV2MELV6IRKBG2ITI6GKUBMMRQW/
OK. See also:
http://git.linux-nfs.org/?p=cel/fedfs-utils.git;a=commit;h=05d6450023265e15bdc6e6bd24c05b1586e87d1d
which is a similar change, but it hits other Makefiles as well.
I wonder why only nfsref/Makefile.am is affected for you.
> steved.
>
>>
>>
>>> Signed-off-by: Steve Dickson <steved@redhat.com>
>>> ---
>>> utils/nfsref/Makefile.am | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/utils/nfsref/Makefile.am b/utils/nfsref/Makefile.am
>>> index 44edc83..2409dd0 100644
>>> --- a/utils/nfsref/Makefile.am
>>> +++ b/utils/nfsref/Makefile.am
>>> @@ -27,9 +27,9 @@ noinst_HEADERS = nfsref.h
>>>
>>> sbin_PROGRAMS = nfsref
>>> nfsref_SOURCES = add.c lookup.c nfsref.c remove.c
>>> -LDADD = $(LIBXML2) $(LIBCAP) \
>>> - ../../support/nfs/libnfs.la \
>>> - ../../support/junction/libjunction.la
>>> +LDADD = ../../support/nfs/libnfs.la \
>>> + ../../support/junction/libjunction.la \
>>> + $(LIBXML2) $(LIBCAP)
>>>
>>> man8_MANS = nfsref.man
>>>
>>> --
>>> 2.19.2
>>>
>>
>> --
>> Chuck Lever
>>
>>
>>
--
Chuck Lever
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nfsref: switch the way libraries are linked.
2018-12-12 15:54 ` Chuck Lever
@ 2018-12-12 16:17 ` Steve Dickson
0 siblings, 0 replies; 5+ messages in thread
From: Steve Dickson @ 2018-12-12 16:17 UTC (permalink / raw)
To: Chuck Lever; +Cc: Linux NFS Mailing List
On 12/12/18 10:54 AM, Chuck Lever wrote:
>
>
>> On Dec 11, 2018, at 5:27 PM, Steve Dickson <SteveD@redhat.com> wrote:
>>
>>
>>
>> On 12/11/18 2:12 PM, Chuck Lever wrote:
>>>
>>>> On Dec 11, 2018, at 2:09 PM, Steve Dickson <steved@redhat.com> wrote:
>>>>
>>>> Link the static libs before the dynamic libs allowing
>>>> the routines in the static libs to be defined
>>>> by the dynamic libs
>>>
>>> Hi Steve, Why is this change necessary? Is there a bug report?
>> No... when I enabled junctions in the Fedora rawhide (F30) I got
>> a bunch of xml undefined routines
>> https://koji.fedoraproject.org/koji/getfile?taskID=31408933&volume=DEFAULT&name=build.log&offset=-4000
>>
>> It compiled fine on f29 but not on rawhide
>>
>> After asking if the XML api changed, people suggested I simply
>> change the order of how the static and dynamic libs are linked,
>> which worked
>>
>> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/6UIAF47S73QFLCJDWEWXKQHZTOMB5JXQ/
>>
>> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/VK2XPHV2MELV6IRKBG2ITI6GKUBMMRQW/
>
> OK. See also:
>
> http://git.linux-nfs.org/?p=cel/fedfs-utils.git;a=commit;h=05d6450023265e15bdc6e6bd24c05b1586e87d1d
>
> which is a similar change, but it hits other Makefiles as well.
> I wonder why only nfsref/Makefile.am is affected for you.
Well taking a quick look at the utils/*/Makefile.am files,
in general with two exceptions, the static libs are always defined
be for the dynamic libs...
And why it compiled on Fedora 29 and not Fedora 30 (rawhide)...
Well... I have no idea... its going down as one of those
the gcc/ld mysteries ;-)
Committed!
steved.
>
>
>> steved.
>>
>>>
>>>
>>>> Signed-off-by: Steve Dickson <steved@redhat.com>
>>>> ---
>>>> utils/nfsref/Makefile.am | 6 +++---
>>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/utils/nfsref/Makefile.am b/utils/nfsref/Makefile.am
>>>> index 44edc83..2409dd0 100644
>>>> --- a/utils/nfsref/Makefile.am
>>>> +++ b/utils/nfsref/Makefile.am
>>>> @@ -27,9 +27,9 @@ noinst_HEADERS = nfsref.h
>>>>
>>>> sbin_PROGRAMS = nfsref
>>>> nfsref_SOURCES = add.c lookup.c nfsref.c remove.c
>>>> -LDADD = $(LIBXML2) $(LIBCAP) \
>>>> - ../../support/nfs/libnfs.la \
>>>> - ../../support/junction/libjunction.la
>>>> +LDADD = ../../support/nfs/libnfs.la \
>>>> + ../../support/junction/libjunction.la \
>>>> + $(LIBXML2) $(LIBCAP)
>>>>
>>>> man8_MANS = nfsref.man
>>>>
>>>> --
>>>> 2.19.2
>>>>
>>>
>>> --
>>> Chuck Lever
>>>
>>>
>>>
>
> --
> Chuck Lever
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-12-12 16:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-11 19:09 [PATCH] nfsref: switch the way libraries are linked Steve Dickson
2018-12-11 19:12 ` Chuck Lever
2018-12-11 22:27 ` Steve Dickson
2018-12-12 15:54 ` Chuck Lever
2018-12-12 16:17 ` Steve Dickson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).