From: Christoph Hellwig <hch@infradead.org>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Alex Elder <aelder@sgi.com>,
xfs-masters@oss.sgi.com, xfs@oss.sgi.com,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH] xfs: failure mapping nfs fh to inode should return ESTALE
Date: Thu, 14 Jul 2011 18:31:26 -0400 [thread overview]
Message-ID: <20110714223126.GA28694@infradead.org> (raw)
In-Reply-To: <20110714205036.GA19457@fieldses.org>
On Thu, Jul 14, 2011 at 04:50:36PM -0400, J. Bruce Fields wrote:
> From: J. Bruce Fields <bfields@redhat.com>
>
> On xfs exports, nfsd is incorrectly returning ENOENT instead of ESTALE
> on attempts to use a filehandle of a deleted file (spotted with pynfs
> test PUTFH3). The ENOENT was coming from xfs_iget.
With that you mean the ip->i_d.di_mode checks? Given that we should
only be bale to get these from NFS or the handle ioctls I suspect just
turning them into ESTALE should be fine.
next prev parent reply other threads:[~2011-07-14 22:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 20:50 [PATCH] xfs: failure mapping nfs fh to inode should return ESTALE J. Bruce Fields
2011-07-14 22:25 ` Alex Elder
2011-07-14 22:31 ` Christoph Hellwig [this message]
2011-07-15 20:33 ` J. Bruce Fields
2011-07-16 1:50 ` [xfs-masters] " Dave Chinner
2011-07-16 1:53 ` Christoph Hellwig
2011-07-18 13:37 ` J. Bruce Fields
2011-07-19 19:29 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110714223126.GA28694@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=xfs-masters@oss.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).