From: "J. Bruce Fields" <bfields@fieldses.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>,
xfs-masters@oss.sgi.com, linux-nfs@vger.kernel.org,
xfs@oss.sgi.com
Subject: Re: [xfs-masters] [PATCH] xfs: failure mapping nfs fh to inode should return ESTALE
Date: Mon, 18 Jul 2011 09:37:10 -0400 [thread overview]
Message-ID: <20110718133710.GB9741@fieldses.org> (raw)
In-Reply-To: <20110716015346.GA589@infradead.org>
On Fri, Jul 15, 2011 at 09:53:46PM -0400, Christoph Hellwig wrote:
> On Sat, Jul 16, 2011 at 11:50:14AM +1000, Dave Chinner wrote:
> > Bulkstat also checks for ENOENT returns from xfs_iget() as the
> > lookup it does is inherently racy. That is, if the inode is
> > allocated when it is read from the IBT, but then has been unlinked
> > before the actual xfs_iget() call, it expects to get back an ENOENT
> > to tell it the inode has been unlinked and shouldn't be included in
> > the bulkstat output. Otherwise, it returns the error to userspace.
> >
> > So converting the mode checks to return ESTALE definitely has the
> > chance of breaking stuff that uses bulkstat (e.g. xfsdump) because
> > it will return errors now where it previously just skipped the
> > (unlinked) inode.
>
> Sounds like we should simply go with the original version of the patch
> then.
OK. Let me know if someone needs that resent....
--b.
next prev parent reply other threads:[~2011-07-18 13:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 20:50 [PATCH] xfs: failure mapping nfs fh to inode should return ESTALE J. Bruce Fields
2011-07-14 22:25 ` Alex Elder
2011-07-14 22:31 ` Christoph Hellwig
2011-07-15 20:33 ` J. Bruce Fields
2011-07-16 1:50 ` [xfs-masters] " Dave Chinner
2011-07-16 1:53 ` Christoph Hellwig
2011-07-18 13:37 ` J. Bruce Fields [this message]
2011-07-19 19:29 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110718133710.GB9741@fieldses.org \
--to=bfields@fieldses.org \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=xfs-masters@oss.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).