* [PATCH] sunrpc/cache: remove the exporting of cache_seq_next
@ 2019-07-08 16:14 Denis Efremov
2019-07-08 23:23 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: Denis Efremov @ 2019-07-08 16:14 UTC (permalink / raw)
To: Trond Myklebust
Cc: Denis Efremov, J. Bruce Fields, Chuck Lever, Anna Schumaker,
David S. Miller, linux-nfs, netdev, linux-kernel
The function cache_seq_next is declared static and marked
EXPORT_SYMBOL_GPL, which is at best an odd combination. Because the
function is not used outside of the net/sunrpc/cache.c file it is
defined in, this commit removes the EXPORT_SYMBOL_GPL() marking.
Fixes: d48cf356a130 ("SUNRPC: Remove non-RCU protected lookup")
Signed-off-by: Denis Efremov <efremov@linux.com>
---
net/sunrpc/cache.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
index 66fbb9d2fba7..6f1528f271ee 100644
--- a/net/sunrpc/cache.c
+++ b/net/sunrpc/cache.c
@@ -1375,7 +1375,6 @@ static void *cache_seq_next(struct seq_file *m, void *p, loff_t *pos)
hlist_first_rcu(&cd->hash_table[hash])),
struct cache_head, cache_list);
}
-EXPORT_SYMBOL_GPL(cache_seq_next);
void *cache_seq_start_rcu(struct seq_file *m, loff_t *pos)
__acquires(RCU)
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sunrpc/cache: remove the exporting of cache_seq_next
2019-07-08 16:14 [PATCH] sunrpc/cache: remove the exporting of cache_seq_next Denis Efremov
@ 2019-07-08 23:23 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2019-07-08 23:23 UTC (permalink / raw)
To: Denis Efremov
Cc: Trond Myklebust, Chuck Lever, Anna Schumaker, David S. Miller,
linux-nfs, netdev, linux-kernel
Makes sense, thanks; apply for 5.3.--b.
On Mon, Jul 08, 2019 at 07:14:23PM +0300, Denis Efremov wrote:
> The function cache_seq_next is declared static and marked
> EXPORT_SYMBOL_GPL, which is at best an odd combination. Because the
> function is not used outside of the net/sunrpc/cache.c file it is
> defined in, this commit removes the EXPORT_SYMBOL_GPL() marking.
>
> Fixes: d48cf356a130 ("SUNRPC: Remove non-RCU protected lookup")
> Signed-off-by: Denis Efremov <efremov@linux.com>
> ---
> net/sunrpc/cache.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
> index 66fbb9d2fba7..6f1528f271ee 100644
> --- a/net/sunrpc/cache.c
> +++ b/net/sunrpc/cache.c
> @@ -1375,7 +1375,6 @@ static void *cache_seq_next(struct seq_file *m, void *p, loff_t *pos)
> hlist_first_rcu(&cd->hash_table[hash])),
> struct cache_head, cache_list);
> }
> -EXPORT_SYMBOL_GPL(cache_seq_next);
>
> void *cache_seq_start_rcu(struct seq_file *m, loff_t *pos)
> __acquires(RCU)
> --
> 2.21.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-08 23:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-08 16:14 [PATCH] sunrpc/cache: remove the exporting of cache_seq_next Denis Efremov
2019-07-08 23:23 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).