linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
To: linux-nfs@vger.kernel.org
Cc: bfields@fieldses.org, Tom Haynes <loghyr@gmail.com>,
	Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
Subject: [PATCH] st_flex: fix uid/gid formatting in error message
Date: Mon, 22 Jul 2019 16:16:02 +0200	[thread overview]
Message-ID: <20190722141602.14274-1-tigran.mkrtchyan@desy.de> (raw)

as ffds_user and ffds_group are utf8 encoded string use '%s' when
constructing an error message.

Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
---
 nfs4.1/server41tests/st_flex.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/nfs4.1/server41tests/st_flex.py b/nfs4.1/server41tests/st_flex.py
index 335b2c8..f4ac739 100644
--- a/nfs4.1/server41tests/st_flex.py
+++ b/nfs4.1/server41tests/st_flex.py
@@ -313,10 +313,10 @@ def testFlexLayoutTestAccess(t, env):
     gid_rd = ds.ffds_group
 
     if uid_rw == uid_rd:
-        fail("Expected uid_rd != %i, got %i" % (uid_rd, uid_rw))
+        fail("Expected uid_rd != %s, got %s" % (uid_rd, uid_rw))
 
     if gid_rw != gid_rd:
-        fail("Expected gid_rd == %i, got %i" % (gid_rd, gid_rw))
+        fail("Expected gid_rd == %s, got %s" % (gid_rd, gid_rw))
 
     res = close_file(sess, fh, stateid=open_stateid)
     check(res)
-- 
2.21.0


             reply	other threads:[~2019-07-22 14:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-22 14:16 Tigran Mkrtchyan [this message]
2019-08-01 20:01 ` [PATCH] st_flex: fix uid/gid formatting in error message J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190722141602.14274-1-tigran.mkrtchyan@desy.de \
    --to=tigran.mkrtchyan@desy.de \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=loghyr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).