* [PATCH] st_flex: fix uid/gid formatting in error message
@ 2019-07-22 14:16 Tigran Mkrtchyan
2019-08-01 20:01 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: Tigran Mkrtchyan @ 2019-07-22 14:16 UTC (permalink / raw)
To: linux-nfs; +Cc: bfields, Tom Haynes, Tigran Mkrtchyan
as ffds_user and ffds_group are utf8 encoded string use '%s' when
constructing an error message.
Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
---
nfs4.1/server41tests/st_flex.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/nfs4.1/server41tests/st_flex.py b/nfs4.1/server41tests/st_flex.py
index 335b2c8..f4ac739 100644
--- a/nfs4.1/server41tests/st_flex.py
+++ b/nfs4.1/server41tests/st_flex.py
@@ -313,10 +313,10 @@ def testFlexLayoutTestAccess(t, env):
gid_rd = ds.ffds_group
if uid_rw == uid_rd:
- fail("Expected uid_rd != %i, got %i" % (uid_rd, uid_rw))
+ fail("Expected uid_rd != %s, got %s" % (uid_rd, uid_rw))
if gid_rw != gid_rd:
- fail("Expected gid_rd == %i, got %i" % (gid_rd, gid_rw))
+ fail("Expected gid_rd == %s, got %s" % (gid_rd, gid_rw))
res = close_file(sess, fh, stateid=open_stateid)
check(res)
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] st_flex: fix uid/gid formatting in error message
2019-07-22 14:16 [PATCH] st_flex: fix uid/gid formatting in error message Tigran Mkrtchyan
@ 2019-08-01 20:01 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2019-08-01 20:01 UTC (permalink / raw)
To: Tigran Mkrtchyan; +Cc: linux-nfs, Tom Haynes
On Mon, Jul 22, 2019 at 04:16:02PM +0200, Tigran Mkrtchyan wrote:
> as ffds_user and ffds_group are utf8 encoded string use '%s' when
> constructing an error message.
Thanks, applied--sorry for being slow to get to this.
--b.
>
> Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
> ---
> nfs4.1/server41tests/st_flex.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/nfs4.1/server41tests/st_flex.py b/nfs4.1/server41tests/st_flex.py
> index 335b2c8..f4ac739 100644
> --- a/nfs4.1/server41tests/st_flex.py
> +++ b/nfs4.1/server41tests/st_flex.py
> @@ -313,10 +313,10 @@ def testFlexLayoutTestAccess(t, env):
> gid_rd = ds.ffds_group
>
> if uid_rw == uid_rd:
> - fail("Expected uid_rd != %i, got %i" % (uid_rd, uid_rw))
> + fail("Expected uid_rd != %s, got %s" % (uid_rd, uid_rw))
>
> if gid_rw != gid_rd:
> - fail("Expected gid_rd == %i, got %i" % (gid_rd, gid_rw))
> + fail("Expected gid_rd == %s, got %s" % (gid_rd, gid_rw))
>
> res = close_file(sess, fh, stateid=open_stateid)
> check(res)
> --
> 2.21.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-01 20:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-22 14:16 [PATCH] st_flex: fix uid/gid formatting in error message Tigran Mkrtchyan
2019-08-01 20:01 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).