* [PATCH -next] nfsd: remove set but not used variable 'len'
@ 2019-09-28 4:21 YueHaibing
2019-09-30 16:37 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-09-28 4:21 UTC (permalink / raw)
To: bfields, chuck.lever, trondmy; +Cc: linux-nfs, linux-kernel, YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:
fs/nfsd/nfs4xdr.c: In function nfsd4_encode_splice_read:
fs/nfsd/nfs4xdr.c:3464:7: warning: variable len set but not used [-Wunused-but-set-variable]
It is not used since commit 83a63072c815 ("nfsd: fix nfs read eof detection")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
fs/nfsd/nfs4xdr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index 533d0fc..1883370 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -3461,7 +3461,6 @@ static __be32 nfsd4_encode_splice_read(
struct xdr_stream *xdr = &resp->xdr;
struct xdr_buf *buf = xdr->buf;
u32 eof;
- long len;
int space_left;
__be32 nfserr;
__be32 *p = xdr->p - 2;
@@ -3470,7 +3469,6 @@ static __be32 nfsd4_encode_splice_read(
if (xdr->end - xdr->p < 1)
return nfserr_resource;
- len = maxcount;
nfserr = nfsd_splice_read(read->rd_rqstp, read->rd_fhp,
file, read->rd_offset, &maxcount, &eof);
read->rd_length = maxcount;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] nfsd: remove set but not used variable 'len'
2019-09-28 4:21 [PATCH -next] nfsd: remove set but not used variable 'len' YueHaibing
@ 2019-09-30 16:37 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2019-09-30 16:37 UTC (permalink / raw)
To: YueHaibing; +Cc: chuck.lever, trondmy, linux-nfs, linux-kernel
Thanks, applying for 5.5.--b.
On Sat, Sep 28, 2019 at 12:21:56PM +0800, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> fs/nfsd/nfs4xdr.c: In function nfsd4_encode_splice_read:
> fs/nfsd/nfs4xdr.c:3464:7: warning: variable len set but not used [-Wunused-but-set-variable]
>
> It is not used since commit 83a63072c815 ("nfsd: fix nfs read eof detection")
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> fs/nfsd/nfs4xdr.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index 533d0fc..1883370 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -3461,7 +3461,6 @@ static __be32 nfsd4_encode_splice_read(
> struct xdr_stream *xdr = &resp->xdr;
> struct xdr_buf *buf = xdr->buf;
> u32 eof;
> - long len;
> int space_left;
> __be32 nfserr;
> __be32 *p = xdr->p - 2;
> @@ -3470,7 +3469,6 @@ static __be32 nfsd4_encode_splice_read(
> if (xdr->end - xdr->p < 1)
> return nfserr_resource;
>
> - len = maxcount;
> nfserr = nfsd_splice_read(read->rd_rqstp, read->rd_fhp,
> file, read->rd_offset, &maxcount, &eof);
> read->rd_length = maxcount;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-30 16:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-28 4:21 [PATCH -next] nfsd: remove set but not used variable 'len' YueHaibing
2019-09-30 16:37 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).