* [PATCH] SUNRPC: Avoid RPC delays when exiting suspend
[not found] <329228f8-e194-a021-9226-69a9b6a403ce@nvidia.com>
@ 2019-11-05 14:21 ` Trond Myklebust
2019-11-06 11:15 ` Jon Hunter
0 siblings, 1 reply; 3+ messages in thread
From: Trond Myklebust @ 2019-11-05 14:21 UTC (permalink / raw)
To: Jon Hunter; +Cc: linux-nfs
Jon Hunter: "I have been tracking down another suspend/NFS related
issue where again I am seeing random delays exiting suspend. The delays
can be up to a couple minutes in the worst case and this is causing a
suspend test we have to fail."
Change the use of a deferrable work to a standard delayed one.
Reported-by: Jon Hunter <jonathanh@nvidia.com>
Fixes: 7e0a0e38fcfea ("SUNRPC: Replace the queue timer with a delayed work function")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
---
net/sunrpc/sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sunrpc/sched.c b/net/sunrpc/sched.c
index 360afe153193..987c4b1f0b17 100644
--- a/net/sunrpc/sched.c
+++ b/net/sunrpc/sched.c
@@ -260,7 +260,7 @@ static void __rpc_init_priority_wait_queue(struct rpc_wait_queue *queue, const c
rpc_reset_waitqueue_priority(queue);
queue->qlen = 0;
queue->timer_list.expires = 0;
- INIT_DEFERRABLE_WORK(&queue->timer_list.dwork, __rpc_queue_timer_fn);
+ INIT_DELAYED_WORK(&queue->timer_list.dwork, __rpc_queue_timer_fn);
INIT_LIST_HEAD(&queue->timer_list.list);
rpc_assign_waitqueue_name(queue, qname);
}
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] SUNRPC: Avoid RPC delays when exiting suspend
2019-11-05 14:21 ` [PATCH] SUNRPC: Avoid RPC delays when exiting suspend Trond Myklebust
@ 2019-11-06 11:15 ` Jon Hunter
2019-11-18 10:21 ` Jon Hunter
0 siblings, 1 reply; 3+ messages in thread
From: Jon Hunter @ 2019-11-06 11:15 UTC (permalink / raw)
To: Trond Myklebust; +Cc: linux-nfs, linux-tegra
On 05/11/2019 14:21, Trond Myklebust wrote:
> Jon Hunter: "I have been tracking down another suspend/NFS related
> issue where again I am seeing random delays exiting suspend. The delays
> can be up to a couple minutes in the worst case and this is causing a
> suspend test we have to fail."
>
> Change the use of a deferrable work to a standard delayed one.
>
> Reported-by: Jon Hunter <jonathanh@nvidia.com>
> Fixes: 7e0a0e38fcfea ("SUNRPC: Replace the queue timer with a delayed work function")
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> ---
> net/sunrpc/sched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sunrpc/sched.c b/net/sunrpc/sched.c
> index 360afe153193..987c4b1f0b17 100644
> --- a/net/sunrpc/sched.c
> +++ b/net/sunrpc/sched.c
> @@ -260,7 +260,7 @@ static void __rpc_init_priority_wait_queue(struct rpc_wait_queue *queue, const c
> rpc_reset_waitqueue_priority(queue);
> queue->qlen = 0;
> queue->timer_list.expires = 0;
> - INIT_DEFERRABLE_WORK(&queue->timer_list.dwork, __rpc_queue_timer_fn);
> + INIT_DELAYED_WORK(&queue->timer_list.dwork, __rpc_queue_timer_fn);
> INIT_LIST_HEAD(&queue->timer_list.list);
> rpc_assign_waitqueue_name(queue, qname);
> }
Thanks!
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Cheers
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] SUNRPC: Avoid RPC delays when exiting suspend
2019-11-06 11:15 ` Jon Hunter
@ 2019-11-18 10:21 ` Jon Hunter
0 siblings, 0 replies; 3+ messages in thread
From: Jon Hunter @ 2019-11-18 10:21 UTC (permalink / raw)
To: Trond Myklebust; +Cc: linux-nfs, linux-tegra
Hi Trond,
On 06/11/2019 11:15, Jon Hunter wrote:
>
> On 05/11/2019 14:21, Trond Myklebust wrote:
>> Jon Hunter: "I have been tracking down another suspend/NFS related
>> issue where again I am seeing random delays exiting suspend. The delays
>> can be up to a couple minutes in the worst case and this is causing a
>> suspend test we have to fail."
>>
>> Change the use of a deferrable work to a standard delayed one.
>>
>> Reported-by: Jon Hunter <jonathanh@nvidia.com>
>> Fixes: 7e0a0e38fcfea ("SUNRPC: Replace the queue timer with a delayed work function")
>> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
>> ---
>> net/sunrpc/sched.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/sunrpc/sched.c b/net/sunrpc/sched.c
>> index 360afe153193..987c4b1f0b17 100644
>> --- a/net/sunrpc/sched.c
>> +++ b/net/sunrpc/sched.c
>> @@ -260,7 +260,7 @@ static void __rpc_init_priority_wait_queue(struct rpc_wait_queue *queue, const c
>> rpc_reset_waitqueue_priority(queue);
>> queue->qlen = 0;
>> queue->timer_list.expires = 0;
>> - INIT_DEFERRABLE_WORK(&queue->timer_list.dwork, __rpc_queue_timer_fn);
>> + INIT_DELAYED_WORK(&queue->timer_list.dwork, __rpc_queue_timer_fn);
>> INIT_LIST_HEAD(&queue->timer_list.list);
>> rpc_assign_waitqueue_name(queue, qname);
>> }
>
> Thanks!
>
> Tested-by: Jon Hunter <jonathanh@nvidia.com>
I see this is now applied in -next, but I am seeing the failures on
mainline. Any chance we could still get this into v5.4?
Cheers
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-18 10:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <329228f8-e194-a021-9226-69a9b6a403ce@nvidia.com>
2019-11-05 14:21 ` [PATCH] SUNRPC: Avoid RPC delays when exiting suspend Trond Myklebust
2019-11-06 11:15 ` Jon Hunter
2019-11-18 10:21 ` Jon Hunter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).