From: "J. Bruce Fields" <bfields@redhat.com>
To: "J. R. Okajima" <hooanon05g@gmail.com>
Cc: trond.myklebust@hammerspace.com, linux-fsdevel@vger.kernel.org,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH]: nfs acl: bugfix, don't use static nfsd_acl_versions[]
Date: Mon, 6 Jan 2020 11:28:54 -0500 [thread overview]
Message-ID: <20200106162854.GA25029@pick.fieldses.org> (raw)
In-Reply-To: <29104.1578242282@jrobl>
Thanks, but, see 7c149057d044 "nfsd: restore NFSv3 ACL support", in
5.5-rc1; looks like you and I both stumbled on the identical fix?--b.
On Mon, Jan 06, 2020 at 01:38:02AM +0900, J. R. Okajima wrote:
> Here is a patch to fix nfs acl.
>
> J. R. Okajima
>
> ----------------------------------------
> commit 8684b9a7c55e9283e8b21112fbdf19b4d27f36b7
> Author: J. R. Okajima <hooanon05g@gmail.com>
> Date: Mon Jan 6 01:31:20 2020 +0900
>
> nfs acl: bugfix, don't use static nfsd_acl_versions[]
>
> By the commit for v5.2-rc1,
> e333f3bbefe3 2019-04-24 nfsd: Allow containers to set supported nfs versions
> the line to copy a value from nfsd_acl_version[] to static
> nfsd_acl_versions[] was removed. It is OK, but nfsd_acl_versions[] is
> still set to nfsd_acl_program.pg_vers which means pg_vers has NULLs for
> its all entires and nfsacl stops working entirely.
> I am afraid the removal of static nfsd_acl_versions[] was just
> forgotten.
>
> Signed-off-by: J. R. Okajima <hooanon05g@gmail.com>
>
> diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> index 18d94ea984ba..7f938bcb927d 100644
> --- a/fs/nfsd/nfssvc.c
> +++ b/fs/nfsd/nfssvc.c
> @@ -94,12 +94,11 @@ static const struct svc_version *nfsd_acl_version[] = {
>
> #define NFSD_ACL_MINVERS 2
> #define NFSD_ACL_NRVERS ARRAY_SIZE(nfsd_acl_version)
> -static const struct svc_version *nfsd_acl_versions[NFSD_ACL_NRVERS];
>
> static struct svc_program nfsd_acl_program = {
> .pg_prog = NFS_ACL_PROGRAM,
> .pg_nvers = NFSD_ACL_NRVERS,
> - .pg_vers = nfsd_acl_versions,
> + .pg_vers = nfsd_acl_version,
> .pg_name = "nfsacl",
> .pg_class = "nfsd",
> .pg_stats = &nfsd_acl_svcstats,
>
next prev parent reply other threads:[~2020-01-06 16:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-05 16:38 [PATCH]: nfs acl: bugfix, don't use static nfsd_acl_versions[] J. R. Okajima
2020-01-06 16:28 ` J. Bruce Fields [this message]
2020-01-06 16:55 ` J. R. Okajima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200106162854.GA25029@pick.fieldses.org \
--to=bfields@redhat.com \
--cc=hooanon05g@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).